Rooba
/
lightning
mirror of https://github.com/Lightning-AI/lightning.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

reviews

Jirka Borovec 2020-03-14 20:39:25 +01:00
parent 564500f483
commit f1f9d87e5f
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Cross-road.md

@ -1 +0,0 @@
Welcome to the pytorch-lightning wiki!

10
Review-guidelines.md Normal file

@ -0,0 +1,10 @@
Some recommended steps for reviewing open PRs.
1. Check the **source issues if the fix solves it**
2. Read the changes if they are aligned with our code-base
3. Check if the changes (fixed issue) are **covered by tests**
4. Check if the change is mentioned in **CHANGELOG** (no need for typos, docs and CI)
Hints:
- **be nice and constructive**, remember you fist PR and what helped you / made motivated to continue with contributing
- use suggestions for simple edits when you know what it shall be intead of long description (you can still add short justification of your proposal) so the author can simply accept it...