36 lines
2.0 KiB
Markdown
36 lines
2.0 KiB
Markdown
## What does this PR do?
|
|
|
|
<!--
|
|
Please include a summary of the change and which issue is fixed.
|
|
Please also include relevant motivation and context.
|
|
List any dependencies that are required for this change.
|
|
|
|
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
|
|
-->
|
|
|
|
Fixes # (issue)
|
|
|
|
## Before submitting
|
|
- [ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
|
|
- [ ] Did you read the [contributor guideline](https://github.com/PyTorchLightning/pytorch-lightning/blob/master/.github/CONTRIBUTING.md), Pull Request section?
|
|
- [ ] Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
|
|
- [ ] Did you make sure to update the documentation with your changes?
|
|
- [ ] Did you write any new necessary tests?
|
|
- [ ] Did you verify new and existing tests pass locally with your changes?
|
|
- [ ] If you made a notable change (that affects users), did you update the [CHANGELOG](https://github.com/PyTorchLightning/pytorch-lightning/blob/master/CHANGELOG.md)?
|
|
|
|
<!-- For CHANGELOG separate each item in unreleased section by a blank line to reduce collisions -->
|
|
|
|
## PR review
|
|
Anyone in the community is free to review the PR once the tests have passed.
|
|
Before you start reviewing make sure you have read [Review guidelines](https://github.com/PyTorchLightning/pytorch-lightning/wiki/Review-guidelines). In in short, see following bullet-list:
|
|
|
|
- [ ] Is this pull request ready for review? (if not, please submit in draft mode)
|
|
- [ ] Check that all items from **Before submitting** are resolved
|
|
- [ ] Make sure the title is self explanatory and the description concisely explains the PR
|
|
- [ ] Add labels and milestones (and optionally projects) to the PR so it can be classified; _Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases._
|
|
|
|
|
|
## Did you have fun?
|
|
Make sure you had fun coding 🙃
|