lightning/pytorch_lightning
Federico Baldassarre 65b4352930
early stopping checks on_validation_end (#1458)
* Fixes PyTorchLightning/pytorch-lightning#490

`EarlyStopping` should check the metric of interest `on_validation_end` rather than `on_epoch_end`. 
In a normal scenario, this does not cause a problem, but in combination with `check_val_every_n_epoch>1` in the `Trainer` it results in a warning or in a `RuntimeError` depending on `strict`.

* Highlighted that ES callback runs on val epochs in docstring

* Updated EarlyStopping in rst doc

* Update early_stopping.py

* Update early_stopping.rst

* Update early_stopping.rst

* Update early_stopping.rst

* Update early_stopping.rst

* Apply suggestions from code review

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

* Update docs/source/early_stopping.rst

* fix doctest indentation warning

* Train loop calls early_stop.on_validation_end

* chlog

Co-authored-by: William Falcon <waf2107@columbia.edu>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Jirka <jirka@pytorchlightning.ai>
2020-05-25 17:33:00 +00:00
..
callbacks early stopping checks on_validation_end (#1458) 2020-05-25 17:33:00 +00:00
core replace Hparams by init args (#1896) 2020-05-24 18:59:08 -04:00
loggers Re-Enable Import Errors (#1938) 2020-05-25 07:31:35 -04:00
logging Join Horovod workers at the end of trainer.fit() to prevent race conditions following training (#1786) 2020-05-12 09:15:25 +00:00
metrics New metric classes (#1326) (#1877) 2020-05-19 11:05:07 -04:00
overrides Add ddp_cpu backend for testing ddp without GPUs (#1158) 2020-04-15 23:17:31 -04:00
profiler replace Hparams by init args (#1896) 2020-05-24 18:59:08 -04:00
pt_overrides Join Horovod workers at the end of trainer.fit() to prevent race conditions following training (#1786) 2020-05-12 09:15:25 +00:00
root_module Join Horovod workers at the end of trainer.fit() to prevent race conditions following training (#1786) 2020-05-12 09:15:25 +00:00
trainer early stopping checks on_validation_end (#1458) 2020-05-25 17:33:00 +00:00
utilities New metric classes (#1326) (#1877) 2020-05-19 11:05:07 -04:00
__init__.py continue devel (#1793) 2020-05-17 08:30:45 -04:00