3f355d0eb7
Remove manual tracking of optimizer steps ( #9957 )
2021-10-18 12:43:06 +00:00
5e8829b97d
(1/n) tests: Use strategy flag instead of accelerator for training strategies ( #9931 )
...
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
2021-10-16 20:40:25 +05:30
28fc8d2016
Add `enable_model_summary` flag and deprecate `weights_summary` ( #9699 )
...
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kaushik B <kaushikbokka@gmail.com>
2021-10-13 17:20:54 +05:30
0f8fd20443
Remove epoch from `trainer.logged_metrics` ( #9904 )
2021-10-13 11:30:27 +02:00
8740c801bb
Fix typo in _validate_scheduler_optimizer() ( #9886 )
2021-10-11 09:16:17 +02:00
4decbc0d95
Deprecate `dataloader_idx` from `on_train_batch_start/end` ( #9816 )
...
* deprecate hooks
* dep todo
* explicit
* Apply suggestions from code review
* Apply suggestions from code review
* code review
* base
2021-10-07 10:18:11 +00:00
6d530373c0
Add warnings regarding unsupported keys in optim config and OneCycleLR ( #9666 )
...
* Add warnings regarding unsupported keys in optim config and OneCycleLR
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Fix docstring
* Update CHANGELOG.md
* Split into two parts
* Use difference operator to find extra keys
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2021-10-04 08:25:05 +00:00
0ddd6a8c19
Remove `_NATIVE_AMP_AVAILABLE` checks ( #9747 )
2021-09-29 15:34:26 +02:00
b3a5c7f442
Add `enable_progress_bar` to Trainer constructor ( #9664 )
2021-09-24 22:53:31 -07:00
b9fa69ea57
mark `FitLoop.should_accumulate` as protected ( #9515 )
...
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
2021-09-15 13:32:14 +00:00
23450e2905
Add custom logic to each `OutputResult` subclass [2/2] ( #9424 )
2021-09-15 12:18:19 +00:00
b1ed1db089
Keep global step update in the loop ( #8856 )
2021-09-14 19:21:39 +05:30
fe6062477f
Add `init_optimizers` test for predict ( #9440 )
...
* add predict
* Apply suggestions from code review
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2021-09-13 09:05:04 +01:00
15d943089d
Enforce that the optimizer closure is executed when `optimizer_step` is overridden ( #9360 )
2021-09-08 12:24:57 +02:00
6892d533ea
Run plugin closure before `on_before_optimizer_step` [1/2] ( #9288 )
...
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2021-09-07 11:52:20 +00:00
6e124e7207
CI: precommit - docformatter ( #8584 )
...
* CI: precommit - docformatter
* fix deprecated
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2021-09-06 12:49:09 +00:00
908e60dc85
Renamed `lr_dict` to `lr_scheduler_config` ( #9313 )
2021-09-04 00:47:43 +00:00
f959b13ab9
3/n inter batch parallelism ( #9052 )
...
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
2021-08-24 18:45:54 +00:00
4b6aaeeae3
fix plateau scheduler stepping on incomplete epoch ( #8861 )
2021-08-13 01:35:52 +00:00
f67892ea96
CI: yesqa ( #8564 )
...
* add yesqa
* fix flake8
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2021-08-02 16:05:56 +00:00
7901d297d3
remove support for optimizer_idx in the training_step for manual optimization ( #8576 )
2021-07-29 08:30:45 +00:00
d90cb7fceb
Bugfix: Scheduler monitor for manual optimization ( #7643 )
...
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: thomas chaton <thomas@grid.ai>
Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kaushik B <kaushikbokka@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2021-07-27 16:04:14 +05:30
a64cc37394
Replace `yapf` with `black` ( #7783 )
...
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2021-07-26 13:37:35 +02:00
6ce77a102b
Set minimum PyTorch version to 1.6 ( #8288 )
...
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
2021-07-13 17:12:49 +00:00
321689f52e
Add `ModelCheckpoint(save_on_train_epoch_end)` ( #8389 )
...
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2021-07-13 14:47:59 +00:00
c4353ea702
Remove `dev_debugger.call_count` ( #8317 )
2021-07-07 19:59:59 +02:00
9877265887
Simplify logger connector access ( #8318 )
2021-07-07 14:13:30 +02:00
f1341a555e
Remove deprecated optimizer argument from `manual_backward` ( #8287 )
...
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
2021-07-06 08:18:08 +00:00
4becd1cf31
rename old `Trainer.train_loop` -> `Trainer.fit_loop` ( #8025 )
2021-06-22 11:49:32 +02:00
d1efae2e47
Fix checkpointed state for lr_schedulers with step interval ( #7877 )
...
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2021-06-21 15:08:07 +00:00
ec4f8856af
Enable logger connector re-design ( #7891 )
...
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2021-06-09 14:24:45 +00:00
5593b6f772
Merge pull request #7872 from PyTorchLightning/refactor/logger-poc-changes
...
Random fixes for logger connector PoC
2021-06-08 09:04:16 -04:00
36770b22fd
validate manual optimization and supported features before running training ( #7788 )
...
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
2021-06-03 08:42:37 -07:00
0dd6d3a798
Avoid adding `None` loss values in `training_epoch_end` ( #7772 )
2021-05-31 19:28:28 +00:00
01109cdf0c
Fix/mismatched toggle optimizer ( #7563 )
...
* fix: avoid potential mismatched toggling of optimzier
Refs #7405
chore: update CHANGELOG
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
fix: resolve a confict
chore: update changelog
* feat: add a test that fails in master
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* fix typo in tests/trainer/optimization/test_multiple_optimizers.py
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
* Polish tests/trainer/optimization/test_multiple_optimizers.py
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
* Polish tests/trainer/optimization/test_multiple_optimizers.py
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
* fix: change placeholder in optimizer_step from positional args to keyword args
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
2021-05-23 04:30:28 +02:00
20f63377f8
Fix the condition for calling update_learning_rates ( #7032 )
...
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2021-05-17 17:20:42 +02:00
8c0ea92af2
`TrainerState` refactor [5/5] ( #7173 )
...
* `TrainerState` refactor
* flake8
* Update finished check
* Test cleanup
* Fix tests
* Fixes
* Reorder
* flake8
* Update CHANGELOG
* Better docs
* Better docs
* Remove default
* Update tests
* Bad merge
2021-05-04 12:50:56 +02:00
82c19e1444
Update LR schedulers only when their corresponding Optimizer is being… ( #4868 )
...
* Update LR schedulers only when their corresponding Optimizer is being used.
In the case when optimizer frequencies are specified,
the LR scheduler corresponding to a particular optimizer is updated
only when that optimizer is being used in the training loop or epoch.
* pep8speak fixes
* Fix failing tests
* Add docs
* PR Feedback
* Apply suggestions from code review
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
* formatting fix
* PR Feedback - part 2
* More PR feedback
* Apply suggestions from code review
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
* Add typing imports
* Stronger tests and fixes related to that
* Add more tests plus PR feedback
* Make optimizer_freq_cumsum a cached property
@cached_property is only available after Python 3.8 so had to do it manually.
* Fix tests
* Apply suggestions from code review
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
* Avoid mutable defaults
* Parametrize lr scheduling tests
* PR feedback
* Apply suggestions from code review
* spell
* Apply suggestions from code review
* flake8
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-05-04 09:37:40 +00:00
e0c64f0ef6
Fix Adagrad optimizer not working with DDP/GPU ( #7277 )
...
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
Co-authored-by: thomas chaton <thomas@grid.ai>
2021-05-03 03:57:17 +05:30
40f80230fe
Remove `trainer.fit` return value [2/n] ( #7237 )
...
* `_fit_impl` refactor and types
* Fix return
* Remove return docstring
* Fixes
* Fixes
* Remove `trainer.fit` return value
* Update CHANGELOG
* flake8
* Undo results change
* Fix test
* Revert changes for a separate PR
* flake8
2021-04-28 19:11:32 +01:00
f920ba29f2
[bugfix] Metric not logged properly in manual optimization ( #7228 )
...
* resolve bug
* update changelog
* typo
* Update tests/trainer/optimization/test_manual_optimization.py
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
* Apply suggestions from code review
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2021-04-27 09:16:51 -04:00
0302b8be32
Disable `lr_scheduler.step()` in manual optimization ( #6825 )
...
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: thomas chaton <thomas@grid.ai>
2021-04-20 13:00:45 +02:00
03a73b37bc
Train End Error Handling Fix ( #6864 )
...
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
Co-authored-by: Ethan Harris <ewah1g13@soton.ac.uk>
2021-04-14 20:35:42 +02:00
5e4dfd75d2
[RFC] Add `self.lr_schedulers()` to LightningModule for manual optimization ( #6567 )
...
* Add test for lr_schedulers()
* Add lr_schedulers to LightningModule
* Update test comment
* Update CHANGELOG
2021-04-09 10:32:14 +01:00
0dd2deebea
Remove legacy support for the magic `log`/`progress_bar` keys in dict returns ( #6734 )
2021-03-31 00:28:04 +02:00
b341b53f70
deprecate metrics pkg ( #6505 )
...
* deprecate metrics
* examples
* req
* docs
* Apply suggestions from code review
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
* pep8
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
2021-03-15 14:39:38 +00:00
f4cc7451a9
Add Trainer.validate(…) method to run one validation epoch ( #4948 )
...
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2021-03-11 03:46:37 +01:00
38a5fe7af1
Remove optimizer_idx arg in manual optimization ( #6093 )
...
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: chaton <thomas@grid.ai>
2021-03-07 08:48:50 +01:00
bf6ba83aef
prune duplicite test in optim ( #6312 )
2021-03-03 15:41:00 +09:00
d1a03153f3
Refactor: runif for spec 6/6 ( #6307 )
...
* special
* rpc
2021-03-02 18:57:13 +00:00
Carlos Mocholí