e147127c0e
[feat] Add better support for predict + ddp 2/3 ( #7215 )
...
* wip
* update
* update
* update
* update
* update
* typo
* update on comments
* update
* update
* update
* update
* update changelog
* update
* Fix merge
* Fix merge
* move code
* resolve test
* add extra test
* add an extra test
* update on comments
* add typing
* resolve flake8
* Refactor and Docs
* Fix tests
* Fix tests
* Fix tests
* Duplicate
* Fix tests
* resolve bug
* update
* update on comments
* update
* update changelog
* update
* update
* remove tpu
* resolve flake8
* update on comments
* update on comments
* update on comment
* resolve flake8
* add a cpu test for predict
* add None test
* update
* Update CHANGELOG.md
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
* resolve tests
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
2021-04-27 08:46:45 -04:00
3b36d81c03
Fixed `num_sanity_val_steps` affecting reproducibility of training data shuffling ( #7014 )
...
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: thomas chaton <thomas@grid.ai>
Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
2021-04-27 09:51:39 +00:00
345e9a0245
Fix argparse docs ( #7148 )
2021-04-22 02:13:00 +02:00
f29ecbfd90
Typing for accelerators and plugins ( #7022 )
2021-04-15 16:48:16 +00:00
f852a4f592
Changed basic_examples to use `LightningCLI` ( #6862 )
...
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
2021-04-15 15:01:16 +00:00
dcff5036a8
Use PickleError base class to detect all pickle errors ( #6917 )
...
* Use PickleError base class to detect all pickle errors
* Update changelog with #6917
* Add pickle test for torch ScriptModule
Co-authored-by: Ken Witham <k.witham@kri.neu.edu>
Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
2021-04-14 20:24:32 +00:00
9c9e2a0325
fix gpus default for Trainer.add_argparse_args ( #6898 )
2021-04-09 11:20:43 +02:00
86e1d9f759
[fix] Better support for rank_zero_only setting for SLURM and torchelastic ( #6802 )
...
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2021-04-07 12:25:13 +01:00
b7f3a3c421
Simple reproducibility with minimum boilerplate CLI training with `LightningCLI` ( #4492 )
...
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
2021-04-06 14:19:11 +01:00
3a4c4246ee
[TPU] update is_tpu_exists utils internal logic to rely on xmp.spawn ( #6719 )
...
* update_logic
* update
* Update tests/utilities/test_xla_device_utils.py
* Update pytorch_lightning/utilities/xla_device.py
Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
* Update pytorch_lightning/utilities/xla_device.py
Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
* update test
* Update tests/utilities/test_xla_device_utils.py
* update
* Apply fix
* Docstring
* flake8
* update
Co-authored-by: Your Name <you@example.com>
Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
2021-03-29 18:59:20 +01:00
21fc5eb21e
Automatically find and run special tests ( #6669 )
2021-03-26 17:04:59 +00:00
217c12a4e7
Simplify deprecations ( #6620 )
...
* use external deprecate
* simplify
* simplify
* simplify
* flake8
* .
* others
* .
2021-03-25 15:26:38 +01:00
b8ef52baa1
Match the number of outputs of backward with forward for AllGatherGrad ( #6625 )
2021-03-25 15:07:58 +05:30
fd5cb7fcc3
Add PyTorch 1.8 Profiler 5/5 ( #6618 )
...
* Refactor profilers
* Update PassThrough
* WIP - This is broken and will change
* Update pytorch_lightning/profiler/pytorch.py
Co-authored-by: thomas chaton <thomas@grid.ai>
* resolve tests
* resolve tests
* find output
* try something
* update
* add support for test and predict
* update
* update
* use getattr
* test
* test
* update
* tests
* update
* update
* update
* update
* update
* remove file
* update
* update
* update
* update
* update
* test
* update#
* update
* update tests
* update
* add suport for 1.8
* rename records
* add support for 1.8
* update
* resolve flake8
* resolve test
* Refactor basic profilers
* Fixes
* Unused import
* Introduce setup
* Profile on all ranks. Print to stdout on 0
* Introduce dirpath + filename
* CHANGELOG
* Add tests. Address comments
* add `on_run_stage_setup`
* add on_run_stage_setup function
* update
* add test for RegisterRecordFunction
* update lightnng flow direction
* move variable to private
* remove trace
* Undo code that should be in 3/4
* Multi-stage multi-rank
* 2/5 changes
* Pass stage in __del__
* Remove TODOs
* Describe on_evaluation_end. Add tests
* Typo
* Address comments
* deepcopy tests
* Advanced teardown
* Fix teardown test
* Fix tests
* Minor change
* Update CHANGELOG.md
* Fix test
* Quick fixes
* Fix 6522
* resolve ddp tests
* resolve tests
* resolve some tests
* update tests
* resolve tests
* update
* resolve tests
* resolve some tests
* Missed fixes from 3/5
* Fixes
* resolve some tests
* resolve test for 1.7.1
* Broken refactor
* Missed stage
* Minor changes
* resolve tests
* Update CHANGELOG
* resolve bug
* remove print
* Typo
* Cleanup
* resolve ddp test
* remove barrier
* update profiler
* update
* Smaller model
* update
* resolve tests
* update
* Minor changes. CHANGELOG
* Minimize diff
* update to 1.8.1
* RunIf. Extra code. Check segfault
* resolve tests
* Typo. Bad merge
* Fixing a bad merge
* replace for kineto
* Update pytorch_lightning/profiler/pytorch.py
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
* Update pytorch_lightning/profiler/pytorch.py
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
* Minor changes
* Bad merge
* Use lists for flexibility
* Use sets
* predict_step
* Ananth's suggestion
* update
* Docs
* Update pl_examples/basic_examples/profiler_example.py
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
* update example
* update example
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2021-03-23 20:43:21 +00:00
efce2b7777
Prune metrics: regression 8/n ( #6636 )
...
* explained_variance
* tests
* mean_absolute_error
* mean_squared_error
* mean_relative_error
* mean_squared_log_error
* chlog
2021-03-23 09:35:51 +01:00
853523ee64
Clean utilities/argparse and add missing tests ( #6607 )
2021-03-22 08:53:51 +00:00
9e35f979ea
Prune metrics: AUC & AUROC ( #6572 )
...
* class: AUC AUROC
* func: auc auroc
* format
* tests
2021-03-18 10:38:56 +01:00
297e438153
fix deprecation wrapper & tests ( #6553 )
...
* fix deprecation wrapper & tests
* flake8
2021-03-17 10:41:08 +00:00
555a6fea21
prune warning & deprecation wrapper ( #6540 )
...
* docs
* wrapper
* test
* count
* flake8
2021-03-16 14:55:31 +00:00
e886d55ac1
argparse: Add use_argument_group=True ( #6088 )
...
* argparse: Add inplace option
Replicate in GAN model
* datamodule: Deduplicate logic w/ argparser utilities
* Update pl_examples/domain_templates/generative_adversarial_net.py
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
* Apply suggestions from code review
Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
* Keep docstrings
* Correct name
* Whitespace
* Consistency
* fix weird type stuff
* try alt - use_argument_group
* fix syntax + lint
* fix ci errs
* fix ci
* change examples... still failing w/ "unrecognized arguments: --batch_size"
* address review
* mnist_datamodule: add some docstrings
* argparse: check cls or cls.__init__ for param
didn't capture issue, but meh
* fix lint
* fix no-doc edge case
* address review
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
2021-03-11 10:50:49 -05:00
7d4e74c745
[bug] All_gather support tensor on cpu ( #6416 )
...
* add test
* update changelog
* update
* rename function
2021-03-10 14:19:07 +00:00
facfda85f1
Remove no return warning from val/test step ( #6139 )
...
* remove warning
* auto_opt
* chlog
* auto_opt
* no_warning_call
* rm old code
* add warning for predict
* Apply suggestions from code review
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2021-03-06 17:15:21 +00:00
2a3ab67946
fix importing torchtext batch ( #6365 )
...
* copy torchtext batch
* update
* rev
* rev
2021-03-05 21:39:52 +01:00
e84854264f
CI: fix examples - patch download MNIST ( #6357 )
...
* patch download
* CI
* isort
* extra
2021-03-05 16:50:21 +00:00
48a10f16ef
Add `tests/utilities/test_parsing.py` ( #4460 )
...
* Create branch tests/4400_parsing
* Rename test file for parsing.py
* Fix lightning_hasattr
* Fix lightning_hasattr
* Fix lightning_setattr
* Add empty lines and remove rubbish spaces
* Raise AttributeError not ValueError
* Use getattr in hasattr
* Remove rubbish spaces
* Fix getattr
* Fix by flake8
* Add tests for str_to_bool_or_str
* Fix by flake8
* Add tests for str_to_bool
* Add tests for is_picklable
* Add tests for clean_namespace
* Fix typo
* Fix lightning_getattr
* Add tests for AttributeDict
* Add tests for flatten_dict
* Fix by flake8
* Apply suggestions from code review
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
* Apply isort
* Revert "Apply suggestions from code review"
* Define unpicklable_function outside
* Add comment to test_clean_namespace
* Add tests for parse_class_init_keys
* Add tests for get_init_args and collect_init_args
* Share objects across the tests
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Ethan Harris <ewah1g13@soton.ac.uk>
2021-03-04 19:58:10 +01:00
d1a03153f3
Refactor: runif for spec 6/6 ( #6307 )
...
* special
* rpc
2021-03-02 18:57:13 +00:00
ac583781db
Refactor: Runif for TPU and Horovod 5/n ( #6301 )
...
* TPU
* horovod
* extra
* fix
* Apply suggestions from code review
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
* doc
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
2021-03-02 16:21:20 +00:00
0f9134e043
Refactor: skipif for Windows 2/n ( #6268 )
...
* win
* isort
* flake8
2021-03-02 09:36:01 +00:00
eb815000f6
Refactor: skipif for multi - gpus 1/n ( #6266 )
...
* ngpus
* gpu
* isort
* pt
* flake8
2021-03-02 09:03:32 +01:00
1d9c553b86
prune deprecated Trainer arg `enable_pl_optimizer` ( #6163 )
...
* prune enable_pl_optimizer
* prune automatic_optimization
2021-02-24 10:01:24 +00:00
1c851b89e1
fixing miss-leading tested acc values ( #5876 )
...
* fixing tested values
* .
* tests
* yapf
* softmax
* hvd
* rename
* lr
* duplicate
* drop
* classif
* rm EvalModel
* Revert "rm EvalModel"
This reverts commit 6c3fb39ebe
2021-02-23 22:08:46 +00:00
3b0e4e0b2b
Enable ZeRO tests for CI, fix to/half function calls ( #6070 )
...
* Enable ZeRO optimization, and make sure that the lightning module hook is called when we move to half precision
* Added test, update to function
2021-02-21 00:24:44 +00:00
8f82823a08
Raise AttributeError in lightning_getattr and lightning_setattr when attribute not found ( #6024 )
...
* Empty commit
* Raise AttributeError instead of ValueError
* Make functions private
* Update tests
* Add match string
* Apply suggestions from code review
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
* lightning to Lightning
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2021-02-18 20:01:28 +00:00
c9fde04947
Make move_metrics_to_cpu work recursively ( #6007 )
...
* Propagate to_cpu flag down the recursion chain
* Refactor
* Add test
* Update CHANGELOG
* Update tests/utilities/test_memory.py
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
2021-02-16 21:52:42 +00:00
6d1e055a32
Prune EvalModelTemplate from callbacks and utilities ( #6018 )
...
* boring
* boring
2021-02-16 19:59:57 +00:00
e6a2ccc850
fix deprecated call ( #6005 )
2021-02-16 12:11:13 +01:00
bd920b4102
Refactor simplify tests ( #5861 )
...
* add new
* restructure
* yapf
* move
* fix
2021-02-08 11:52:02 +01:00
82943515dc
formatting tests1/n ( #5843 )
...
* utils
* tuner
* base
2021-02-06 08:22:10 -05:00
f83cca6107
formatting flake8 & isort ( #5824 )
...
* formatting
* isort
* make
* yapf
* isort
2021-02-05 18:33:12 -05:00
da5ba50727
Unify attribute finding logic, fix not using dataloader when hparams present ( #4559 )
...
* Rebase onto master
* indent fix
* Remove duplicated logic
* Use single return
* Remove extra else
* add `__contains__` to TestHparamsNamespace to fix tests
* Fix lightning_setattr to set all valid attributes
* update doc
* better names
* fix holder order preference
* tests for new behavior
* Comment about using the last holder
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Sean Naren <sean.narenthiran@gmail.com>
(cherry picked from commit eee3b1a284
2021-02-04 20:55:41 +01:00
b3b48c188c
fix error when logging to progress bar with reserved name ( #5620 )
...
* warn about duplicate metrics
* update changelog
* suggestions from rohit
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
* multiple values in message
* Apply suggestions from code review
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-02-04 20:55:41 +01:00
b95471d4a4
Increase TPU check timeout ( #5598 )
...
* change timeout to 100
* add to CHANGELOG.md
* update test
* updates
* reduce TPU_TIMEOUT_CONSTANT during test
* Update tests/utilities/test_xla_device_utils.py
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
* patch TPU_TIMEOUT_CONSTANT
* Apply suggestions from code review
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-02-04 20:55:41 +01:00
53b0ae49b9
fix imports / isort / flake8
2021-01-26 14:57:34 +01:00
0c370ade51
[BUG] Check environ before selecting a seed to prevent warning message ( #4743 )
...
* Check environment var independently to selecting a seed to prevent unnecessary warning message
* Add if statement to check if PL_GLOBAL_SEED has been set
* Added seed test to ensure that the seed stays the same, in case
* if
* Delete global seed after test has finished
* Fix code, add tests
* Ensure seed does not exist before tests start
* Refactor test based on review, add log call
* Ensure we clear the os environ in patched dict
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: chaton <thomas@grid.ai>
(cherry picked from commit 635df27880
2021-01-26 14:28:47 +01:00
b9530d291e
Fix pre-commit isort failure on tests/utilities/*.py ( #5420 )
...
* Remove tests.utilities from skipped module in pyproject.toml
* Fix pre-commit isort failure on tests/utilities/*.py
2021-01-11 14:00:39 -05:00
be255de306
Bugfix/all gather ( #5221 )
...
* resolve bug
* add tests
* add tests
* resolve flake8
* update
* update
* remove globals
* typo
* Update pytorch_lightning/utilities/distributed.py
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
* update
* update
* add suport int, float
* update
* resolve pep8
* Update pytorch_lightning/core/lightning.py
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
* Update tests/utilities/test_all_gather_grad.py
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
* update doc
* add bool and np.ndarray
* resolve conflicts
* resolve conflicts
* resolve pep8
* add changelog
* Update pytorch_lightning/core/lightning.py
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Ubuntu <ubuntu@ip-172-31-62-109.ec2.internal>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2021-01-09 07:37:44 -05:00
a884866ff0
Unify names in Utils ( #5199 )
...
* warnings
* argparse
* mutils
* xla device
* deprecated
* tests
* simple
* flake8
* fix
* flake8
* 1.4
2020-12-22 00:23:33 +01:00
0f36525e8f
fix/enable - check F401 ( #5201 )
...
* refactor - check F401
* missed
* fix
2020-12-21 10:15:04 +01:00
35fd6e93c7
refactor - check E501 ( #5200 )
2020-12-21 14:23:09 +05:30
059eaecbb4
set xxx_AVAILABLE as protected ( #5082 )
...
* sett xxx_AVAILABLE as protected
* docs
2020-12-14 20:19:05 +05:30
thomas chaton