b730a5a281
Do not describe when there's no summary ( #6681 )
2021-03-26 14:58:05 +00:00
0ea8f39841
Resolve schedule step bug for PyTorch Profiler ( #6674 )
...
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
2021-03-25 17:03:06 +01:00
fd5cb7fcc3
Add PyTorch 1.8 Profiler 5/5 ( #6618 )
...
* Refactor profilers
* Update PassThrough
* WIP - This is broken and will change
* Update pytorch_lightning/profiler/pytorch.py
Co-authored-by: thomas chaton <thomas@grid.ai>
* resolve tests
* resolve tests
* find output
* try something
* update
* add support for test and predict
* update
* update
* use getattr
* test
* test
* update
* tests
* update
* update
* update
* update
* update
* remove file
* update
* update
* update
* update
* update
* test
* update#
* update
* update tests
* update
* add suport for 1.8
* rename records
* add support for 1.8
* update
* resolve flake8
* resolve test
* Refactor basic profilers
* Fixes
* Unused import
* Introduce setup
* Profile on all ranks. Print to stdout on 0
* Introduce dirpath + filename
* CHANGELOG
* Add tests. Address comments
* add `on_run_stage_setup`
* add on_run_stage_setup function
* update
* add test for RegisterRecordFunction
* update lightnng flow direction
* move variable to private
* remove trace
* Undo code that should be in 3/4
* Multi-stage multi-rank
* 2/5 changes
* Pass stage in __del__
* Remove TODOs
* Describe on_evaluation_end. Add tests
* Typo
* Address comments
* deepcopy tests
* Advanced teardown
* Fix teardown test
* Fix tests
* Minor change
* Update CHANGELOG.md
* Fix test
* Quick fixes
* Fix 6522
* resolve ddp tests
* resolve tests
* resolve some tests
* update tests
* resolve tests
* update
* resolve tests
* resolve some tests
* Missed fixes from 3/5
* Fixes
* resolve some tests
* resolve test for 1.7.1
* Broken refactor
* Missed stage
* Minor changes
* resolve tests
* Update CHANGELOG
* resolve bug
* remove print
* Typo
* Cleanup
* resolve ddp test
* remove barrier
* update profiler
* update
* Smaller model
* update
* resolve tests
* update
* Minor changes. CHANGELOG
* Minimize diff
* update to 1.8.1
* RunIf. Extra code. Check segfault
* resolve tests
* Typo. Bad merge
* Fixing a bad merge
* replace for kineto
* Update pytorch_lightning/profiler/pytorch.py
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
* Update pytorch_lightning/profiler/pytorch.py
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
* Minor changes
* Bad merge
* Use lists for flexibility
* Use sets
* predict_step
* Ananth's suggestion
* update
* Docs
* Update pl_examples/basic_examples/profiler_example.py
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
* update example
* update example
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2021-03-23 20:43:21 +00:00
51b10f78f4
Refactor PyTorch profiler 4/5 ( #6349 )
...
Co-authored-by: thomas chaton <thomas@grid.ai>
2021-03-23 18:13:29 +01:00
36d180e532
Refactor base profilers 3/5 ( #6621 )
...
Co-authored-by: tchaton <thomas@grid.ai>
2021-03-23 10:07:35 +00:00
2064ece582
[refactor] Add setup to profilers + _run_stage_setup to trainer 2/5 ( #6633 )
...
* add setup
* update
* updates on comment
* Minor changes
* Extra import
* Docs
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
2021-03-22 14:32:31 -04:00
e2e1de0fb7
Add teardown method to BaseProfiler. ( #6370 )
...
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
2021-03-22 11:49:06 +00:00
2ec67a48b3
[bug] Fix Pytorch profiler with emit_nvtx ( #6260 )
...
* resolve bug
* update changelog
* Update tests/trainer/test_trainer.py
* Update pytorch_lightning/profiler/profilers.py
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
* resolve comments
* resolve flake8
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2021-03-05 21:12:03 +01:00
bc577ca792
fix duplicate console logging bug v2 ( #6275 )
...
Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2021-03-02 15:17:55 +05:30
0f9134e043
Refactor: skipif for Windows 2/n ( #6268 )
...
* win
* isort
* flake8
2021-03-02 09:36:01 +00:00
dc8647e333
split profilers ( #6261 )
2021-03-02 07:57:49 +00:00
8aba88506f
Document Exceptions in profilers ( #6229 )
...
* docstring changes in profilers
* minor changes in profilers.py
2021-03-01 14:16:06 +01:00
9dd56398e3
fixing some compatibility with PT 1.8 ( #5864 )
...
* change default
* .
* p
* 0.21.2
* .
* fix
* .
2021-02-09 18:25:57 +01:00
79d42d83e7
formatting 3/n: PL modules ( #5716 )
...
* cb
* log
* prof
* tune
* flake8
2021-02-08 14:28:38 -05:00
5f3372871a
[feat] Add PyTorch Profiler. ( #5560 )
...
* add profiler
* add profiler
* update
* resolve flake8
* update doc
* update changelog
* clean doc
* delete prof file
* merge pr codebase
* update
* update doc
* update doc
* update doc
* update on comments
* update docstring
* update docstring
* try
* update test
* Update pytorch_lightning/profiler/__init__.py
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
* Update pytorch_lightning/profiler/__init__.py
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
* update on comments
* remove old code
* add support for ddp
* resolve flake8
* Update pytorch_lightning/profiler/__init__.py
Co-authored-by: Sean Naren <sean.narenthiran@gmail.com>
* resolve tests
* resolve flake8
Co-authored-by: Jirka Borovec <jirka.borovec@seznam.cz>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Sean Naren <sean.narenthiran@gmail.com>
2021-01-26 06:48:54 -05:00
6386b8d36b
Fix isort a few failures ( #5504 )
...
Remove from skipped module in pyproject.toml and fix failures on:
- pytorch_lightning/callbacks/*.py
- pytorch_lightning/cluster_environments/*.py
- pytorch_lightning/profiler/*.py
- pytorch_lightning/tuner/*.py
Co-authored-by: Jirka Borovec <jirka.borovec@seznam.cz>
Co-authored-by: Jirka Borovec <jirka.borovec@seznam.cz>
2021-01-15 17:44:27 -05:00
0f36525e8f
fix/enable - check F401 ( #5201 )
...
* refactor - check F401
* missed
* fix
2020-12-21 10:15:04 +01:00
3a8fa6bf11
update
2020-11-27 17:48:51 +00:00
290d74b40e
resolve test
2020-11-27 16:47:13 +00:00
bf573607f8
better simple profiler
2020-11-27 16:34:51 +00:00
baa8558cc0
logger docs and api docs ( #3950 )
...
* logger and api docs
* remove gpu_usage_logger, lr_logger
* update docstring
* fix wandb example
* remove step result
* charts
* add some charts info
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
2020-11-13 20:35:54 +05:30
c50c225f05
feature: Allow str arguments in Trainer.profiler ( #3656 )
...
* allow trainer's profiler param to have a str value
* add tests
* update docs
* update exception message
* Update CHANGELOG
* fix pep8 issues
* cleanup test code
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
* Add deprecation warning if using bool for profiler
* Add deprecation tests and move deprecated tests
* Remove bool option to profiler from docs
* Deprecate bool args to profiler in CHANGELOG
* fixup! Add deprecation warning if using bool for profiler
* fixup! Add deprecation tests and move deprecated tests
* Apply suggestions from code review
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
* Implement suggestions, remove whitespace
* fixup! Implement suggestions, remove whitespace
* Allow bool, str (case insensitive), BaseProfiler
* Add info about bool deprecation to trainer
* fixup! Add info about bool deprecation to trainer
* Move deprecate todo to test_deprecated
* Test wrong profiler type, improve error message
* fixup! Test wrong profiler type, improve error message
* Update pytorch_lightning/trainer/connectors/profiler_connector.py
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
* Apply suggestions from code review
* Readd bool to profiler types, test cli profiler arg
* Remove extra whitespace in doc
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
* Apply suggestions from code review
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
* Update deprecation versions
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2020-10-27 16:27:16 +05:30
c8ccec7a02
Enable profilers to write to remote files with fsspec ( #4162 )
...
* Update profilers.py
Enable profilers to use write to remote files with fsspec
* Update profilers.py
* Update CHANGELOG.md
* Update pytorch_lightning/profiler/profilers.py
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
* formatting
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
2020-10-25 18:21:42 +01:00
b45b57cc58
Use `Optional` for arguments set to `None` by default ( #4164 )
...
* Use `Optional` for variables set to `None` by default
* Use `Optional` instead of `Union[None, ...]` for consistency
2020-10-15 23:02:50 +02:00
1adac8f5cf
Fix docs ( #4174 )
2020-10-15 20:25:55 +02:00
f43028f3ae
added copyright notices ( #3062 )
2020-08-19 22:03:22 -04:00
caa9c6760b
replace Hparams by init args ( #1896 )
...
* remove the need for hparams
* remove the need for hparams
* remove the need for hparams
* remove the need for hparams
* replace self.hparams
* replace self.hparams
* replace self.hparams
* replace self.hparams
* replace self.hparams
* replace self.hparams
* replace self.hparams
* replace self.hparams
* replace self.hparams
* replace self.hparams
* replace self.hparams
* replace self.hparams
* replace self.hparams
* replace self.hparams
* replace self.hparams
* replace self.hparams
* replace self.hparams
* replace self.hparams
* replace self.hparams
* replace self.hparams
* replace self.hparams
* replace self.hparams
* replace self.hparams
* replace self.hparams
* replace self.hparams
* replace self.hparams
* replace self.hparams
* replace self.hparams
* replace self.hparams
* replace self.hparams
* replace self.hparams
* replace self.hparams
* fixed
* fixed
* fixed
* fixed
* fixed
* fixed
* fixed
* fixed
* fixed
* fixed
* fixed
* fixed
* fixed
* fixed
* finished moco
* basic
* testing
* todo
* recurse
* hparams
* persist
* hparams
* chlog
* tests
* tests
* tests
* tests
* tests
* tests
* review
* saving
* tests
* tests
* tests
* docs
* finished moco
* hparams
* review
* Apply suggestions from code review
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
* hparams
* overwrite
* transform
* transform
* transform
* transform
* cleaning
* cleaning
* tests
* examples
* examples
* examples
* Apply suggestions from code review
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
* chp key
* tests
* Apply suggestions from code review
* class
* updated docs
* updated docs
* updated docs
* updated docs
* save
* wip
* fix
* flake8
Co-authored-by: Jirka <jirka@pytorchlightning.ai>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2020-05-24 18:59:08 -04:00
6ddb03922a
Profiler summary ( #1259 )
...
* refactor and add types
* add Prorfiler summary
* fix imports
* Revert "refactor and add types"
This reverts commit b4c552fa
* changelog
* revert rename
* fix test
* mute verbose
2020-03-31 08:57:48 -04:00
09167efdb5
Checkpointing interval ( #1272 )
...
* formatting
* formatting
* fix interval
* fix train loop
* fix test
* parametrize test
* Apply suggestions from code review
Co-Authored-By: Adrian Wälchli <adrian.waelchli@students.unibe.ch>
* fix calling
* flake8
* add types
Co-authored-by: Adrian Wälchli <adrian.waelchli@students.unibe.ch>
Co-authored-by: William Falcon <waf2107@columbia.edu>
2020-03-30 18:37:02 -04:00
4c2026bf9a
increase profiler test coverage ( #1208 )
...
* increase profiler test coverage
* fix line length
* tests for valueerror assertions
2020-03-24 09:15:16 -04:00
22a7264e9a
improve partial Codecov ( #1172 )
...
* ignore in setup
* show report
* abs imports
* abstract pass
* cover loggers
* doctest trains
* locals
* pass
* revert tensorboard
* use tensorboardX
* revert tensorboardX
* fix trains
* Add TrainsLogger.set_credentials (#1179 )
* Add TrainsLogger.set_credentials to control trains server configuration and authentication from code. Sync trains package version.
Fix CI Trains tests
* Add global TrainsLogger set_bypass_mode (#1187 )
* Add global TrainsLogger set_bypass_mode skips all external communication
Co-authored-by: bmartinn <>
* rm some no-cov
Co-authored-by: Martin.B <51887611+bmartinn@users.noreply.github.com>
2020-03-19 09:14:29 -04:00
1a73fa0b03
change default logger to dedicated one ( #1064 )
...
Fix test
Fix format
Update pytorch_lightning/__init__.py
Separate imports
2020-03-17 18:44:00 -04:00
514d182b7f
cleaning imports ( #1032 )
2020-03-12 12:41:37 -04:00
29faea1862
Steps ( #1051 )
...
* training_end renamed to training_step_end
* training_end renamed to training_step_end
* training_end renamed to training_step_end
* training_end renamed to training_step_end
* training_end to training_step_end
* training_end to training_step_end
* training_end to training_step_end
* training_end to training_step_end
* fix lost model reference
* training_end to training_step_end
* training_end to training_step_end
* training_end to training_step_end
* training_end to training_step_end
* training_end to training_step_end
* training_end to training_step_end
* training_end to training_step_end
* training_end to training_step_end
* training_end to training_step_end
* training_end to training_step_end
* training_end to training_step_end
* training_end to training_step_end
* training_end to training_step_end
* training_end to training_step_end
* training_end to training_step_end
* training_end to training_step_end
* training_end to training_step_end
* training_end to training_step_end
* training_end to training_step_end
* training_end to training_step_end
* training_end to training_step_end
* training_end to training_step_end
* training_end to training_step_end
* training_end to training_step_end
* training_end to training_step_end
* training_end to training_step_end
* training_end to training_step_end
* training_end to training_step_end
2020-03-05 12:32:45 -05:00
04c9eb49d0
drop logging level ( #1015 )
2020-03-02 20:30:16 -05:00
4ae31cd1d5
advanced profiler describe + cleaned up tests ( #837 )
...
* add py36 compatibility
* add test case to capture previous bug
* clean up tests
* clean up tests
2020-02-15 23:43:43 -05:00
4c6c3d04ce
Docs ( #813 )
...
* added outline of all features
* updated common use cases doc
* updated common use cases doc
* updated common use cases doc
* updated common use cases doc
* updated common use cases doc
* updated common use cases doc
* updated common use cases doc
* updated common use cases doc
* updated common use cases doc
* updated common use cases doc
* updated common use cases doc
* updated common use cases doc
* updated common use cases doc
* updated docs
2020-02-10 23:55:22 -05:00
1cf430f7bc
new feature for profiling training runs ( #782 )
...
* initial implementation
* formatting, pass through profiler, docstring
* call profiler during training
* add initial tests
* report stats when training is done
* fix formatting
* error handling, bugfix in passthroughprofiler
* finish documenting profiler arg in Trainer
* relax required precision for profiling tests
* option to dump cProfiler results to text file
* use logging, format with black
* include profiler in docs
* improved logging and better docs
* appease the linter
* better summaries, wrapper for iterables
* fix typo
* allow profiler=True creation
* more documentation
* add tests for advanced profiler
* Update trainer.py
* make profilers accessible in pl.utilities
* reorg profiler files
* change import for profiler tests
Co-authored-by: William Falcon <waf2107@columbia.edu>
2020-02-06 22:01:21 -05:00
Carlos Mocholí