d962ab5d89
Fix lr key name in case of param groups ( #1719 )
...
* Fix lr key name in case of param groups
* Add tests
* Update test and added configure_optimizers__param_groups
* Update CHANGELOG
2020-05-10 17:05:34 -04:00
7f64ad7a33
Fix Docker Pipeline ( #1765 )
...
* Update and rename docker_builds.yml to docker_nightly_builds.yml
* Update and rename docker_nightly_builds.yml to docker_builds.yml
* Update docker_builds.yml
* Update .github/workflows/docker_builds.yml
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2020-05-10 17:04:51 -04:00
0cb6767465
Fix NeptuneLogger to work in ddp mode ( #1753 )
2020-05-10 13:19:18 -04:00
ee17c7c9c8
Fixed error message and test docstring ( #1698 )
...
training_dataloader -> train_dataloader
Co-authored-by: Alexander Kreuzer <alexander.kreuzer@sap.com>
2020-05-10 13:16:16 -04:00
76af84718a
Group argument wandb ( #1760 )
...
* group argument wandb
* formatting fix
2020-05-10 13:15:51 -04:00
134eb61e1a
Tests: refactor cleanup ( #1744 )
...
* wip
* cleaning
* optim imports
* -
* default hparams
* fix restore
* fix imports
2020-05-10 13:15:28 -04:00
4970927ec8
Feature: auto scale batch size ( #1638 )
...
* auto batch finder
* fix styling
* add description
* add different modes
* fix copy paste error
* better organised code
* fix styling
* add tests
* fix
* fix
* add some documentation
* added CHANGELOG.md
* some documentation
* update based on review
* Update trainer.py
* Update docs/source/training_tricks.rst
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
* Update tests/trainer/test_trainer_tricks.py
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
* Update tests/trainer/test_trainer_tricks.py
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
* Apply suggestions from code review
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
* use EvalModelTemplate
* param tests
* rename
* wrap params
* rename function
* rename
* rename param
* fix
* abs
* rename
* refactor code
* add docs
* try
* arg
* loop
* exept
* loop
* drop bool
* docs
* docs
* added check and test for passing dataloader to fit
* styling fix
* update based on review
Co-authored-by: Nicki Skafte <nugginea@gmail.com>
Co-authored-by: William Falcon <waf2107@columbia.edu>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
2020-05-09 08:28:36 -04:00
25bbd059df
Also update progress_bar in training_epoch_end ( #1724 )
...
* update prog. bar metrics on train epoch end
* changelog
* wip test
* more thorough testing
* comments
* update docs
* move test
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
2020-05-08 23:31:56 -04:00
3a642601e8
added warning for None dataloader ( #1745 )
...
* added warning for None dataloader
* fixed variable style
* updated warning message
* remove unused import
Co-authored-by: ybrovman <ybrovman@ebay.com>
2020-05-07 09:26:41 -04:00
f656882942
Fix typo ( #1750 )
2020-05-07 09:25:54 -04:00
b9364f96b1
lr_finder: Fix typo in docstring ( #1746 )
2020-05-06 12:39:22 -04:00
851866333c
Attach version_ to checkpoint path only if version is int ( #1748 )
2020-05-06 12:38:32 -04:00
0cb58fbb4c
Mock packages for RTD docs build (follow up to doctests) ( #1739 )
...
* mock all packages on RTD
* update
2020-05-05 16:48:45 -04:00
35bbe178bd
fix _reset_eval_dataloader() for IterableDataset ( #1560 )
...
* removed if dl from _reset_eval_dataloader()
* changed to if dl != None to be more safe
* hints from pep8speaks
Co-authored-by: ybrovman <ybrovman@ebay.com>
2020-05-05 14:09:48 -04:00
fc7f5919b5
improve pickle tests for callbacks ( #1717 )
...
* improve pickle tests for callbacks
* set mode dict as a class attr
2020-05-05 14:08:54 -04:00
2b03d34931
complete test ( #1705 )
2020-05-05 14:08:15 -04:00
d6a0375974
Fixing logic ( #1734 )
2020-05-05 14:07:26 -04:00
2a2f303ae9
Tests: refactor trainer dataloaders ( #1690 )
...
* refactor default model
* drop redundant seeds
* refactor dataloaders tests
* fix multiple
* fix conf
* flake8
* Apply suggestions from code review
Co-authored-by: William Falcon <waf2107@columbia.edu>
Co-authored-by: William Falcon <waf2107@columbia.edu>
2020-05-05 12:31:15 -04:00
a6de1b8d75
doctest for .rst files ( #1511 )
...
* add doctest to circleci
* Revert "add doctest to circleci"
This reverts commit c45b34ea911a81f87989f6c3a832b1e8d8c471c6.
* Revert "Revert "add doctest to circleci""
This reverts commit 41fca97fdcfe1cf4f6bdb3bbba75d25fa3b11f70.
* doctest docs rst files
* Revert "doctest docs rst files"
This reverts commit b4a2e83e3da5ed1909de500ec14b6b614527c07f.
* doctest only rst
* doctest debugging.rst
* doctest apex
* doctest callbacks
* doctest early stopping
* doctest for child modules
* doctest experiment reporting
* indentation
* doctest fast training
* doctest for hyperparams
* doctests for lr_finder
* doctests multi-gpu
* more doctest
* make doctest drone
* fix label build error
* update fast training
* update invalid imports
* fix problem with int device count
* rebase stuff
* wip
* wip
* wip
* intro guide
* add missing code block
* circleci
* logger import for doctest
* test if doctest runs on drone
* fix mnist download
* also run install deps for building docs
* install cmake
* try sudo
* hide output
* try pip stuff
* try to mock horovod
* Tranfer -> Transfer
* add torchvision to extras
* revert pip stuff
* mlflow file location
* do not mock torch
* torchvision
* drone extra req.
* try higher sphinx version
* Revert "try higher sphinx version"
This reverts commit 490ac28e46d6fd52352640dfdf0d765befa56988.
* try coverage command
* try coverage command
* try undoc flag
* newline
* undo drone
* report coverage
* review
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
* remove torchvision from extras
* skip tests only if torchvision not available
* fix testoutput torchvision
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2020-05-04 22:16:54 -04:00
48e808c20e
Move generated RST files to subfolder ( #1555 )
...
* move generated files to subfolder
* remove if exists
* reformat argv
Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com>
* update rebase
* rebase yml
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: J. Borovec <jirka.borovec@seznam.cz>
2020-05-04 16:53:06 -04:00
043ae697c2
Tests: refactor callbacks ( #1688 )
...
* refactor default model
* drop redundant seeds
* path
* refactor callback tests
* update
* fix sch
* wip
* fix return
* review
2020-05-04 16:52:22 -04:00
6d58fb1353
Tests: refactor trainer ( #1728 )
...
* lr
* optim
* wip
* wip
* fix mean
* flake8
2020-05-04 16:51:39 -04:00
f90afa29b8
Fix disabling progress bar on non-zero ranks using Horovod backend ( #1709 )
...
* Fix Horovod backend to disable progress bar on all ranks except 0
* Add join barriers
* Added changelog
* Make protected and add verbosity
* Refactor to disable progress bar callback in train
* Removed vebose setting
* Add cache check for Horovod
* Test run again
* Updated comment
* Always skip cache for Horovod
* Only reinstall when necessary
* Added separate step
* Fixed spacing
* Skip Python 3.8
2020-05-04 13:02:57 -04:00
1a9f1c80a1
Fix example argument parser in docs ( #1692 )
...
[`parser.parse_known_args()`](https://docs.python.org/3.7/library/argparse.html#argparse.ArgumentParser.parse_known_args ) actually returns a tuple of the Namespace of known args and a list of unknown args. We only want the former.
2020-05-04 11:40:50 -04:00
e865b046b1
Bugfix/lr finder ( #1676 )
...
* fix early stopping bug
* allow val dataloader
* update CHANGELOG.md
* fix early stopping bug
* allow val dataloader
* update CHANGELOG.md
Co-authored-by: Nicki Skafte <nugginea@gmail.com>
2020-05-04 11:38:51 -04:00
1077159834
Tests: refactor models ( #1691 )
...
* refactor default model
* drop redundant seeds
* drop redundant seeds
* refactor models tests
* refactor models tests
* imports
* fix conf
* Apply suggestions from code review
2020-05-04 11:38:08 -04:00
d28b145393
Update type hints for multiple dataloaders in .fit() and .test() ( #1723 )
...
* update typehints
* change log
2020-05-04 08:24:34 -04:00
0cd5e64701
Tests: refactor loggers ( #1689 )
...
* refactor default model
* drop redundant seeds
* path
* refactor loggers tests
* imports
2020-05-04 07:13:52 -04:00
281a73ccf7
specify cache matrix ( #1725 )
2020-05-04 07:13:11 -04:00
595ec65796
refactor trainer checks ( #1651 )
...
* refactor trainer checks
* opt
* none
* Apply suggestions from code review
* imports
* fix tensors
2020-05-04 01:25:48 -04:00
e6b34ef90d
[WIP] Reduction when batch size < num gpus ( #1609 )
...
* reduce if <= num_gpus
* add test with explanation
* chlog
* fix changelog
Co-authored-by: J. Borovec <jirka.borovec@seznam.cz>
2020-05-02 11:01:44 -04:00
fafe5d63a7
Transfer learning example ( #1564 )
...
* Fine tuning example.
* Fix (in train method) + Borda's comments (added argparse + fixed docstrings).
* Updated CHANGELOG.md
* Fix + updated docstring.
* Fixes (awaelchli's comments) + docstrings.
* Fix train/val loss.
* Fix.
2020-05-02 09:08:46 -04:00
d06d5e68b6
Fix typo in progress bar docs ( #1680 )
...
* fix typo
* Typo
* typo Borda
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2020-05-02 09:08:21 -04:00
152a2eb30c
wandb logger 'global_step' affects other logger ( #1492 )
...
* Removed unnecessary 'global_step' from wandb logger.
* Fixed wrong step implementation in wandb and missing metric skipping in logger base.
* simplified metric check in base logger
* Added Fix Description in CHANGELOG.md
* Updated wandb logger tests.
* udpate test, step=3
* Moved Fix Description in CHANGELOG.md to unreleased.
* Update CHANGELOG.md
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2020-05-02 08:50:47 -04:00
4dc77b5a1a
Change lightning module params to dict when loading ( #1639 )
...
* change module params to dict
* tiny change
* reverse
2020-05-02 08:44:35 -04:00
210cd657dd
fix LightningTemplateModel ( #1577 )
...
* fix LightningTemplateModel
* update CHANGELOG.md
* update LightningTemplate
* update changelog
* update changelog
* loss fix
2020-05-02 08:41:37 -04:00
cf0d5dc470
Docker release ( #1613 )
...
* Update docker_builds.yml
* Update docker_builds.yml
* nightly
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2020-05-02 08:40:31 -04:00
f380027951
refactor default model ( #1652 )
...
* refactor default model
* drop redundant seeds
* formatting
* path
* formatting
* rename
2020-05-02 08:38:22 -04:00
b4b73f92dd
Trigger automatic rebase on issue comment ( #1695 )
...
* Trigger automatic rebase on issue comment
Instead of `pull_request` event (created, closed, etc.).
Fixes https://github.com/cirrus-actions/rebase/issues/43
* Removed workaround
2020-05-02 06:47:31 -04:00
2950f66983
Fix Horovod distributed backend to set the root_gpu property ( #1669 )
...
* params
* drop acc
* Fix Horovod distributed backend to set the root_gpu
* Fixed test
* Fixed tests
* Fixed lint
* Set root_gpu during initialization
* chlog
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
2020-05-01 14:13:35 -04:00
34bc149359
move unnecessary dict trainer_options ( #1469 )
...
* move unnecessary dict trainer_options
* fix tests
* fix tests
* formatting
* missing
2020-05-01 10:43:58 -04:00
97c7b6b314
fixing LBFGS test ( #1678 )
...
* params
* drop acc
* acc
2020-05-01 10:41:15 -04:00
142bc0230e
Learning rate log callback ( #1498 )
...
* base implementation
* docs + implementation
* fix styling
* add lr string
* renaming
* CHANGELOG.md
* add tests
* Apply suggestions from code review
Co-Authored-By: Adrian Wälchli <aedu.waelchli@gmail.com>
* Apply suggestions from code review
* Update pytorch_lightning/callbacks/lr_logger.py
* Update pytorch_lightning/callbacks/lr_logger.py
* add test for naming
* base implementation
* docs + implementation
* fix styling
* add lr string
* renaming
* CHANGELOG.md
* add tests
* Apply suggestions from code review
Co-Authored-By: Adrian Wälchli <aedu.waelchli@gmail.com>
* Apply suggestions from code review
* Update pytorch_lightning/callbacks/lr_logger.py
* Update pytorch_lightning/callbacks/lr_logger.py
* add test for naming
* Update pytorch_lightning/callbacks/lr_logger.py
Co-Authored-By: Adrian Wälchli <aedu.waelchli@gmail.com>
* suggestions from code review
* fix styling
* rebase
* fix tests
Co-authored-by: Nicki Skafte <nugginea@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2020-04-30 08:06:41 -04:00
3eac6cfd4f
Don't convert namedtuple to tuple ( #1589 )
...
* Don't convert namedtuple to tuple
* Test namedtuples sent to device correctly
2020-04-30 08:04:50 -04:00
d40425d257
added warning to crash ( #1625 )
...
* added warning to crash
* formatting
Co-authored-by: J. Borovec <jirka.borovec@seznam.cz>
2020-04-30 08:04:18 -04:00
2ec8d61e94
Update new-project.rst ( #1655 )
...
fix a typo
2020-04-30 07:58:42 -04:00
f9c9e39ab8
Add log output for slurm ( #1657 )
...
* add log output for slurm
* change log levels
* formatting
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2020-04-30 07:58:03 -04:00
8d564b5e38
call on_load_checkpoint() when resuming from checkpoint ( #1666 )
2020-04-30 07:57:24 -04:00
53aa5636cf
Fixed broken link in PR template ( #1675 )
...
* Fixed broken link in PR template.
* Updated CHANGELOG.md
2020-04-30 07:54:50 -04:00
42d5cfc3b0
None check for filepath in ModelCheckpoint ( #1654 )
...
Check if the optional filepath is None before checking if it exists
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-04-29 16:36:28 +00:00
Rohit Gupta