Commit Graph

1856 Commits

Author SHA1 Message Date
Hadrien Mary 89d5772f55
Split callbacks (#849)
* add .vscode in .gitignore

* Split callbacks in individual files + add a  property to Callback for easy trainer instance access

* formatting

* Add a conda env file for quick and easy env setup to develop on PL

* Adress comments

* add fix to kth_best_model

* add some typing to callbacks

* fix typo

* add autopep8 config to pyproject.toml

* format again

* format

* fix toml

* fix toml again

* consistent max line length in all config files

* remove conda env file

* Update pytorch_lightning/callbacks/early_stopping.py

Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com>

* Update pytorch_lightning/callbacks/model_checkpoint.py

Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com>

* docstring

* Update pytorch_lightning/callbacks/model_checkpoint.py

Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com>

* Update pytorch_lightning/callbacks/model_checkpoint.py

Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com>

* fix logic error

* format

* simplify if/else

* format

* fix linting issue in changelog

* edit changelog about new callback mechanism

* fix remaining formating issue on CHANGELOG

* remove lambda function because it's compatible with pickle (used during ddp)

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2020-02-22 21:45:34 -05:00
Adrian Wälchli da2f11a9c4
Type Hints for Trainer (#912)
* typehints for trainer 

fix type links in docs


fix types in docs


type hints for trainer methods


fix fit docs


switch to comments


readability


added sphinx typehints extension


wip


remove typehints from docstring


more type annotations


fix spaces

* Update trainer.py

Co-authored-by: William Falcon <waf2107@columbia.edu>
2020-02-22 21:23:30 -05:00
Jeremy Jordan e05586c4b2
extract training teardown into method, catch KeyboardInterrupt (#856)
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2020-02-22 17:06:48 -05:00
William Falcon 446a1e23d7
Update training_loop.py (#913) 2020-02-22 05:15:36 -05:00
fdelrio89 4ac9925dad
Fix comet logger to log after train (#892)
* Fix comet logger to log after train

* Add clarifying comment to COmetLogger code

Explains the need to use CometExistingExperiment in the CometLogger class after
CometLogger.finalize.
2020-02-21 20:47:48 -05:00
William Falcon c00a8a10dd
finished dist (#911) 2020-02-21 20:39:12 -05:00
Matt Painter 6e7dc9c236
Fixes resuming checkpoints rerunning last epoch (#866)
* Properly restore current epoch and global step on resume

* Add test

* Move increment to saving rather than loading

* Fix other tests that refer to current epoch

* Formatting

* Add warning for mid-epoch resuming

* Formatting

* Fix warning check for accumulated batches

* Add variable to init

* Formatting

* Add check for 0 training steps

* Make check more readable
2020-02-21 20:27:19 -05:00
Jirka Borovec 2b5458e852
add Sphinx Check (#844)
* add sphinx bot

* source

* typo

* Make a change to the docs (#2)

* Make a change to the docs
* Introduce an error
* Install git before building docs
* Apply suggestions from code review

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

* Update docs/source/apex.rst

* Update docs/source/apex.rst

Co-authored-by: Ammar Askar <ammar_askar@hotmail.com>
2020-02-21 15:55:03 -05:00
Hadrien Mary 5c5a241e01
Add conda env setup (#898)
* add a conda env file for easy PL conda env setup

* Update environment.yml

Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com>

* Update environment.yml

Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com>

* Update environment.yml

Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com>

* Update environment.yml

Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com>

* Update environment.yml

Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com>

* Update environment.yml

Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com>

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2020-02-21 15:31:40 -05:00
Jirka Borovec f7e9700aae
update Loggers (#818)
* add warnings

* fix link
2020-02-21 13:39:37 -05:00
Aljoscha Steffens 9eb1907151
separate requirements for logger dependencies (#792)
* added file that contains information on the minimal versions needed for the supported loggers

* copied minimal version, combined files, deleted duplicates

* sorted functions in tests/test_loggers.py to be consistent

* expanded wandb logging test; added minimal versions for requirements-extra.txt; increased the amount of training data that is used for tests

* formatting

* added requirements-extra.txt to MANIFEST.in

* reverted wandb test; ensured minimal version for dependencies in requirements-extra.txt in ci-testing.yml
2020-02-21 13:30:27 -05:00
Tullie Murrell 897def2cac
Fix backwards compatibility for optional logging dependencies (#900) 2020-02-21 13:18:27 -05:00
Jirka Borovec b933b23d5c
add Stale action (#905) 2020-02-21 11:46:42 -05:00
Jirka Borovec 56dddf9708
update CHANGELOG (#897)
add info about TPU and segmentation
2020-02-19 09:08:43 -05:00
Jirka Borovec b5e9fd0b2c
typo JB
typo in my name lol
2020-02-19 14:56:46 +01:00
William Falcon b1040523b2
update contributors (#895)
* updated governance docs

* added maintainers to readme

* added governance docs

* added governance docs
2020-02-19 07:49:22 -05:00
Jeremy Jordan ea8878bc14
clean up tests/test_profiler.py (#867)
* cleanup docstrings, _get_total_cprofile_duration in module

* relax profiler overhead tolerance
2020-02-19 07:09:28 -05:00
Nicki Skafte c58aab0b00
remove deprecated args to learning rate step function (#890) 2020-02-19 06:37:35 -05:00
William Falcon c4b0693a4d
update governance docs (#894)
* updated governance docs

* added maintainers to readme

* added governance docs
2020-02-19 06:26:23 -05:00
Nicki Skafte ffd6e693de
new way of passing dataloaders (#759)
* new way of passing dataloaders

* fixed docs

* fixed codestyle to follow flake8

* allow val/test be list of dataloaders and smarter checking

* added test

* fix flake error

* fix linking to new test model

* split into multiple test

* fix naming and typo

* minor documentation changes

* remove random file

* Update trainer.py

* Update trainer.py

* Update trainer.py

* Update trainer.py

* Update trainer.py

* Update trainer.py

* better error/warning message

* final adjustments

* update CHANGELOG.md

Co-authored-by: William Falcon <waf2107@columbia.edu>
2020-02-19 06:00:08 -05:00
Luis Capelo b9b5a93f0f
Updates theme Sphinx configuration (#893)
I am updating the project's Sphinx documentation to fix (#819). The issue is related to a library the Sphinx extension `nbsphinx` (to load Jupyter Notebooks) loads into the docs context (RequireJS). That library conflicts with other theme libraries, causing the latter to be not loaded. This would result in several crashes, the most obvious of them the lack of anchors.

The fix above solves all errors -- and now anchors work.
2020-02-19 04:48:33 -05:00
Vadim Bereznyuk dfbb50cd6a
Fix docs for early stopping (#865)
* updated docs

* updated docs

* upd
2020-02-18 11:25:39 -05:00
Peter Izsak 054a35312d
Added max number of steps in Trainer (#728)
* Added max number of steps in Trainer

* Added docstring

* Fix flake8 errors

* Clarified docstrings

* Fixed flake8 error

* Added min_steps to Trainer

* Added steps and epochs test

* flake8

* minor fix

* fix steps test in test_trainer

* Split steps test into 2 tests

* Refactor steps test

* Update test_trainer.py

* Minor in test_trainer.py

* Update test_trainer.py

* Address PR comments

* Minor

Co-authored-by: William Falcon <waf2107@columbia.edu>
2020-02-18 11:23:22 -05:00
William Falcon 9571de8757
fix tpu docs (#886) 2020-02-17 17:52:42 -05:00
William Falcon 3562aa5aae fix tpu transfer bug 2 2020-02-17 17:47:16 -05:00
William Falcon 919a26fe41 fix tpu transfer bug 2020-02-17 17:46:46 -05:00
William Falcon d4a31f02e0
Enable TPU support (#868)
* added tpu docs

* added tpu flags

* add tpu docs + init training call

* amp

* amp

* amp

* amp

* optimizer step

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* fix test pkg create (#873)

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added test return and print

* added test return and print

* added test return and print

* added test return and print

* added test return and print

* Update pytorch_lightning/trainer/trainer.py

Co-Authored-By: Luis Capelo <luiscape@gmail.com>

* Fix segmentation example (#876)

* removed torchvision model and added custom model

* minor fix

* Fixed relative imports issue

* Fix/typo (#880)

* Update greetings.yml

* Update greetings.yml

* Changelog (#869)

* Create CHANGELOG.md

* Update CHANGELOG.md

* Update CHANGELOG.md

* Update PULL_REQUEST_TEMPLATE.md

* Update PULL_REQUEST_TEMPLATE.md

* Add PR links to Version 0.6.0 in CHANGELOG.md

* Add PR links for Unreleased in CHANGELOG.md

* Update PULL_REQUEST_TEMPLATE.md

* Fixing Function Signatures (#871)

* added tpu docs

* added tpu flags

* add tpu docs + init training call

* amp

* amp

* amp

* amp

* optimizer step

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added auto data transfer to TPU

* added test return and print

* added test return and print

* added test return and print

* added test return and print

* added test return and print

* added test return and print

* added test return and print

* added test return and print

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Luis Capelo <luiscape@gmail.com>
Co-authored-by: Akshay Kulkarni <akshayk.vnit@gmail.com>
Co-authored-by: Ethan Harris <ewah1g13@soton.ac.uk>
Co-authored-by: Shikhar Chauhan <xssChauhan@users.noreply.github.com>
2020-02-17 16:01:20 -05:00
Akshay Kulkarni e38b18e9eb
updated fast training docs with latest usage (#884) 2020-02-17 15:47:07 -05:00
Akshay Kulkarni 0ad3e8b8e9
changed to absolute imports and added docs (#881) 2020-02-17 11:05:59 -05:00
Shikhar Chauhan f44dfb3e7a
Fixing Function Signatures (#871) 2020-02-17 08:10:10 -05:00
Ethan Harris a33beb6ebf
Changelog (#869)
* Create CHANGELOG.md

* Update CHANGELOG.md

* Update CHANGELOG.md

* Update PULL_REQUEST_TEMPLATE.md

* Update PULL_REQUEST_TEMPLATE.md

* Add PR links to Version 0.6.0 in CHANGELOG.md

* Add PR links for Unreleased in CHANGELOG.md

* Update PULL_REQUEST_TEMPLATE.md
2020-02-17 08:09:11 -05:00
Ethan Harris 93e8ad1aa7
Fix/typo (#880)
* Update greetings.yml

* Update greetings.yml
2020-02-17 08:04:16 -05:00
Akshay Kulkarni 43ac63f2e7
Fix segmentation example (#876)
* removed torchvision model and added custom model

* minor fix

* Fixed relative imports issue
2020-02-17 08:03:41 -05:00
Jirka Borovec 6029fad989
fix test pkg create (#873) 2020-02-16 21:08:20 -05:00
Akshay Kulkarni 11db9d29ad
added initial semantic segmentation example (#751)
* added initial semantic segmentation example

* removed unnecessary lines.

* changed according to reviews

* minor changes

* Added some documentation for Dataset class

* Fixed some long lines

* added docstring for LightningModule
2020-02-16 10:52:44 -05:00
Jirka Borovec d3d7e7bf1f
drop duplicated guides (#864)
* drop duplicated guides

* prevent copy to git
2020-02-16 10:50:00 -05:00
Vadim Bereznyuk edd4a87fb0
Refactor callbacks (#776)
* Refactor callbacks

* flake8

* Update docstrings

* Simplified callback, protected trainer

* .set_trainer() check

* update docs

* missed super().__ini__()

* Updated tests

* Use uppercase

* refine checkpoint callback tests

* Added test_begin() and test_end()
2020-02-16 00:03:05 -05:00
Peter Izsak 27bba1a03a
Fix global_step when gradient accumulation > 1 (#832) 2020-02-15 23:48:19 -05:00
Jeremy Jordan 4ae31cd1d5
advanced profiler describe + cleaned up tests (#837)
* add py36 compatibility

* add test case to capture previous bug

* clean up tests

* clean up tests
2020-02-15 23:43:43 -05:00
Dmitry Lipin 06ca6428b6
Allow user to specify 'step' key while logging metrics (#808)
* allow to specify 'step' key

* add test

* docs to log_metrics

* fix test

* rename

* also rename
2020-02-15 23:35:23 -05:00
Jirka Borovec 62e9963cf7
add pep8speaks (#842) 2020-02-15 20:32:23 -05:00
Jirka Borovec 2d2f94ddb6
add Greeting action (#843)
* add Greeting action

* Update greetings.yml

Co-authored-by: William Falcon <waf2107@columbia.edu>
2020-02-15 20:32:07 -05:00
Jirka Borovec a4262996e5
add Auto rebase action (#845) 2020-02-15 20:31:03 -05:00
Jirka Borovec 149e466dbe
docs - anchor links (#848)
* docs - add links

* add desc.
2020-02-15 20:30:31 -05:00
Jirka Borovec c48541dedc
fix missing PyPI images & CI badges (#853) 2020-02-15 20:30:00 -05:00
Jirka Borovec 9f939447f2
add autopep8 to Contributions guide (#852)
* add autopep8 to Contrib.

* simplify cmd

* update GH templates

* add pytest-flake8

* update GH template
2020-02-15 20:24:38 -05:00
Jirka Borovec 539d129178 update badges & drop Travis/Appveyor (#826)
* drop Travis

* drop Appveyor

* update badges
2020-02-15 00:08:34 +01:00
Jirka Borovec 21d0f32047
Add GitHub Actions build (#823)
* init GH building

* try run

* circleci: install

* add cache

* add artifacts

* fix cache

* update
2020-02-12 11:28:47 -05:00
Jirka Borovec b35512ce82
update Docs req. (#824)
* upgrade sphinx

* badge

* Update README.md

Co-authored-by: William Falcon <waf2107@columbia.edu>
2020-02-12 10:25:14 -05:00
Yiyu Zhu b13b7d8033
pin virtualenv (#822)
https://github.com/tox-dev/tox/issues/1516
2020-02-12 09:21:04 -05:00