Commit Graph

1508 Commits

Author SHA1 Message Date
Akihiro Nitta 64b19fb16f
[App] Introduce auto scaler (#15769)
* Exlucde __pycache__ in setuptools

* Add load balancer example

* wip

* Update example

* rename

* remove prints

* _LoadBalancer -> LoadBalancer

* AutoScaler(work)

* change var name

* remove locust

* Update docs

* include autoscaler in api ref

* docs typo

* docs typo

* docs typo

* docs typo

* remove unused loadtest

* remove unused device_type

* clean up

* clean up

* clean up

* Add docstring

* type

* env vars to args

* expose an API for users to override to customise autoscaling logic

* update example

* comment

* udpate var name

* fix scale mechanism and clean up

* Update exampl

* ignore mypy

* Add test file

* .

* update impl and update tests

* Update changlog

* .

* revert docs

* update test

* update state to keep calling 'flow.run()'

Co-authored-by: Aniket Maurya <theaniketmaurya@gmail.com>

* Add aiohttp to base requirements

* Update docs

Co-authored-by: Luca Antiga <luca.antiga@gmail.com>

* Use deserializer utility

* fake trigger

* wip: protect /system/* with basic auth

* read password at runtime

* Change env var name

* import torch as optional

* Don't overcreate works

* simplify imports

* Update example

* aiohttp

* Add work_args work_kwargs

* More docs

* remove FIXME

* Apply Jirka's suggestions

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* clean example device

* add comment on init threshold value

* bad merge

* nit: logging format

* {in,out}put_schema -> {in,out}put_type

* lowercase

* docs on seconds

* process_time -> processing_time

* Dont modify work state from flow

* Update tests

* worker_url -> endpoint

* fix exampl

* Fix default scale logic

* Fix default scale logic

* Fix num_pending_works

* Update num_pending_works

* Fix bug creating too many works

* Remove up/downscale_threshold args

* Update example

* Add typing

* Fix example in docstring

* Fix default scale logic

* Update src/lightning_app/components/auto_scaler.py

Co-authored-by: Noha Alon <nohalon@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* rename method

* rename locvar

* Add todo

* docs ci

* docs ci

* asdfafsdasdf pls docs

* Apply suggestions from code review

Co-authored-by: Ethan Harris <ethanwharris@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* .

* doc

* Update src/lightning_app/components/auto_scaler.py

Co-authored-by: Noha Alon <nohalon@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Revert "[pre-commit.ci] auto fixes from pre-commit.com hooks"

This reverts commit 24983a0a5a.

* Revert "Update src/lightning_app/components/auto_scaler.py"

This reverts commit 56ea78b45f.

* Remove redefinition

* Remove load balancer run blocker

* raise RuntimeError

* remove has_sent

* lower the default timeout_batching from 10 to 1

* remove debug

* update the default timeout_batching

* .

* tighten condition

* fix endpoint

* typo in runtimeerror cond

* async lock update severs

* add a test

* {in,out}put_type typing

* Update examples/app_server_with_auto_scaler/app.py

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>

* Update .actions/setup_tools.py

Co-authored-by: Aniket Maurya <theaniketmaurya@gmail.com>
Co-authored-by: Luca Antiga <luca.antiga@gmail.com>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Noha Alon <nohalon@gmail.com>
Co-authored-by: Ethan Harris <ethanwharris@gmail.com>
Co-authored-by: Akihiro Nitta <aki@pop-os.localdomain>
Co-authored-by: thomas chaton <thomas@grid.ai>
2022-12-07 14:27:44 +01:00
Jerome Anand 6aaac8b910
Enable back inference mode support with hpu & update links (#15918)
* Enable back inference mode support with hpu
* Remove unused
* Update document link and address comment

Signed-off-by: Jerome <janand@habana.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2022-12-07 14:21:22 +01:00
Adrian Wälchli 2debd1c6b6
Simplify enabling CPU offload in FSDP (#15832)
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
2022-12-07 02:55:47 +00:00
Adrian Wälchli 05dbf48ad0
Activation checkpointing in FSDP without boilerplate (#15826)
* initial
* input type
* checkpointing
* fsdp in pl
* all_close

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2022-12-06 15:45:33 +00:00
Raphael Randschau a82be2ffad
[CLI] drop name column from cluster list (#15721)
* drop name column from cluster list

* change create cluster to accept id as well

* rename validator

* remove cluster name from logs

* fix merge with master

* more merge with master issues
2022-12-02 19:27:24 -08:00
Carlos Mocholí 1bc3a97e95
Remove checks for torch greater than 1.10 (#15846) 2022-12-01 21:41:22 +01:00
Luca Furst 33e1f9345d
[App] Improve cluster creation / deletion experience (#15458)
Cluster creation and deletion can take a long time. Instead of having these long running operations happen in the background, they should happen in the foreground. The advantage is that failures are brought to the users attention immediately, instead of the next time they decide to run `lightning list clusters`.

While the CLI waits for the cluster to run / delete, it will display cluster status changes to the user.

This PR also hides the `--enable-performance` and `--edit-before-creation` creation flags, as well as the `--force` deletion flag. They are either not frequently used (performance mode is expensive), or prone to misuse.


Co-authored-by: Neven Miculinic <neven.miculinic@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Raphael Randschau <nicolai86@users.noreply.github.com>
2022-11-28 16:38:43 +00:00
Mauricio Villegas 3fad651f99
Deprecate description and env parameters in LightningCLI.__init__ (#15651)
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: awaelchli <aedu.waelchli@gmail.com>
2022-11-27 10:52:01 +00:00
Laverne Henderson 70126df494
Added note about custom base images (#14125)
Co-authored-by: awaelchli <aedu.waelchli@gmail.com>
2022-11-26 21:58:38 +00:00
Rick Izzo 317591d2e2
Fix App Docs for lightning ssh-keys command (#15773)
fixed ssh-keys docs
2022-11-22 15:39:20 -05:00
Kaushik B 2b61c92ceb
Fix the `examples/app_dag` App (#14359)
* Fix app dag example
* Add test
* Update doc
* Update tests/tests_app_examples/test_app_dag.py

Co-authored-by: Sherin Thomas <sherin@grid.ai>
2022-11-22 09:39:44 +01:00
Justus Schock 006fde9747
FCCV Docs (#15598)
* add custom data iter docs

* add custom data iter docs

* Update docs/source-pytorch/data/custom_data_iterables.rst

* remove ToDevice

* nit

* Update docs/source-pytorch/data/custom_data_iterables.rst

Co-authored-by: Luca Antiga <luca.antiga@gmail.com>

* clarification for @lantiga

* typo

* Update docs/source-pytorch/data/custom_data_iterables.rst

* Update docs/source-pytorch/data/custom_data_iterables.rst

* Update docs/source-pytorch/data/custom_data_iterables.rst

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
Co-authored-by: Luca Antiga <luca.antiga@gmail.com>
2022-11-21 15:30:58 -05:00
Ethan Harris bc797fd376
[App] Fix multi-node pytorch example CI (#15753) 2022-11-21 16:02:30 +00:00
Yurij Mikhalevich 1a31d13521
feature(docs/app/lit_tabs): add works (#15731) 2022-11-21 13:46:01 +01:00
Ethan Harris 83067977af
[App] Update multi-node examples (#15700)
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
2022-11-21 10:41:59 +00:00
Yiftach Beer f40eb2cb1c
Fix broken link to CLI docs (#15723) 2022-11-19 14:17:11 +01:00
yiftachbeer d925077253
Fix typo in script name (#15724) 2022-11-19 12:26:35 +01:00
dymil 609b258fe8
Fix typo 'wether' (#15710) 2022-11-18 00:09:58 +01:00
yiftachbeer b40ca0ece5
remove unused random_split import from tutorial (#15716) 2022-11-18 00:09:46 +01:00
Yurij Mikhalevich befd3f6c22
fix(docs/app/lit_tabs): remove unused app_id, enable run instead (#15702) 2022-11-17 10:13:09 +01:00
William Falcon 41f1a36c5b
docs 5/n (#15669)
* examples

* fix few examples

* Update pl_multinode.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2022-11-17 08:10:14 +01:00
Nash 9670fa8b18
Docs: Fix import for scikit in XGBoost template (#15693) 2022-11-16 09:19:03 +01:00
Yurij Mikhalevich 4837df47bd
fix(docs/app): broken links in the intermediate/web-ui section (#15691) 2022-11-15 15:43:51 +01:00
Rick Izzo 23f88cd0a4
Fixed Import in Docs For Multinode Trainer Name Which does Not Exist (#15663) 2022-11-12 19:17:29 -05:00
William Falcon 4e8cf85b0c
Update run_ptl_script.py 2022-11-11 13:37:42 -05:00
Adrian Wälchli 8c9b688f2b
Update docs with new Lightning Lite usage 1/n (#15600) 2022-11-11 16:43:25 +00:00
Akihiro Nitta 164e5a7b3e
Remove the docs for passing strategy args to accelerator (#15636) 2022-11-11 05:46:10 -05:00
William Falcon d5c0effcfb
Docs 4/n (#15628)
* remove source-lit

* docs

* docs

* docs

* docs

* ic

* deploy

* deploy

* deploy

* deploy

* deploy

* deploy

* Apply suggestions from code review

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* make build run

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Rick Izzo <rick@grid.ai>
2022-11-10 14:48:48 -05:00
Carlos Mocholí 6ba00af1e0
Drop PyTorch 1.9 support (#15347)
* Drop 1.9

* Everything else

* READMEs

* Missed some

* IPU skips

* Remove exception type

* Add back
2022-11-10 08:59:13 -05:00
dependabot[bot] e97df1afae
Update myst-parser requirement from <0.17,>=0.15 to ==0.18.1 in /requirements (#14417)
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
2022-11-09 18:55:16 +00:00
Mauricio Villegas acccc4d423
Fix LightningCLI docs after overhaul of the documentation (#14976)
* - Fix diverse issues introduced when the documentation was restructured.
- Change the docs to be focused on configure hyperparameters instead of reduction of bolierplate.

* Update docs/source-pytorch/cli/lightning_cli.rst

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

* - Fix diverse issues introduced when the documentation was restructured.
- Change the docs to be focused on configure hyperparameters instead of reduction of bolierplate.

* Fixes based on review.

* Apply suggestions from code review

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

* Fix wrap width.

* Move save_hyperparameters and load_from_checkpoint to lightning_module page.

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
2022-11-09 10:36:47 -05:00
Rick Izzo 10b945bcc1
Run Command from App Comments (#15577)
* initial work

* this seems to work well

* added example test

* updated docs & logging

* fixed errors

* fix typing error

* now using the --setup flag to decide if we should execute app comment commands or not

* updated tests

* added tests

* added test to ci

* fixed failing tests

* code review

* updates
2022-11-09 09:45:38 -05:00
David Gilbertson b04a7aab9c
Docs: Update tutorial to match PyTorchProfiler changes (#15440)
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2022-11-09 01:28:05 +01:00
Kaszanas 35b66fd890
Fixed typo Havana -> Habana for HPUs (#15589)
Fixed typo Havana -> Habana

HPUs are accelerators built by Habana Labs.
2022-11-08 19:09:54 +01:00
Rohit Gupta 1a8f2e8516
Support DDP with LRFinder (#15304)
* Support DDP for LRFinder
* Apply suggestions from code review
* rank 0 is the decision maker

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2022-11-08 17:55:15 +00:00
Rohit Gupta 0886e6352e
Added a check to validate that wrapped FSDP models are used while initializing optimizers (#15301)
Co-authored-by: awaelchli <aedu.waelchli@gmail.com>
2022-11-08 02:10:35 +00:00
Sherin Thomas 94c300c2eb
[App] Re-wording build config warning in the docs (#15570)
* build config commands
* Apply suggestions from code review
2022-11-07 21:00:54 +01:00
Carlos Mocholí 04e1e925da Update governance and codeowners 2022-11-07 11:12:24 -05:00
Kushashwa Ravi Shrimali a557952fab
Move `krshrimali` to Alumni (#15568)
Move myself to Alumni
2022-11-07 09:13:00 -05:00
Raphael Randschau 5ff610cbea
Add basic SSH documentation for CLI (#15316)
* add basic ssh documentation

* rename workflow ssh debugging

* Update docs/source-app/workflows/ssh/index.rst

Co-authored-by: edenlightning <66261195+edenlightning@users.noreply.github.com>

* Update docs/source-app/workflows/ssh/index.rst

Co-authored-by: edenlightning <66261195+edenlightning@users.noreply.github.com>

* Update docs/source-app/workflows/ssh/index.rst

Co-authored-by: edenlightning <66261195+edenlightning@users.noreply.github.com>

* add more details about ssh command

* Update docs/source-app/workflows/ssh/index.rst

Co-authored-by: edenlightning <66261195+edenlightning@users.noreply.github.com>

* add more motivation to the audience section

* fix sphinx errors

* Update docs/source-app/workflows/index.rst

Co-authored-by: edenlightning <66261195+edenlightning@users.noreply.github.com>

* add details how to get app id

* add docs about component name

* add more context to the audience section

* Update docs/source-app/workflows/ssh/index.rst

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

* Update docs/source-app/workflows/ssh/index.rst

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

* address adrians comment about order

* add one-time notice

* fix headers

* wording

* update to match ssh params

* Update docs/source-app/workflows/ssh/index.rst

Co-authored-by: edenlightning <66261195+edenlightning@users.noreply.github.com>

* Update docs/source-app/workflows/ssh/index.rst

Co-authored-by: edenlightning <66261195+edenlightning@users.noreply.github.com>

* Update docs/source-app/workflows/ssh/index.rst

Co-authored-by: edenlightning <66261195+edenlightning@users.noreply.github.com>

* drop verification

* fix merge conflict error

* remove symlink

* fix doctree

Co-authored-by: edenlightning <66261195+edenlightning@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2022-11-06 07:07:50 -08:00
William Falcon 877c0bfe2c
Docs 3/n (#15554)
* remove source-lit

* remove source-lit

* remove source-lit

* remove source-lit

* remove source-lit

* remove source-lit

* remove source-lit

* remove source-lit

* remove source-lit

* remove source-lit

* remove source-lit

* remove source-lit

* remove source-lit

* remove source-lit

* remove source-lit

* remove source-lit

* remove source-lit

* remove source-lit

* remove source-lit

* remove source-lit

* remove source-lit

* remove source-lit

* remove source-lit

* remove source-lit

* remove source-lit

* remove source-lit

* remove source-lit

* remove source-lit

* remove source-lit

* remove source-lit

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2022-11-06 05:55:57 -05:00
Adrian Wälchli dcfaa065ab
Improve the checkpoint upgrade utility script (#15333) 2022-11-04 21:41:32 +00:00
Carlos Mocholí 0c63534b7e
remove source-lit docs 2 (#15527) 2022-11-04 18:01:04 +01:00
Carlos Mocholí 848fe13795
Update governance docs (#15479) 2022-11-04 21:13:03 +05:30
ananthsub 501d40f0dd
Move to alumni (#15522)
Update governance.rst
2022-11-04 11:04:25 -04:00
William Falcon 69bac9ffd9
Docs 2/n (#15521)
* merge master

* merge master

* merge master

* merge master

* install colors

* install colors

* install colors

* install colors

* install colors

* install colors

* install colors

* install colors

* docs

* docs

* docs

* docs

* docs

* docs

* docs

* docs

* Revert "docs"

This reverts commit c83d9854fb.

* Revert "docs"

This reverts commit a2bb66d2f0.

* docs

* docs

* remove source-lit

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* precommit

* files

* folder

Co-authored-by: Jirka <jirka.borovec@seznam.cz>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2022-11-04 08:31:27 -04:00
William Falcon 33b22b8e0d
remove source-lit docs (#15525)
* remove source-lit

* remove source-lit

* remove source-lit
2022-11-04 07:50:51 -04:00
Yurij Mikhalevich 1c26c417cc
fix(docs/app): setup muse card (#15513) 2022-11-03 22:39:57 +01:00
Jirka Borovec adb970a50b
CI: resolving Docs (#15508)
* placeholder

* pytorch

* fix CI

* fix package name

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* use os theme for pytorch docs

* switch source-app to lai_sphinx_theme

* pull_request

* doc error fix

* another build error fix

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* removed unused glossary.rst

* lit

* doc fixes

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix last warning

* try

* lit

* flake8

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: Yurij Mikhalevich <yurij@grid.ai>
Co-authored-by: rohitgr7 <rohitgr1998@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2022-11-03 15:33:54 -04:00
William Falcon 9328da439b
docs updates 1/n (#15473)
* docs

* docs updates

* docs updates

* docs updates

* docs updates

* d

* d

* d

* d

* d

* d

* ??

* d1

* d1

* d1

* d1

* d1

* d1

* d1

* d1

* d1

* d1

* d1

* d1

* d1

* d1

* d1

* d1

* d1

* d1

* d1

* d1

* d1

* d1

* d1

* d1

* d1

* d1

* d1

* d1

* d

* d

* d

* d

* d

* d

* d

* d

* d

* d

* new title

* new title

* new title

* new title

* new title

* new title

* new title

* new title

* new title

* new title

* new title

* new title

* new title

* new title

* new title

* new title

* new title

* new title

* new title

* new title

* only select from parent

* only select from parent

* only select from parent

* only select from parent

* only select from parent

* only select from parent

* only select from parent

* only select from parent

* only select from parent

* only select from parent

* only select from parent

* only select from parent

* only select from parent

* only select from parent

* only select from parent

* only select from parent

* only select from parent

* only select from parent

* only select from parent

* only select from parent

* only select from parent

* only select from parent

* only select from parent

* only select from parent

* only select from parent

* only select from parent

* only select from parent

* only select from parent

* only select from parent

* only select from parent

* only select from parent

* only select from parent

* only select from parent

* only select from parent

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* only select from parent

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* use OSS template

* only select from parent

* only select from parent

* only select from parent

* only select from parent

* only select from parent

* only select from parent

* only select from parent

* only select from parent

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update docs/README.md

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

Co-authored-by: William Falcon <williamfalcon@Williams-MacBook-Pro-2.local>
Co-authored-by: William Falcon <williamfalcon@Williams-MBP-2.lan>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2022-11-03 10:55:30 -04:00