rohitgr7
bcb6ee5d51
sync
2021-02-08 20:22:39 +01:00
Gyeongjae Choi
f20c1d1cdb
Fix typo in docstring ( #5835 )
...
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 0a50bb406f
)
2021-02-08 20:22:39 +01:00
Rohit Gupta
cb67e1d0b2
Separate epoch validation from step validation ( #5208 )
...
* Seperate epoch validaton from step validation
* update system
* test
* baked logic in callbacks
* unbake logic in callbacks
* fix the call for scheduler
* use property
* pep
* correct rebase
* gitignore
* ref
* add tests
* fix
* add early stopping test
* trigger
* chlog
* rev
* 1.3
* log
* Apply suggestions from code review
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
* Update pytorch_lightning/trainer/training_loop.py
* Update CHANGELOG.md
* Apply suggestions from code review
Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
(cherry picked from commit e429f97b67
)
2021-02-08 20:22:39 +01:00
Jirka Borovec
e7c6e9d43d
prepare v1.1.8 ( #5839 )
...
(cherry picked from commit 3b7afb932b
)
2021-02-08 20:22:39 +01:00
Adrian Wälchli
3ad55a2f09
Fix fine-tuning callback test ( #5643 )
...
* fix
* batch size
2021-02-08 12:19:34 -05:00
Roman Tezikov
2008d77f28
Fix broken code in docs ( #5859 )
...
Co-authored-by: Roman Tezikov <roman.tezikov@lamoda.ru>
2021-02-08 11:52:12 -05:00
Jirka Borovec
bd920b4102
Refactor simplify tests ( #5861 )
...
* add new
* restructure
* yapf
* move
* fix
2021-02-08 11:52:02 +01:00
Jirka Borovec
42812bb003
prune SimpleModel ( #5862 )
2021-02-08 09:52:54 +01:00
Jirka Borovec
26bc754cc1
prune unused methods ( #5860 )
2021-02-08 02:31:44 +01:00
Sean Naren
7f8fdda9a2
Add an additional check to ensure pipe checks supported fairscale version ( #5853 )
2021-02-06 17:25:36 -05:00
Jirka Borovec
a53c6d1319
yapf tests metrics ( #5845 )
2021-02-06 11:41:40 -05:00
Jirka Borovec
ec742310d4
yapf tests trainer ( #5844 )
2021-02-06 10:06:17 -05:00
Jirka Borovec
82943515dc
formatting tests1/n ( #5843 )
...
* utils
* tuner
* base
2021-02-06 08:22:10 -05:00
Jirka Borovec
91f63deabc
formatting tests: 5/5 ( #5848 )
...
* cb
* acc
* plug
* .
2021-02-06 07:28:26 -05:00
Jirka Borovec
4faaef7758
formatting tests: 4/n ( #5846 )
...
* models
* ckpt
* core
* log
2021-02-06 12:07:26 +01:00
Jirka Borovec
4d2b13f653
fix s3 download for PT 1.8 ( #5840 )
...
* fix s3 download for PT 1.8
2021-02-06 09:15:30 +01:00
Jirka Borovec
f83cca6107
formatting flake8 & isort ( #5824 )
...
* formatting
* isort
* make
* yapf
* isort
2021-02-05 18:33:12 -05:00
PythicCoder
74fb87552a
Update README .gif ( #5777 )
...
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
(cherry picked from commit e8c1755129
)
2021-02-05 21:44:01 +01:00
Jirka Borovec
cd46150427
Apply suggestions from code review
2021-02-05 21:43:59 +01:00
tchaton
77be6f6e24
resolve conflits
...
resolve doc
boring commit
docs
torchvision
tpu
Update dockers/tpu-tests/tpu_test_cases.jsonnet
Update dockers/tpu-tests/tpu_test_cases.jsonnet
2021-02-05 21:43:10 +01:00
ananthsub
06f65938ef
Fix toggle optimizer ( #5775 )
...
* Update lightning.py
* update changelog
* add a 3 optimizer test
* resolve flake8
* remove extra code
* typo
* resolve typo
* Apply suggestions from code review
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: tchaton <thomas@grid.ai>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-02-05 21:43:10 +01:00
Alexander Reshytko
6d7c01b1b4
[docs] Add docs for non-SLURM cluster setup ( #5754 )
...
* Add docs for non-slurm cluster setup
* Apply suggestions from code review
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
* Update docs/source/cluster.rst
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
* Update docs/source/cluster.rst
Co-authored-by: Alexander <alexander@reshytko.com>
Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
2021-02-05 21:43:10 +01:00
Jirka Borovec
834f4bbf8e
replace upload ( #5765 )
2021-02-05 21:43:10 +01:00
Jirka Borovec
a39b382fe1
hotfix for GHA tpu ( #5762 )
...
* -y
* t
* .
* t
2021-02-05 21:43:10 +01:00
Jirka Borovec
29b867b915
release 1.1.7 ( #5761 )
...
Co-authored-by: chaton <thomas@grid.ai>
2021-02-05 21:43:06 +01:00
Kaushik B
5dfd62c09e
Disable training with zero num_training_batches when insufficient limit_train_batches ( #5703 )
...
* disable training when zero num_train_batches with limit_train_batches
* refactor train skip condition
* fix formatting issues
* fix formatting issues
* ref: test error msg
* fix tests for data loader calls
* fix train dataloader condition
* update limit_train_batches upper range in test comment
* remove model state check test
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-02-05 21:40:42 +01:00
Rohit Gupta
2abf4693bc
Fix log_dir property ( #5537 )
...
* fix and update tests
* update with ModelCheckpoint
* chlog
* wip wandb fix
* all fixed
Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-02-05 21:40:42 +01:00
Jirka Borovec
a3161267d9
link blog ( #5740 )
2021-02-05 21:40:40 +01:00
Alex Parinov
ad9b188b78
Fix typo in LightningOptimizer ( #5736 )
2021-02-05 21:40:40 +01:00
Jirka Borovec
0038095427
add make for docs ( #5685 )
...
* add make docs
* docs
2021-02-05 21:40:40 +01:00
noamzilo
84a8d2d178
Bugfix/5487 auto lr ordering ( #5638 )
...
* started to write failing test. just getting into the framework...
* started to write failing test. just getting into the framework...
* added failing test for misconfiguration of lr finder
* made test startup quickly. making sure without the fix it also fails slowly
* improved test
* fixed for linter
* fixed for linter
* yet another fix for the linter
* yet another fix for the linter
* fixed comment by @carmocca
* fixed comment by @carmocca
* Fix test
* chlog
* Apply suggestions from code review
* Fix test
* Update pytorch_lightning/tuner/lr_finder.py
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
* Update pytorch_lightning/tuner/lr_finder.py
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
* Update tests/trainer/test_lr_finder.py
* Update pytorch_lightning/tuner/lr_finder.py
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
* Update pytorch_lightning/tuner/lr_finder.py
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
* Update pytorch_lightning/tuner/lr_finder.py
* Update tests/trainer/test_lr_finder.py
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Jirka Borovec <jirka.borovec@seznam.cz>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
2021-02-05 21:40:40 +01:00
siahuat0727
b2b27e4018
Fix docs typo ( #4930 )
...
* Fix docs
* typo
* import
* Apply suggestions from code review
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Jirka Borovec <jirka.borovec@seznam.cz>
Co-authored-by: edenlightning <66261195+edenlightning@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-02-05 21:40:40 +01:00
Sumanth Ratna
1c44f35cf3
Fix mypy 0.800 plus when prepending $PYTHONPATH to sys.path ( #5698 )
...
* Fix mypy when prepending $PYTHONPATH to sys.path
* attempt mypy fix
* Revert "attempt mypy fix"
This reverts commit fb7ed827d9
.
* fix mypy
Co-authored-by: Jirka Borovec <jirka.borovec@seznam.cz>
2021-02-05 21:40:40 +01:00
William Falcon
da02ac30fb
Update README.md
2021-02-05 21:40:40 +01:00
Jirka Borovec
e45fde51b6
add contrib questions ( #5691 )
...
* add contrib questions
* Apply suggestions from code review
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
* Apply suggestions from code review
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
Co-authored-by: Roger Shieh <sh.rog@protonmail.ch>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
Co-authored-by: Roger Shieh <sh.rog@protonmail.ch>
2021-02-05 21:40:40 +01:00
Alex Parinov
78918a9e8e
Rename opt_idx to optimizer_idx in docs for complex training loops ( #5712 )
2021-02-05 21:40:40 +01:00
Jirka Borovec
bde2e133bf
CI: skip horovod in testing docs ( #5702 )
2021-02-05 21:40:40 +01:00
James Guillochon
4bf6dd122a
Close SummaryWriter in TensorBoardLogger on finalize ( #5696 )
...
Not entirely sure this is the "right" solution to this problem, but currently when model fitting is finished the `TensorBoardLogger` attribute `_experiment` (a `SummaryWriter`) is left with an open file handle. This causes issues in particular on Windows systems (and probably others), and also makes the files un-syncable on cloud-synced devices like OneDrive. This PR adds a `close()` to `finalize` to make sure this handle is closed upon fit completion.
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2021-02-05 21:40:40 +01:00
Sumanth Ratna
8732475701
Remove unnecessary intermediate layers in base-conda Dockerfile ( #5697 )
...
* [docker][base-conda] Combine ENV+COPY instructions
* [docker][base-cuda] Combine ENV+COPY instructions
* [docker][base-xla] Combine ENV+COPY instructions
* [docker][base-cuda] Fix COPY instruction
* [docker][base-xla] Fix quote in ENV
* [docker][base-xla] Fix $PATH in ENV
* [docker][base-conda] Fix COPY instruction
* chlog
Co-authored-by: Jirka Borovec <jirka.borovec@seznam.cz>
2021-02-05 21:40:40 +01:00
Carlos Mocholí
a7d288cb31
Update CODEOWNERS ( #5561 )
...
* Update CODEOWNERS
* Update CODEOWNERS
* Apply suggestions from code review
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
* Apply suggestions from code review
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: edenlightning <66261195+edenlightning@users.noreply.github.com>
2021-02-05 21:40:40 +01:00
Jihoon Lee
d1200af358
fix model arguements ( #5653 )
2021-02-05 21:40:40 +01:00
Jirka Borovec
230f2b723c
update mergify - master only ( #5682 )
2021-02-05 21:40:40 +01:00
Adrian Wälchli
8e04646690
Filter "unsqueeze" warning when using DP ( #5622 )
...
* filtering unsqueeze warning directly in DP
* add changelog
* constrain to module
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2021-02-05 21:40:40 +01:00
tchaton
df5cbf5368
resolve conflict
...
resolve failing test
2021-02-05 21:40:39 +01:00
Adrian Wälchli
bb7d188318
Fix ModelCheckpoint race condition in file existence check ( #5155 )
...
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
2021-02-05 21:40:39 +01:00
Nicki Skafte
605c5a8c9a
Fix `num_classes` arg in F1 metric ( #5663 )
...
* fix f1 metric
* Apply suggestions from code review
* chlog
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Jirka Borovec <jirka.borovec@seznam.cz>
2021-02-05 21:40:30 +01:00
Adrian Wälchli
1feff5d774
move progress bar test to correct test folder ( #5667 )
2021-02-05 21:40:29 +01:00
Jirka Borovec
e1e47ac628
new section + legacy 1.1.6 ( #5666 )
2021-02-05 21:40:29 +01:00
chaton
d8f2d8e15a
[Feat-BugFix] Resolve custom DataLoader ( #5745 )
...
* resolve custom dataloader
* update changelog
* fix tests
* update on comments
* resolve comments
* add support for custom batch_sampler
* Update tests/trainer/test_data_loading.py
* resolve test
* resolve flake8
* resolve yapf
Co-authored-by: Ubuntu <ubuntu@ip-172-31-88-60.ec2.internal>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
2021-02-05 09:03:18 +00:00
Jirka Borovec
d2c2e5004d
fix tests
2021-02-04 20:55:58 +01:00