Jirka Borovec
9e35f979ea
Prune metrics: AUC & AUROC ( #6572 )
...
* class: AUC AUROC
* func: auc auroc
* format
* tests
2021-03-18 10:38:56 +01:00
Jirka Borovec
297e438153
fix deprecation wrapper & tests ( #6553 )
...
* fix deprecation wrapper & tests
* flake8
2021-03-17 10:41:08 +00:00
Jirka Borovec
555a6fea21
prune warning & deprecation wrapper ( #6540 )
...
* docs
* wrapper
* test
* count
* flake8
2021-03-16 14:55:31 +00:00
Eric Cousineau
e886d55ac1
argparse: Add use_argument_group=True ( #6088 )
...
* argparse: Add inplace option
Replicate in GAN model
* datamodule: Deduplicate logic w/ argparser utilities
* Update pl_examples/domain_templates/generative_adversarial_net.py
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
* Apply suggestions from code review
Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
* Keep docstrings
* Correct name
* Whitespace
* Consistency
* fix weird type stuff
* try alt - use_argument_group
* fix syntax + lint
* fix ci errs
* fix ci
* change examples... still failing w/ "unrecognized arguments: --batch_size"
* address review
* mnist_datamodule: add some docstrings
* argparse: check cls or cls.__init__ for param
didn't capture issue, but meh
* fix lint
* fix no-doc edge case
* address review
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
2021-03-11 10:50:49 -05:00
thomas chaton
7d4e74c745
[bug] All_gather support tensor on cpu ( #6416 )
...
* add test
* update changelog
* update
* rename function
2021-03-10 14:19:07 +00:00
Rohit Gupta
facfda85f1
Remove no return warning from val/test step ( #6139 )
...
* remove warning
* auto_opt
* chlog
* auto_opt
* no_warning_call
* rm old code
* add warning for predict
* Apply suggestions from code review
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2021-03-06 17:15:21 +00:00
Jirka Borovec
2a3ab67946
fix importing torchtext batch ( #6365 )
...
* copy torchtext batch
* update
* rev
* rev
2021-03-05 21:39:52 +01:00
Jirka Borovec
e84854264f
CI: fix examples - patch download MNIST ( #6357 )
...
* patch download
* CI
* isort
* extra
2021-03-05 16:50:21 +00:00
Akihiro Nitta
48a10f16ef
Add `tests/utilities/test_parsing.py` ( #4460 )
...
* Create branch tests/4400_parsing
* Rename test file for parsing.py
* Fix lightning_hasattr
* Fix lightning_hasattr
* Fix lightning_setattr
* Add empty lines and remove rubbish spaces
* Raise AttributeError not ValueError
* Use getattr in hasattr
* Remove rubbish spaces
* Fix getattr
* Fix by flake8
* Add tests for str_to_bool_or_str
* Fix by flake8
* Add tests for str_to_bool
* Add tests for is_picklable
* Add tests for clean_namespace
* Fix typo
* Fix lightning_getattr
* Add tests for AttributeDict
* Add tests for flatten_dict
* Fix by flake8
* Apply suggestions from code review
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
* Apply isort
* Revert "Apply suggestions from code review"
* Define unpicklable_function outside
* Add comment to test_clean_namespace
* Add tests for parse_class_init_keys
* Add tests for get_init_args and collect_init_args
* Share objects across the tests
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Ethan Harris <ewah1g13@soton.ac.uk>
2021-03-04 19:58:10 +01:00
Jirka Borovec
d1a03153f3
Refactor: runif for spec 6/6 ( #6307 )
...
* special
* rpc
2021-03-02 18:57:13 +00:00
Jirka Borovec
ac583781db
Refactor: Runif for TPU and Horovod 5/n ( #6301 )
...
* TPU
* horovod
* extra
* fix
* Apply suggestions from code review
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
* doc
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
2021-03-02 16:21:20 +00:00
Jirka Borovec
0f9134e043
Refactor: skipif for Windows 2/n ( #6268 )
...
* win
* isort
* flake8
2021-03-02 09:36:01 +00:00
Jirka Borovec
eb815000f6
Refactor: skipif for multi - gpus 1/n ( #6266 )
...
* ngpus
* gpu
* isort
* pt
* flake8
2021-03-02 09:03:32 +01:00
Jirka Borovec
1d9c553b86
prune deprecated Trainer arg `enable_pl_optimizer` ( #6163 )
...
* prune enable_pl_optimizer
* prune automatic_optimization
2021-02-24 10:01:24 +00:00
Jirka Borovec
1c851b89e1
fixing miss-leading tested acc values ( #5876 )
...
* fixing tested values
* .
* tests
* yapf
* softmax
* hvd
* rename
* lr
* duplicate
* drop
* classif
* rm EvalModel
* Revert "rm EvalModel"
This reverts commit 6c3fb39ebe
.
* update tests
* fix
* azure
* azure
* self
* cpu
* Apply suggestions from code review
Co-authored-by: rohitgr7 <rohitgr1998@gmail.com>
2021-02-23 22:08:46 +00:00
Sean Naren
3b0e4e0b2b
Enable ZeRO tests for CI, fix to/half function calls ( #6070 )
...
* Enable ZeRO optimization, and make sure that the lightning module hook is called when we move to half precision
* Added test, update to function
2021-02-21 00:24:44 +00:00
Akihiro Nitta
8f82823a08
Raise AttributeError in lightning_getattr and lightning_setattr when attribute not found ( #6024 )
...
* Empty commit
* Raise AttributeError instead of ValueError
* Make functions private
* Update tests
* Add match string
* Apply suggestions from code review
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
* lightning to Lightning
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2021-02-18 20:01:28 +00:00
Dusan Drevicky
c9fde04947
Make move_metrics_to_cpu work recursively ( #6007 )
...
* Propagate to_cpu flag down the recursion chain
* Refactor
* Add test
* Update CHANGELOG
* Update tests/utilities/test_memory.py
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
2021-02-16 21:52:42 +00:00
Rohit Gupta
6d1e055a32
Prune EvalModelTemplate from callbacks and utilities ( #6018 )
...
* boring
* boring
2021-02-16 19:59:57 +00:00
Jirka Borovec
e6a2ccc850
fix deprecated call ( #6005 )
2021-02-16 12:11:13 +01:00
Jirka Borovec
bd920b4102
Refactor simplify tests ( #5861 )
...
* add new
* restructure
* yapf
* move
* fix
2021-02-08 11:52:02 +01:00
Jirka Borovec
82943515dc
formatting tests1/n ( #5843 )
...
* utils
* tuner
* base
2021-02-06 08:22:10 -05:00
Jirka Borovec
f83cca6107
formatting flake8 & isort ( #5824 )
...
* formatting
* isort
* make
* yapf
* isort
2021-02-05 18:33:12 -05:00
Ryan Nett
da5ba50727
Unify attribute finding logic, fix not using dataloader when hparams present ( #4559 )
...
* Rebase onto master
* indent fix
* Remove duplicated logic
* Use single return
* Remove extra else
* add `__contains__` to TestHparamsNamespace to fix tests
* Fix lightning_setattr to set all valid attributes
* update doc
* better names
* fix holder order preference
* tests for new behavior
* Comment about using the last holder
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Sean Naren <sean.narenthiran@gmail.com>
(cherry picked from commit eee3b1a284
)
2021-02-04 20:55:41 +01:00
Adrian Wälchli
b3b48c188c
fix error when logging to progress bar with reserved name ( #5620 )
...
* warn about duplicate metrics
* update changelog
* suggestions from rohit
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
* multiple values in message
* Apply suggestions from code review
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-02-04 20:55:41 +01:00
Lezwon Castelino
b95471d4a4
Increase TPU check timeout ( #5598 )
...
* change timeout to 100
* add to CHANGELOG.md
* update test
* updates
* reduce TPU_TIMEOUT_CONSTANT during test
* Update tests/utilities/test_xla_device_utils.py
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
* patch TPU_TIMEOUT_CONSTANT
* Apply suggestions from code review
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-02-04 20:55:41 +01:00
Jirka Borovec
53b0ae49b9
fix imports / isort / flake8
2021-01-26 14:57:34 +01:00
Sean Naren
0c370ade51
[BUG] Check environ before selecting a seed to prevent warning message ( #4743 )
...
* Check environment var independently to selecting a seed to prevent unnecessary warning message
* Add if statement to check if PL_GLOBAL_SEED has been set
* Added seed test to ensure that the seed stays the same, in case
* if
* Delete global seed after test has finished
* Fix code, add tests
* Ensure seed does not exist before tests start
* Refactor test based on review, add log call
* Ensure we clear the os environ in patched dict
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: chaton <thomas@grid.ai>
(cherry picked from commit 635df27880
)
2021-01-26 14:28:47 +01:00
Arnaud Gelas
b9530d291e
Fix pre-commit isort failure on tests/utilities/*.py ( #5420 )
...
* Remove tests.utilities from skipped module in pyproject.toml
* Fix pre-commit isort failure on tests/utilities/*.py
2021-01-11 14:00:39 -05:00
chaton
be255de306
Bugfix/all gather ( #5221 )
...
* resolve bug
* add tests
* add tests
* resolve flake8
* update
* update
* remove globals
* typo
* Update pytorch_lightning/utilities/distributed.py
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
* update
* update
* add suport int, float
* update
* resolve pep8
* Update pytorch_lightning/core/lightning.py
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
* Update tests/utilities/test_all_gather_grad.py
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
* update doc
* add bool and np.ndarray
* resolve conflicts
* resolve conflicts
* resolve pep8
* add changelog
* Update pytorch_lightning/core/lightning.py
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Ubuntu <ubuntu@ip-172-31-62-109.ec2.internal>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2021-01-09 07:37:44 -05:00
Jirka Borovec
a884866ff0
Unify names in Utils ( #5199 )
...
* warnings
* argparse
* mutils
* xla device
* deprecated
* tests
* simple
* flake8
* fix
* flake8
* 1.4
2020-12-22 00:23:33 +01:00
Jirka Borovec
0f36525e8f
fix/enable - check F401 ( #5201 )
...
* refactor - check F401
* missed
* fix
2020-12-21 10:15:04 +01:00
Jirka Borovec
35fd6e93c7
refactor - check E501 ( #5200 )
2020-12-21 14:23:09 +05:30
Jirka Borovec
059eaecbb4
set xxx_AVAILABLE as protected ( #5082 )
...
* sett xxx_AVAILABLE as protected
* docs
2020-12-14 20:19:05 +05:30
Jirka Borovec
53d7c9555c
drop usage of deprecated distributed_backend ( #5009 )
...
Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Roger Shieh <sh.rog@protonmail.ch>
2020-12-09 09:18:23 +01:00
Ananya Harsh Jha
127454ade2
All gatherwith grads ( #5012 )
...
* all_gather
* ddp
* horovod
* grad tests
* fixed ddp
* ddp fixed, removed tpu, horovod for now
* changelog
* windows fix
* windows fix
* removed batch from ctx
* all_gather
* ddp
* horovod
* grad tests
* fixed ddp
* ddp fixed, removed tpu, horovod for now
* changelog
* windows fix
* windows fix
* removed batch from ctx
* removed code duplication
* merge
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2020-12-08 23:20:01 +00:00
Gianluca Scarpellini
16fa4ed1e5
Fixed PYTHONPATH for ddp test model ( #4528 )
...
* Fixed PYTHONPATH for ddp test model
* Removed debug calls
* Apply suggestions from code review
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Sean Naren <sean.narenthiran@gmail.com>
2020-12-05 20:09:47 +00:00
Lezwon Castelino
12cb9942a1
Tpu save ( #4309 )
...
* convert xla tensor to cpu before save
* move_to_cpu
* updated CHANGELOG.md
* added on_save to accelerators
* if accelerator is not None
* refactors
* change filename to run test
* run test_tpu_backend
* added xla_device_utils to tests
* added xla_device_utils to test
* removed tests
* Revert "added xla_device_utils to test"
This reverts commit 0c9316bb
* fixed pep
* increase timeout and print traceback
* lazy check tpu exists
* increased timeout
removed barrier for tpu during test
reduced epochs
* fixed torch_xla imports
* fix tests
* define xla utils
* fix test
* aval
* chlog
* docs
* aval
* Apply suggestions from code review
Co-authored-by: Jirka Borovec <jirka.borovec@seznam.cz>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Sean Naren <sean.narenthiran@gmail.com>
2020-12-02 13:05:11 +00:00
Jirka Borovec
442d57f1e9
simplify imports xla / TPU ( #4872 )
...
* xla
* tpu
* fix
* fix
* flake8
2020-11-27 00:37:48 +01:00
Jirka Borovec
11e73ceaa6
fix import and typo in AMP ( #4871 )
...
* fix import and typo
* docs
* apex
* fix
* typo
2020-11-26 23:45:52 +01:00
Justus Schock
742ddd81b3
make device property always return a device with index ( #4851 )
...
* make device property always return a device with index
* pep8
* Update test_dtype_device_mixin.py
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2020-11-27 00:49:51 +05:30
chaton
4803f681b0
[FEAT] DDP: Create DDPLauncher ( #4515 )
...
* test
* poc
* add simpler test for ddp
* typo
* resolve pep8
* try coverage testing
* trying to add coverage inside ddp
* resolve flake8
* update
* forgot coverage
* move .coveragerc
* update rcfile path
* update
* test
* update
* adding description
* add DDPLauncher decorator
* add undecorated
* push update
* update ddp testing
* Update tests/backends/launcher.py
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
* Update tests/backends/launcher.py
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
* update on comments
* update on comments
* resolve comments
* resolve isort
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2020-11-20 10:17:46 +00:00
maxjeblick
343d19fa86
Find parameters which are specified in the LightningDataModule, only ( #4347 )
...
* search for attribute in datamodule if not found elsewhere
* add test for datamodule
* add lightning_getattr test for datamodule
* Apply suggestions from code review
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
* Update CHANGELOG.md
* Update CHANGELOG.md
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
2020-11-10 14:01:20 +01:00
Lezwon Castelino
839813eb7b
timeout for tpu check ( #4340 )
...
* timeout for tpu check
* added tests
* updated CHANGELOG.md
* fixed windows tests
* Update pytorch_lightning/utilities/xla_device_utils.py
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
* requested changes
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2020-11-01 01:04:25 +01:00
Chenglu
8e3faa2da1
get help from docstring ( #4344 )
...
* Add geting help message from docstring
* Fix pep8 issue
* Apply suggestions from code review
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
* Apply suggestions from code review
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Sean Naren <sean.narenthiran@gmail.com>
2020-10-26 23:38:58 +05:30
William Falcon
09c2020a93
notices ( #4118 )
2020-10-13 07:18:07 -04:00
Lezwon Castelino
69833dad5b
Added check to verify xla device is TPU ( #3274 )
...
* tpu device check
* replaced with xmp spawn
* Revert "replaced with xmp spawn"
This reverts commit 6835380f
* replaced all instances of XLA_AVAILABLE
* moved inner_f to global scope
* made refactors
* added changelog
* added TPU_AVAILABLE variable
* fix codefactor issues
* removed form trainer and early stopping
* add TORCHXLA_AVAILABLE check
* added tests
* refactoring
* Update pytorch_lightning/utilities/xla_device_utils.py
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
* updated function names
* fixed bug
* updated CHANGELOG.md
* added todo
* added type hints
* isort and black
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: William Falcon <waf2107@columbia.edu>
2020-10-06 19:54:37 +02:00
William Falcon
440f837f6d
ref: part a of #3733 ( #3766 )
...
* ref: part a of #3733
* ref: part a of #3733
2020-10-01 08:15:23 -04:00
William Falcon
c41ea86b35
ref: move backends back to individual files (1/5) (ddp_cpu) ( #3712 )
...
* ref: make each backend independent for easier debugging and independent debugging
* ref: make each backend independent for easier debugging and independent debugging
* ref: make each backend independent for easier debugging and independent debugging
* ref: make each backend independent for easier debugging and independent debugging
* ref: make each backend independent for easier debugging and independent debugging
* ref: make each backend independent for easier debugging and independent debugging
* ref: test val epoch end
* ref: test val epoch end
2020-09-29 01:59:18 -04:00
Jeremy Jordan
a5d1176cf6
callback method for on_save_checkpoint ( #2501 )
...
* initial draft
* fix test
* Update pytorch_lightning/trainer/callback_hook.py
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
* fix tests
* remove old code
* untested upgrade script
* document limitations
* clean up and add tests
* Update pytorch_lightning/trainer/training_io.py
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
* reflect PR comments
* fix formatting
* Update docs/source/callbacks.rst
* clarify docs
* revert change for loading checkpoints
* small edits
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2020-08-28 16:50:52 +02:00