Wansoo Kim
21fd56e280
FIX-5311: Cast to string `_flatten_dict` ( #5354 )
...
* fix
* params
* add test
* add another types
* chlog
Co-authored-by: Jirka Borovec <jirka.borovec@seznam.cz>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
(cherry picked from commit 6536ea42fa
)
2021-01-06 15:16:46 +01:00
Jirka Borovec
9610ea817b
refactor imports of logger dependencies ( #4860 )
...
* refactor imports of logger dependencies
* fix
* fix
* fix
* name
* fix
* mocks
* fix tests
* fix mlflow
* fix test tube
* fix wandb import check
* whitespace
* name
* name
* hack
* hack
* rev
* fix
* update mlflow import check
* try without installing conda dep
* .
* .
* .
* .
* .
* .
* .
* .
* .
Co-authored-by: Adrian Wälchli <adrian.waelchli@inf.unibe.ch>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
(cherry picked from commit ec0fb7a3ec
)
2021-01-06 15:16:06 +01:00
Luis Perez
93abeba5f3
Existence check for hparams now uses underlying filesystem ( #5250 )
...
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
(cherry picked from commit 410d67fbe8
)
2021-01-06 15:14:24 +01:00
Jirka Borovec
74d0652164
flake8 ++
2021-01-05 09:58:37 +01:00
Boris Dayma
dcd29aef06
feat(wandb): offset logging step when resuming ( #5050 )
...
* feat(wandb): offset logging step when resuming
* feat(wandb): output warnings
* fix(wandb): allow step to be None
* test(wandb): update tests
* feat(wandb): display warning only once
* style: fix PEP issues
* tests(wandb): fix tests
* tests(wandb): improve test
* style: fix whitespace
* feat: improve warning
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
* feat(wandb): use variable from class instance
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
* tests(wandb): check warnings
* feat(wandb): use WarningCache
* tests(wandb): fix tests
* style: fix formatting
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2021-01-05 09:58:37 +01:00
Haswanth Aekula
ac996fb008
Fixed docs for WandbLogger ( #5128 )
...
Fixed a small bug with the `WandbLogger` docs.
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Roger Shieh <sh.rog@protonmail.ch>
2021-01-05 09:58:37 +01:00
Jirka Borovec
957583544a
mark todo exceptions ( #5320 )
...
* mark todo exceptions
* .
* .
* .
* .
* .
* .
* .
* .
* try
* .
2021-01-04 09:07:56 +01:00
Jirka Borovec
0f36525e8f
fix/enable - check F401 ( #5201 )
...
* refactor - check F401
* missed
* fix
2020-12-21 10:15:04 +01:00
Jirka Borovec
059eaecbb4
set xxx_AVAILABLE as protected ( #5082 )
...
* sett xxx_AVAILABLE as protected
* docs
2020-12-14 20:19:05 +05:30
Cookie_thief
aeaa6b2d4f
Add experiment_key argument to online mode example ( #4997 )
...
Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
2020-12-08 16:08:04 +05:30
Marc Ferradou
849737e7ca
[Bug Fix] Allow logger to support indexing ( #4595 )
...
* [Bug Fix] Allow logger to support indexing
This should fix #4540
* Adding test for indexes for DummyLogger
* Apply suggestions from code review
Co-authored-by: chaton <thomas@grid.ai>
* pep8
* added test for dummyexperiment
Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
Co-authored-by: Sean Naren <sean.narenthiran@gmail.com>
2020-12-05 21:00:31 +00:00
Rohit Gupta
ef762a0d2a
update logging docs and decorators ( #4431 )
...
* update logging docs
* experiment
* add decorators to base and csv logger methods
* fix
* doc fix
* update docs
* update docs
* Update pytorch_lightning/loggers/base.py
Co-authored-by: chaton <thomas@grid.ai>
2020-12-01 11:35:00 +05:30
Jirka Borovec
217650320e
simplify imports Omegaconf ( #4873 )
...
* hydra
* omegaconf
2020-11-27 01:00:56 +01:00
Peter Gagarinov
70361ebb6d
Fixed a crash bug in MLFlow logger ( #4716 )
...
* warnings.warn doesn't accept tuples, which causes "TypeError: expected string or bytes-like object" when the execution flow gets to this warning. Fixed that.
* Try adding a mock test
* Try adding a mock test
Co-authored-by: rohitgr7 <rohitgr1998@gmail.com>
Co-authored-by: chaton <thomas@grid.ai>
2020-11-24 00:50:34 -05:00
Boris Dayma
c586e5db77
feat(wandb): let wandb cli handle runs ( #4648 )
...
* feat(wandb): reinit handled by CLI
* fix: typo
* docs(wandb): improve formatting
* test(wandb): set wandb.run to None
* test(wandb): fix tests
* style: fix formatting
* docs(wandb): fix documentation
* Update code markup
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
* docs(wandb): update CHANGELOG
* test(wandb): init called only when needed
* Update CHANGELOG.md
* try fix the test
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: edenlightning <66261195+edenlightning@users.noreply.github.com>
Co-authored-by: Sean Naren <sean.narenthiran@gmail.com>
Co-authored-by: rohitgr7 <rohitgr1998@gmail.com>
2020-11-24 01:31:28 +05:30
Rohit Gupta
2d9d7e4daa
Add prefix argument in loggers ( #4557 )
...
* Add prefix parameter in loggers
* chlog
* pep
* patch test
* remove args, access via self
* try fix the test
* try fix the test
* try fix the test
* prefix test
* fix assert has calls
fix assert call
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2020-11-22 06:38:58 +01:00
Roger Shieh
cc8359be26
Proper casting for np scalars in hparams logging ( #4647 )
...
* first implementation
* add test and changelog
* Update tests/loggers/test_base.py
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
* pep8
* rounding
* increase casting specificity to bool + number
* bugfix
* changelog formatting
* single loop
* Update CHANGELOG.md
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: chaton <thomas@grid.ai>
2020-11-19 15:52:48 +08:00
Maxim Ostroukhov
c208ac68c8
Added experiment_id to NeptuneLogger ( #3462 )
...
* 1) Added experiment_id to NeptuneLogger initialization input arguments.
2) Now function _create_or_get_experiment() overrides "experiment_name", "params", "properties", "tags".
* Added test case for existing experiment.
* Revert "Added test case for existing experiment."
This reverts commit 9f3ba2e37b
.
* Added test case for existing experiment.
* Fix merging issue.
* Moved experiment_id assignment directly to the part with experiment initialization.
* Update pytorch_lightning/loggers/neptune.py
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2020-11-16 23:50:23 +05:30
Jeff Yang
baa8558cc0
logger docs and api docs ( #3950 )
...
* logger and api docs
* remove gpu_usage_logger, lr_logger
* update docstring
* fix wandb example
* remove step result
* charts
* add some charts info
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
2020-11-13 20:35:54 +05:30
Diedre Carmo
470e2945fc
fix logged keys in mlflow logger ( #4412 )
...
* [#4411 ] fix gpu_log_memory with mlflow logger
* sanitize parenthesis instead of removing for all loggers
* apply regex for mlflow key sanitization
* replace ',' with '.' typo
* add single warning and test
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: chaton <thomas@grid.ai>
2020-11-10 17:20:25 +05:30
chaton
c2e72c3c86
[BUG-FIX] WandbLogger _sanitize_callable ( #4422 )
...
* fix
* resolve CodeFormatter
* Update pytorch_lightning/loggers/base.py
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2020-11-02 10:04:50 +01:00
Carlos Mocholí
ce261e4afe
Fix CSV logger warning ( #4419 )
...
Co-authored-by: Jeff Yang <ydcjeff@outlook.com>
2020-10-29 14:30:07 +05:30
Boris Dayma
ff41d80706
feat(wandb): log in sync with Trainer step ( #4405 )
...
* feat(wandb): log in sync with Trainer step
* docs: update CHANGELOG
* style(test_wandb): fix formatting
* parentheses
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
2020-10-29 01:07:06 +05:30
Alexander
4106e2f112
Fix COMET_EXPERIMENT_KEY environment variable usage in comet logger ( #4230 )
...
* Fix COMET_EXPERIMENT_KEY environment variable usage
* Remove unused arg
* Update comet.py
* Add test by Lothiraldan
* remove blank
Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
Co-authored-by: Sean Naren <sean.narenthiran@gmail.com>
2020-10-27 14:30:56 +00:00
chaton
f07ee33db6
BUG - Wandb: Sanitize callable. ( #4320 )
...
* add _sanitize_callable_params
* add call on _val if callable
* clean code formatter
* resolve pep8
* default return function name
* resolve pep8
* Apply suggestions from code review
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
* Update CHANGELOG.md
Co-authored-by: Sean Naren <sean.narenthiran@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2020-10-26 11:57:03 +00:00
Adrian Wälchli
376268f01e
Implement finalize for WandbLogger ( #4341 )
...
* wandb finish
* experiment
* upload at end of run
* changelog
* comment
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Sean Naren <sean.narenthiran@gmail.com>
2020-10-26 11:22:09 +00:00
William Falcon
09c2020a93
notices ( #4118 )
2020-10-13 07:18:07 -04:00
William Falcon
9dfb4d2e41
docs ( #4081 )
2020-10-11 13:16:36 -04:00
Adrian Wälchli
d65b037a40
Mocking Loggers Part 5/5 (final) ( #3926 )
...
* base
* add xfail
* new test
* import
* missing import
* xfail if not installed
include mkpatch
fix test
* mock comet
comet mocks
fix test
remove dep
undo merge duplication
* line
* line
* convert doctest
* doctest
* docs
* prune Results usage in notebooks (#3911 )
* notebooks
* notebooks
* revamp entire metrics (#3868 )
* removed metric
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* added new metrics
Co-authored-by: Teddy Koker teddy.koker@gmail.com
* pep8
Co-authored-by: Teddy Koker teddy.koker@gmail.com
* pep8
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* docs
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* docs
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* win ddp tests skip
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* win ddp tests skip
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* win ddp tests skip
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* win ddp tests skip
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* reset in compute, cache compute
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* reduce_ops handling
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* sync -> sync_dist, type annotations
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* wip docs
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* mean squared error
* docstring
* added mean ___ error metrics
* added mean ___ error metrics
* seperated files
* accuracy doctest
* gpu fix
* remove unnecessary mixin
* metric and accuracy docstring
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* metric docs
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* pep8, changelog
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* refactor dist utils, pep8
* refactor dist utils, pep8
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* Callback docs with autosummary (#3908 )
* callback docs with autosummary
* do not show private methods
* callback base docstring
* skip some docker builds (temporally pass) (#3913 )
* skip some docker builds
* todos
* skip
* use badges only with push (#3914 )
* testtube
* mock test tube
* mock mlflow
* remove mlflow
* clean up
* test
* test
* test
* test
* test
* test
* code blocks
* remove import
* codeblock
* logger
* wandb causes stall
Co-authored-by: William Falcon <waf2107@columbia.edu>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Ananya Harsh Jha <ananya@pytorchlightning.ai>
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
Co-authored-by: Jeff Yang <ydcjeff@outlook.com>
2020-10-06 23:49:06 -04:00
ananthsub
6c47535de8
Update tensorboard.py ( #3920 )
2020-10-06 20:34:15 -04:00
Adrian Wälchli
db0e295f67
Complete mocking Comet and remove dep ( #3910 )
...
* xfail if not installed
include mkpatch
fix test
* mock comet
comet mocks
fix test
remove dep
undo merge duplication
* line
* line
* convert doctest
* doctest
* docs
2020-10-06 19:50:42 -04:00
Adrian Wälchli
893bed741f
Mocking Loggers (part 3b, comet) ( #3853 )
...
* ref
* Mocking Loggers (part 3c, comet) (#3859 )
* mock comet
* new line
2020-10-05 23:00:54 -04:00
Adrian Wälchli
0823cdd59c
Mocking Loggers (part 4a, mlflow) ( #3884 )
...
* extensive mlflow test
* revert accidental commits
2020-10-05 22:27:06 -04:00
William Falcon
b34c7add23
Fixes #3668 , #3887 as a bonus ( #3888 )
...
* Fixes #3668 , #3887 as a bonus
* Fixes #3668 , #3887 as a bonus
2020-10-05 21:30:41 -04:00
Adrian Wälchli
e0f8505394
Mocking loggers (part 2, neptune) ( #3617 )
...
* mock neptune base tests
* neptune doctest
* remove extra
* mock loggers
* typo
* mock import
* neptune not compatible with multigpu
* add back experiment
2020-10-04 21:20:06 -04:00
Brendan Fahy
b14c4d4c70
handle fsspec inconsistency in PyArrowHDFS ( #3805 )
2020-10-02 22:35:42 -04:00
Nathan Raw
698f90164c
remove torch<1.3.0 warning from tb logger ( #3784 )
2020-10-02 15:36:55 +02:00
Sasikanth Kotti
8014d455b7
PR for Issue#3114 ( #3741 )
...
Co-authored-by: Sasikanth <sasikanth@Sasikanths-MacBook-Pro.local>
2020-09-30 08:36:27 -04:00
Adrian Wälchli
3ff5327e83
Mocking loggers (part 1, wandb) ( #3596 )
...
* mocking for wandb
* remove wandb import in amp test
* mock loggers in sphinx
* check tests
* Update extra.txt
* setup
* dev
* min
* revert
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Jirka Borovec <jirka@pytorchlightning.ai>
2020-09-25 16:00:02 +02:00
Rohit Gupta
07b857769a
Allow kwargs in Wandb & Neptune + kwargs docstring ( #3475 )
...
* Allow kwargs in WandbLogger
* isort
* kwargs docstring
* typo
* kwargs for other loggers
* pep and isort
* formatting
* fix failing test
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2020-09-19 18:51:43 +02:00
Boris Feld
e2af4f120e
Improve Comet Logger pickled behavior ( #2553 )
...
* Improve Comet Logger pickled behavior
* Delay the creation of the actual experiment object for as long as we can.
* Save the experiment id in case an Experiment object is created so we can
continue the same experiment in the sub-processes.
* Run pre-commit on the comet file.
* Handle review comment
Make most Comet Logger attribute protected as they might not reflect the final
Experiment attributes. Also fix the typo in the test name.
* Ensure that CometLogger.name and CometLogger.version always returns str
* Add new test for CometLogger.version behavior
* Add new tests for CometLogger.name and CometLogger.version
* Apply review suggestions
* Apply suggestions from code review
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
* Remove extraneous comments in Comet logger tests
* Fix lint issues
* Apply suggestions from code review
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2020-09-18 23:26:29 +02:00
Alexander
5732a56560
Pass epoch argument to Comet Logger ( #3438 )
...
* Pass epoch argument
* Copy epoch instead of inplace pop
* Remove whitespace
* Add test for epoch logging
* add docstring
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2020-09-15 14:30:42 +02:00
Alexander
5b4db52851
Fix #3417 ( #3419 )
2020-09-09 09:27:35 -04:00
Patrick Orlando
656c1af0df
Get experiment_id from MLFlow only once instead of each training loop ( #3394 )
...
* Get experiment_id from MLFlow only once instead of each training loop.
* Apply suggestions from code review
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
* add test that asserts mlflow client is called to retrieve experiment id only once
* make pep8 happy
* logs
Co-authored-by: Patrick Orlando <patrick.orlando@rea-group.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Jirka Borovec <jirka@pytorchlightning.ai>
2020-09-09 11:38:26 +02:00
Brendan Fahy
2d8c1b7c54
use fsspec instead of gfile for all IO ( #3320 )
...
* use fsspec instead of gfile for all IO
This better supports remote (and local) file operations with a dedicated package
* Apply suggestions from code review
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
* chlog
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
Co-authored-by: Jirka Borovec <jirka@pytorchlightning.ai>
2020-09-03 14:19:20 +02:00
James Bockman
79375e6d0a
Bug Fix: Remote Logging with Tensorboard ( #3236 )
...
* Changed standard open to cloud_open
* Changed how version numbers are extracted to remove terminal / from paths
* formatting
Co-authored-by: James Bockman <james@aiml.team>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2020-08-28 07:01:35 -04:00
s-rog
7b054399c6
fix tb hparams logging ( #2974 )
...
* log_hyperparams add default metric
also adds scalar support
* fix typos and style
* another typo
* keep original logging implementation
* remove missed line
* fix capitalization
* add step to leg_metrics for tests
* disable hp metric none (-1) logging
to pass tests
* initial arg implementation
* add step to log_metrics
* add hp_metric case to log test
* add docs
and minor formatting
* fix broken else
* pep8 style
* edit tests
* Update pytorch_lightning/loggers/tensorboard.py
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
* Update pytorch_lightning/loggers/tensorboard.py
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
2020-08-24 06:57:04 +00:00
Rohit Gupta
34c88d127b
Fix log_graph in TensorBoardLogger ( #3092 )
2020-08-22 06:35:09 -04:00
William Falcon
f43028f3ae
added copyright notices ( #3062 )
2020-08-19 22:03:22 -04:00
Nicki Skafte
cefc7f7c32
Feature/log computational graph ( #3003 )
...
* add methods
* log in trainer
* add tests
* changelog
* fix tests
* fix tests
* fix tests
* fix tests
* fix tests
* fix tests
* fix tests
* text
* added argument
* update tests
* fix styling
* improve testing
2020-08-19 19:08:46 -04:00