Commit Graph

4468 Commits

Author SHA1 Message Date
Jirka Borovec 0f9134e043
Refactor: skipif for Windows 2/n (#6268)
* win

* isort

* flake8
2021-03-02 09:36:01 +00:00
Joseph Turian 22985d2f43
Improved EarlyStopping.patience documentation (#6278)
* Improved early stopping documentation

* Changed to 120 column format

* doc

* doc

* doc

Co-authored-by: Jirka Borovec <jirka.borovec@seznam.cz>
2021-03-02 15:01:07 +05:30
Jirka Borovec eb815000f6
Refactor: skipif for multi - gpus 1/n (#6266)
* ngpus

* gpu

* isort

* pt

* flake8
2021-03-02 09:03:32 +01:00
Jirka Borovec dc8647e333
split profilers (#6261) 2021-03-02 07:57:49 +00:00
Sean Naren efda48faab
Disable CPU Offload as default for DeepSpeed (#6262)
* Change default for CPU offload to false for best throughput/memory efficiency

* Add changelog

* default

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2021-03-02 07:53:12 +00:00
Kunal Mundada 3371d32664
docstring changes in tuner (#6264)
* docstring changes in tuner

* added full stop
2021-03-02 09:22:44 +08:00
Jirka Borovec 6788dbabff
switch agents pool (#6270) 2021-03-01 22:14:55 +01:00
Akihiro Nitta 412a7d812e
Remove opt from manual_backward in docs (#6267) 2021-03-01 18:15:43 +00:00
Jirka Borovec ed67490d93
cleaning SWA (#6259)
* rename

* if

* test

* chlog
2021-03-01 19:10:27 +01:00
Jirka Borovec 352e8f0d28
add skipif warpper (#6258) 2021-03-01 15:26:09 +00:00
David Völgyes 651c25feb6
Fix for incorrect usage of detach(), cpu(), to() (#6216)
* Fix for incorrect detach/cpu calls (#6214)

* Fix incorrect use of detach(), to(), and cpu(), #6214

* Fix incorrect use of detach() and cpu(), #6214

* update pr

* add typing

* chlog

* more...

* revert on module

* update on comments

* revert changes on model

Co-authored-by: tchaton <thomas@grid.ai>
Co-authored-by: Jirka Borovec <jirka.borovec@seznam.cz>
2021-03-01 15:15:52 +00:00
Akihiro Nitta 925f082572
Call `optimizer.zero_grad()` before backward inside closure in AutoOpt (#6147)
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
2021-03-01 14:36:46 +01:00
Kunal Mundada 8aba88506f
Document Exceptions in profilers (#6229)
* docstring changes in profilers

* minor changes in profilers.py
2021-03-01 14:16:06 +01:00
Adrian Wälchli ce0568700b
update (#6237) 2021-03-01 14:14:53 +01:00
Jirka Borovec 58a6d59784
simplify skip-if tests >> 0/n (#5920)
* skipif + yapf + isort

* tests

* docs

* pp
2021-03-01 12:17:09 +00:00
prajakta0111 15c477e9fc
document exceptions for metrics/regression (#6202)
Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
Co-authored-by: Prajakta Phadke <pphadke@iu.edu>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
2021-02-28 20:22:26 +05:30
Carlos Mocholí 111d9c7267
Prune deprecated hparams setter (#6207) 2021-02-27 13:24:50 +01:00
Boris Dayma 40d5a9d6df
fix(wandb): prevent WandbLogger from dropping values (#5931)
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2021-02-27 01:52:23 +00:00
dbonner ee5032a478
apply_func.py: from torchtext.legacy.data import Batch (#6211)
* Update apply_func.py

The name Batch is no longer located under torchtext.data
--Error message--
File "/home/daniel/py38/lib/python3.8/site-packages/pytorch_lightning/utilities/apply_func.py", line 25, in <module>                                                      
    from torchtext.data import Batch                                                  
ImportError: cannot import name 'Batch' from 'torchtext.data' (/home/daniel/py38/lib/p
ython3.8/site-packages/torchtext/data/__init__.py)
You can fix this by changing line line 28 to:
    from torchtext.legacy.data import Batch

* Update apply_func.py

* Update apply_func.py

* Update apply_func.py

* Update apply_func.py

* Update apply_func.py
2021-02-26 19:23:07 +05:30
Justus Schock 0647340f3b
Add mypy typing to precision plugins. (#6149)
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Jirka Borovec <jirka.borovec@seznam.cz>
Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
2021-02-26 14:27:16 +01:00
Kaushik B e7298b5d38
fix parallel devices return type & add copyright (#6215) 2021-02-26 11:09:08 +01:00
Carlos Mocholí ddf55a2f6a
Prune deprecated Trainer(checkpoint_callback=ModelCheckpoint()) (#6166) 2021-02-25 20:42:23 +00:00
Kunal Mundada 4d96f19493
Document exceptions in loggers (#6171)
* Document exceptions in loggers

* minor formatting

* docstring changed in comet.py

* Apply suggestions from code review

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
2021-02-25 21:08:32 +01:00
Carlos Mocholí 3df02b880a
Add checkpoint parameter to on_save_checkpoint (#6072)
Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
2021-02-25 21:18:19 +05:30
Sean Naren dd2f5a0212
Fix for multiple callbacks (#6197)
* Fix for multiple callbacks

* Add CHANGELOG.md

* Remove old params

* Skip tests on windows using ddp

* Change name of the variable to not clash with should stop, which is separate

* Apply suggestions from code review

* Fix params

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2021-02-25 15:44:55 +00:00
Justus Schock 3ed8ef8af9
type accelerators (#6148) 2021-02-25 06:42:23 +00:00
edenlightning b0d1996920
Update gpu warning (#6181)
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Kaushik Bokka <kaushikbokka@gmail.com>
2021-02-25 01:43:48 +05:30
Rohit Gupta c7130b7e1e
Update with GitHub Discussions (#6186) 2021-02-25 00:28:23 +05:30
edenlightning c33fd528ca
Update issue template to use discussions for questions (#6155)
* add issue config

* remove question template

* update URL

* Update README.md

* Update README.md

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

* Update .github/ISSUE_TEMPLATE/config.yml

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
2021-02-24 10:15:57 -05:00
Akihiro Nitta 5cf892b5f6
Fix typo (#6178) 2021-02-24 10:14:25 -05:00
Carlos Mocholí 8b475278dd
Prune deprecated EarlyStopping(mode='auto') (#6167)
Co-authored-by: Roger Shieh <sh.rog@protonmail.ch>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
2021-02-24 13:26:33 +00:00
Jirka Borovec 46617d9021
Prune deprecated checkpoint arguments (#6162)
* prune prefix

* prune mode=auto

* chlog
2021-02-24 06:58:53 -05:00
Nicki Skafte 1b498d1f14
[Bugfix] Fixed epoch level schedulers not being called when val_check_interval < 1.0 (#6075)
* fix bug

* fix tests

* changelog

* fix pep8

* fix tests

* fix and add some tests

* add test for rlop

* chlog

* Update CHANGELOG.md

Co-authored-by: rohitgr7 <rohitgr1998@gmail.com>
2021-02-24 16:46:33 +05:30
Jirka Borovec a731269056
Prune deprecated metrics for 1.3 (#6161)
* prune deprecated metrics for 1.3

* isort / yapf
2021-02-24 11:09:01 +00:00
Jirka Borovec 1d9c553b86
prune deprecated Trainer arg `enable_pl_optimizer` (#6163)
* prune enable_pl_optimizer

* prune automatic_optimization
2021-02-24 10:01:24 +00:00
Jirka Borovec 09baf29ecb
prune deprecated profiler as bool (#6164)
* prune profiler

* chlog
2021-02-24 09:08:21 +00:00
Carlos Mocholí 45158aabfa
Update CHANGELOG (#6156) 2021-02-23 23:44:39 +00:00
Jirka Borovec 1c851b89e1
fixing miss-leading tested acc values (#5876)
* fixing tested values

* .

* tests

* yapf

* softmax

* hvd

* rename

* lr

* duplicate

* drop

* classif

* rm EvalModel

* Revert "rm EvalModel"

This reverts commit 6c3fb39ebe.

* update tests

* fix

* azure

* azure

* self

* cpu

* Apply suggestions from code review

Co-authored-by: rohitgr7 <rohitgr1998@gmail.com>
2021-02-23 22:08:46 +00:00
ifsheldon ebabe56f4e
Ensure accelerator is valid if running interactively (#5970)
Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
2021-02-23 14:23:50 +01:00
Sean Naren 863a70c294
Add specifics around DeepSpeed docs (#6142)
* Be more specific with DeepSpeed compatibility

* Better wording
2021-02-23 00:08:39 +01:00
Adrian Wälchli 0456b4598f
mini refactor for _running_stage access (#5724)
* running stage

* circular import

* running stage cleanup

* fix unused import

* fix running stage access

* add return type

* Revert "add return type"

This reverts commit 65b0fe269c.

* try fix typing
2021-02-22 12:01:54 +01:00
Alexander 423ecf995a
Feature/5275 clean progress bar print (#5470)
* Trainer.test should return only test metrics (#5214)

* resolve bug

* merge tests

* Fix metric state reset (#5273)

* Fix metric state reset

* Fix test

* Improve formatting

Co-authored-by: Ananya Harsh Jha <ananya@pytorchlightning.ai>

* print() method added to ProgressBar

* printing alongside progress bar added to LightningModule.print()

* LightningModule.print() method documentation updated

* ProgressBarBase.print() stub added

* stub

* add progress bar tests

* fix isort

* Progress Callback fixes

* test_metric.py duplicate DummyList removed

* PEP and isort fixes

* CHANGELOG updated

* test_progress_bar_print win linesep fix

* test_progress_bar.py remove whitespaces

* Update CHANGELOG.md

Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Tadej Svetina <tadej.svetina@gmail.com>
Co-authored-by: Ananya Harsh Jha <ananya@pytorchlightning.ai>
Co-authored-by: Alexander Snorkin <Alexander.Snorkin@acronis.com>
Co-authored-by: rohitgr7 <rohitgr1998@gmail.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
2021-02-22 09:40:18 +00:00
Carlos Mocholí 57215b79a0
Avoid printing ModelCheckpoint log with monitor=None and verbose=True (#6109) 2021-02-22 08:51:13 +00:00
Akihiro Nitta 1d28d11a07
Minor fixes/improvements in Metric docs (#6114)
* Fix wrong render

* Improve classification metrics docs

* Improve other domain metrics docs

* Change the structure level in the docs
2021-02-22 16:50:59 +08:00
Kaushik B 9b99328d44
Update Contributing Guide (#6118)
* Update Contributing Guide

* update docs
2021-02-22 07:21:01 +00:00
Adrian Wälchli ae6ce17598
fix amp/apex misconfiguration error for cpu (#6107)
* fix weird test

* fix apex plugin test

* fix raise

* cpu test

* fix type

* add changelog
2021-02-22 01:02:31 +01:00
Carlos Mocholí 97b4b3ee68
Collapse 2 DeepSpeed tests (#6108) 2021-02-21 21:15:37 +00:00
Sean Naren 432e5637d6
Expose DeepSpeed FP16 parameters due to loss instability (#6115)
* Expose deepspeed config parameters to init function due to instability in parameters

* See if tests can run on normal CI, without special tests

* Add changelog

* Update pytorch_lightning/plugins/training_type/deepspeed.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
2021-02-21 21:43:11 +01:00
Sean Naren 3b0e4e0b2b
Enable ZeRO tests for CI, fix to/half function calls (#6070)
* Enable ZeRO optimization, and make sure that the lightning module hook is called when we move to half precision

* Added test, update to function
2021-02-21 00:24:44 +00:00
Sean Naren 97a81c3cfe
[Hot Fix] Give priority to plugins to set distributed mode, and then accelerator (#6089)
* Give priority to plugins to set distributed mode, and then accelerator

* Add CHANGELOG.md

* Update CHANGELOG.md

* Remove very scary line

* Ensure we set cluster environment after slurm configured if necessary

* Simplify the fix with a reset

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
2021-02-20 12:58:54 +00:00