Commit Graph

4 Commits

Author SHA1 Message Date
Rick Izzo b4d99e3cc1
Add CLI Command to Delete Lightning App (#15783)
* initial work on deleting apps

* after PR review

* delete CLI working

* restructred to make tests easier

* revert manifest changes

* added changelog, fix mypy issue

* updates

* Update src/lightning_app/cli/cmd_apps.py

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>

* Update src/lightning_app/cli/lightning_cli_delete.py

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>

* Update src/lightning_app/cli/lightning_cli_delete.py

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>

* Update src/lightning_app/cli/lightning_cli_delete.py

Co-authored-by: Sherin Thomas <sherin@lightning.ai>

* Update src/lightning_app/cli/lightning_cli_delete.py

Co-authored-by: Sherin Thomas <sherin@lightning.ai>

* import typing

* adding tests

* finished adding tests

* addressed code review comments

* fix mypy error

* make mypy happy

* make mypy happy

* make mypy happy

* make mypy happy

* fix windows cli

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: Sherin Thomas <sherin@lightning.ai>
2022-12-05 22:51:32 +01:00
Raphael Randschau c786b3d862
[CLI] fix ssh listing stopped components (#15810)
* [CLI] fix ssh listing stopped components
* update CHANGELOG
2022-11-28 04:37:34 +01:00
Raphael Randschau f53c0a7053
Add SSH command to CLI (#15310)
* implement ssh command

* add tests that ssh command is available

* most SSH command tests

* update changelog

* Update src/lightning_app/cli/lightning_cli.py

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

* adrian feedback pt1

* Update src/lightning_app/cli/lightning_cli.py

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

* more feedback

* rework to support app name

* update tests based on different interface

* Update src/lightning_app/cli/lightning_cli.py

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

* Update src/lightning_app/cli/lightning_cli.py

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

* Update src/lightning_app/cli/lightning_cli.py

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

* Update src/lightning_app/cli/lightning_cli.py

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

* update tests with changed expectation

* fix tests that broke with introduction of shutils

* fix too long line

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2022-11-03 08:32:08 -07:00
Raphael Randschau 26d69ceada
[CLI] add support for listing apps (#13987)
* add support for listing apps

* update changelog with correct PR number

* add tests for pagination

* fix wrong mock on test_cli

* ensure all enum values are accounted for

* make AppManager and AppList protected, add limit to pagination calls

* add restarting transition /w tests

* add state transition not yet run with tests
2022-08-05 13:42:00 -07:00