Rooba
/
lightning
mirror of https://github.com/Lightning-AI/lightning.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

update PR template (#5206) 

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
(cherry picked from commit b22b1c2df2)
This commit is contained in:
Jirka Borovec 2020-12-23 22:31:09 +01:00 committed by Jirka Borovec
parent 5e71c88096
commit f77c3d8d43
2 changed files with 16 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
.github/ISSUE_TEMPLATE/bug_report.md vendored
View File

@ -10,11 +10,15 @@ assignees: ''
<!-- A clear and concise description of what the bug is. -->
## Please reproduce using [the BoringModel and post here](https://colab.research.google.com/drive/1HvWVVTK8j2Nj52qU4Q4YCyzOm0_aLQF3?usp=sharing)
## Please reproduce using the BoringModel
<!-- Please paste your BoringModel colab link here. -->
### To Reproduce
Use following [**BoringModel**](https://colab.research.google.com/drive/1HvWVVTK8j2Nj52qU4Q4YCyzOm0_aLQF3?usp=sharing) and post here
<!-- If you could not reproduce using the BoringModel and still think there's a bug, please post here -->
### Expected behavior

16
.github/PULL_REQUEST_TEMPLATE.md vendored
View File

@ -1,6 +1,11 @@
## What does this PR do?
<!--
IMPORTANT:
We separated bug-fix PRs and feature PRs and they shall land in master and release/1.X-dev accordingly.
By default all PR are targeted to master which is correct for bug-fixes, but need to be change for features.
If you miss it we can still fix it for you, just ping us... :]
Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context.
List any dependencies that are required for this change.
@ -8,14 +13,14 @@ Please include a summary of the change and which issue is fixed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
-->
Fixes # (issue)
Fixes # (issue) <- this [links related issue to this PR](https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword)
## Before submitting
- [ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
- [ ] Did you read the [contributor guideline](https://github.com/PyTorchLightning/pytorch-lightning/blob/master/.github/CONTRIBUTING.md), Pull Request section?
- [ ] Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
- [ ] Did you make sure to update the documentation with your changes?
- [ ] Did you write any new necessary tests?
- [ ] Did you make sure your PR does only one thing, instead of bundling different changes together?
- [ ] Did you make sure to update the documentation with your changes [if needed]?
- [ ] Did you write any new necessary tests [no need for typos, docs]?
- [ ] Did you verify new and existing tests pass locally with your changes?
- [ ] If you made a notable change (that affects users), did you update the [CHANGELOG](https://github.com/PyTorchLightning/pytorch-lightning/blob/master/CHANGELOG.md)?
@ -28,7 +33,8 @@ Before you start reviewing make sure you have read [Review guidelines](https://g
- [ ] Is this pull request ready for review? (if not, please submit in draft mode)
- [ ] Check that all items from **Before submitting** are resolved
- [ ] Make sure the title is self-explanatory and the description concisely explains the PR
- [ ] Add labels and milestones (and optionally projects) to the PR so it can be classified; _Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases._
- [ ] Add labels and milestones (and optionally projects) to the PR so it can be classified
- [ ] **Check that target branch and milestone are aligned!**
## Did you have fun?