From ea658e300c7ed94b6fbd4c268782c9a96d94e420 Mon Sep 17 00:00:00 2001
From: Jirka Borovec <Borda@users.noreply.github.com>
Date: Fri, 7 Aug 2020 09:08:23 +0200
Subject: [PATCH] Tests/install pkg (#2835)

* add install matrix

* nb tests

* win

* cfg

* torch

* link

* Update .github/workflows/install-pkg.yml

Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>

* try

* try

* try

* try

Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
---
 .github/workflows/install-pkg.yml | 46 ++++++++++++++-----------------
 .mergify.yml                      |  2 +-
 2 files changed, 21 insertions(+), 27 deletions(-)

diff --git a/.github/workflows/install-pkg.yml b/.github/workflows/install-pkg.yml
index 0b2e0e5b06..96c47a22dc 100644
--- a/.github/workflows/install-pkg.yml
+++ b/.github/workflows/install-pkg.yml
@@ -12,14 +12,22 @@ on:
       - master
 
 jobs:
-  pkg-check:
-    runs-on: ubuntu-20.04
+
+  pkg-install:
+    runs-on: ${{ matrix.os }}
+    strategy:
+      fail-fast: false
+      # max-parallel: 6
+      matrix:
+        # PyTorch 1.5 is failing on Win and bolts requires torchvision>=0.5
+        os: [ubuntu-20.04, macOS-10.15 , windows-2019]  #
+        python-version: [3.6, 3.8]
 
     steps:
       - uses: actions/checkout@master
       - uses: actions/setup-python@v2
         with:
-          python-version: 3.7
+          python-version: ${{ matrix.python-version }}
 
       - name: Create package
         run: |
@@ -32,32 +40,18 @@ jobs:
           twine check dist/*
           python setup.py clean
 
-  pkg-install:
-    runs-on: ${{ matrix.os }}
-    strategy:
-      fail-fast: false
-      # max-parallel: 6
-      matrix:
-        # PyTorch 1.5 is failing on Win and bolts requires torchvision>=0.5
-        os: [ubuntu-20.04]  # , windows-2019
-        python-version: [3.6, 3.7, 3.8]
-
-    steps:
-      - uses: actions/checkout@master
-      - uses: actions/setup-python@v2
-        with:
-          python-version: 3.7
-
-      - name: Create package
+      - name: Setup Windows
+        if: runner.os == 'windows'
         run: |
-          # python setup.py check --metadata --strict
-          python setup.py sdist
+          # this is just a hotfix because of Win cannot install it directly
+          pip install -r requirements/base.txt --find-links https://download.pytorch.org/whl/torch_stable.html
 
       - name: Install package
         run: |
-          pip install virtualenv
-          virtualenv vEnv ; source vEnv/bin/activate
-          # pip install -r requirements.txt
+          # pip install virtualenv
+          # virtualenv vEnv --system-site-packages
+          # source vEnv/bin/activate
           pip install dist/*
           cd .. & python -c "import pytorch_lightning as pl ; print(pl.__version__)"
-          deactivate ; rm -rf vEnv
+          # deactivate
+          # rm -rf vEnv
diff --git a/.mergify.yml b/.mergify.yml
index 215cb3f020..db837ca84c 100644
--- a/.mergify.yml
+++ b/.mergify.yml
@@ -10,7 +10,7 @@ pull_request_rules:
       # no requested chnages from any reviewer
       - "#changes-requested-reviews-by=0"
       # this serves as ALL check has to pass as we have actually around 40 tests in total
-      - "#status-success>=39"
+      - "#status-success>=41"
       # this is just in case since we rely on GPU tests (note: redundand to the above)
       - status-success=continuous-integration/drone/pr
       - "status-success=ci/circleci: TPU-tests"