From e8121610a4917b2d8ec57800c2c67ca1400856ca Mon Sep 17 00:00:00 2001 From: Adam Bobowski <100693297+adam-lightning@users.noreply.github.com> Date: Tue, 30 Aug 2022 22:13:43 +0200 Subject: [PATCH] [App] fix panel requirements (#14450) * update base requirements * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * try main * Apply suggestions from code review * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * extract into separate function * drop * up * up * optional * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * . Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jirka Co-authored-by: Jirka Borovec --- src/lightning_app/frontend/panel/app_state_comm.py | 6 +++--- src/lightning_app/frontend/panel/panel_serve_render_fn.py | 6 +++++- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/lightning_app/frontend/panel/app_state_comm.py b/src/lightning_app/frontend/panel/app_state_comm.py index f7d9c01e7d..d9092628dd 100644 --- a/src/lightning_app/frontend/panel/app_state_comm.py +++ b/src/lightning_app/frontend/panel/app_state_comm.py @@ -6,7 +6,7 @@ from __future__ import annotations import asyncio import logging import os -import threading +from threading import Thread from typing import Callable import websockets @@ -16,7 +16,7 @@ from lightning_app.core.constants import APP_SERVER_PORT _logger = logging.getLogger(__name__) _CALLBACKS = [] -_THREAD: None | threading.Thread = None +_THREAD: Thread = None def _get_ws_port(): @@ -62,7 +62,7 @@ def _start_websocket(): global _THREAD # pylint: disable=global-statement if not _THREAD: _logger.debug("Starting the watch_app_state thread.") - _THREAD = threading.Thread(target=_target_fn) + _THREAD = Thread(target=_target_fn) _THREAD.setDaemon(True) _THREAD.start() _logger.debug("thread started") diff --git a/src/lightning_app/frontend/panel/panel_serve_render_fn.py b/src/lightning_app/frontend/panel/panel_serve_render_fn.py index 7aff3d5c3e..88c8d6cb98 100644 --- a/src/lightning_app/frontend/panel/panel_serve_render_fn.py +++ b/src/lightning_app/frontend/panel/panel_serve_render_fn.py @@ -42,7 +42,7 @@ def _get_render_fn(): return render_fn -if __name__.startswith("bokeh"): +def main(): import panel as pn # I use caching for efficiency reasons. It shaves off 10ms from having @@ -50,3 +50,7 @@ if __name__.startswith("bokeh"): if "lightning_render_fn" not in pn.state.cache: pn.state.cache["lightning_render_fn"] = _get_render_fn() pn.state.cache["lightning_render_fn"]() + + +if __name__.startswith("bokeh"): + main()