From e226180527b065813bb1ba5e83f4990c3b81d444 Mon Sep 17 00:00:00 2001 From: thomas chaton Date: Wed, 10 Aug 2022 19:26:01 +0200 Subject: [PATCH] (app) Remove ClickRunner (#14147) --- README.md | 2 +- tests/tests_app_examples/test_boring_app.py | 7 +------ 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/README.md b/README.md index 2d32094f65..f9d5a9a57f 100644 --- a/README.md +++ b/README.md @@ -1,4 +1,4 @@ -### ** NEWS: PyTorch Lightning has been renamed Lightning! In addition to building models, you can now build research workflows and production pipelines** +### \*\* NEWS: PyTorch Lightning has been renamed Lightning! In addition to building models, you can now build research workflows and production pipelines\*\*
diff --git a/tests/tests_app_examples/test_boring_app.py b/tests/tests_app_examples/test_boring_app.py index f8143b1db1..0ca1b823b4 100644 --- a/tests/tests_app_examples/test_boring_app.py +++ b/tests/tests_app_examples/test_boring_app.py @@ -13,7 +13,6 @@ def test_boring_app_example_cloud() -> None: with run_app_in_cloud(os.path.join(_PROJECT_ROOT, "examples/app_boring/"), app_name="app_dynamic.py") as ( _, view_page, - _, name, ): @@ -31,8 +30,4 @@ def test_boring_app_example_cloud() -> None: assert result.exit_code == 0 assert result.exception is None - assert len(lines) > 1, result.output - # We know that at some point we need to intstall lightning, so we check for that - assert any( - "Successfully built lightning" in line for line in lines - ), f"Did not find logs with lightning installation: {result.output}" + assert any("http://0.0.0.0:8080" in line for line in lines)