From df640f7d870e3eb28320514fcaba2f656b572383 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Mochol=C3=AD?= Date: Thu, 15 Sep 2022 13:29:47 +0200 Subject: [PATCH] Drop gatekeeper CI checks (#14717) --- .github/checkgroup.yml | 1 - .github/gatekeeper-config_app.yml | 12 --------- .github/gatekeeper-config_pytorch.yml | 15 ----------- .github/workflows/README.md | 2 +- .github/workflows/ci-pr-gatekeeper.yml | 35 -------------------------- 5 files changed, 1 insertion(+), 64 deletions(-) delete mode 100644 .github/gatekeeper-config_app.yml delete mode 100644 .github/gatekeeper-config_pytorch.yml delete mode 100644 .github/workflows/ci-pr-gatekeeper.yml diff --git a/.github/checkgroup.yml b/.github/checkgroup.yml index 6acef15177..11e3a427bd 100644 --- a/.github/checkgroup.yml +++ b/.github/checkgroup.yml @@ -47,7 +47,6 @@ subprojects: - "make-doctest (pytorch)" - "make-html (pytorch)" - "mypy" - - "PR Gatekeeper (pytorch)" - "pytorch-lightning (GPUs)" - "pytorch-lightning (HPUs)" - "pytorch-lightning (IPUs)" diff --git a/.github/gatekeeper-config_app.yml b/.github/gatekeeper-config_app.yml deleted file mode 100644 index 9e51c23458..0000000000 --- a/.github/gatekeeper-config_app.yml +++ /dev/null @@ -1,12 +0,0 @@ -approvals: - groups: - - name: 'Lightning Apps' - minimum: 1 - from: - - alecmerdler - - awaelchli - - hhsecond - - lantiga - - manskx - - nohalon - - tchaton diff --git a/.github/gatekeeper-config_pytorch.yml b/.github/gatekeeper-config_pytorch.yml deleted file mode 100644 index 75201f796c..0000000000 --- a/.github/gatekeeper-config_pytorch.yml +++ /dev/null @@ -1,15 +0,0 @@ -approvals: - groups: - - name: 'PyTorch Lightning' - minimum: 1 - from: - - awaelchli - - Borda - - carmocca - - ethanwharris - - kaushikb11 - - krshrimali - - otaj - - rohitgr7 - - tchaton - - williamFalcon diff --git a/.github/workflows/README.md b/.github/workflows/README.md index 4ed903c0f3..2067c244f1 100644 --- a/.github/workflows/README.md +++ b/.github/workflows/README.md @@ -59,5 +59,5 @@ | .github/mergify.yml | Label PRs as conflicts or ready, and request reviews if needed. | | .github/stale.yml | Close inactive issues/PRs sometimes after adding the "won't fix" label to them. | | .github/workflows/probot-auto-cc.yml, .github/lightning-probot.yml | Notify maintainers of interest depending on labels added to an issue We utilize lightning-probot forked from PyTorch’s probot. | +| .github/workflows/probot-check-group.yml, .github/checkgroup.yml | Checks whether the relevant jobs were successfully run based on the changed files in the PR | | .pre-commit-config.yaml | pre-commit.ci runs a set of linters and formatters, such as black, flake8 and isort. When formatting is applied, the bot pushes a commit with its change. This configuration is also used for running pre-commit locally. | -| .github/workflows/ci-pr-gatekeeper.yml | Prevent PRs from merging into master without any Grid.ai employees’ approval. | diff --git a/.github/workflows/ci-pr-gatekeeper.yml b/.github/workflows/ci-pr-gatekeeper.yml deleted file mode 100644 index f13aa98f87..0000000000 --- a/.github/workflows/ci-pr-gatekeeper.yml +++ /dev/null @@ -1,35 +0,0 @@ -name: 'PR Gatekeeper' - -on: - pull_request_review: - types: [submitted] - -# todo: simplify after adding https://github.com/octodemo/pr-gatekeeper/issues/293 - -jobs: - gatekeeper: - name: PR Gatekeeper - runs-on: ubuntu-20.04 - strategy: - fail-fast: false - matrix: - pkg: ["app", "pytorch"] - steps: - - uses: actions/checkout@v3 - with: - fetch-depth: "2" # To retrieve the preceding commit. - - name: Get changed files using defaults - id: changed-files - uses: tj-actions/changed-files@v29.0.4 - - name: Determine changes - id: touched - run: | - patterns = ('docs/source-${{ matrix.pkg }}', 'src/lightning_${{ matrix.pkg }}', 'tests/tests_${{ matrix.pkg }}') - changed = any(p in "${{steps.changed-files.outputs.all_changed_and_modified_files}}" for p in patterns) - print(f'::set-output name=files::{int(changed)}') - shell: python - - uses: octodemo/pr-gatekeeper@main - if: steps.touched.outputs.files == 1 - with: - token: ${{ secrets.GITHUB_TOKEN }} - config-file: './.github/gatekeeper-config_${{ matrix.pkg }}.yml'