From d4d5418cc4086a7cb8ecc18a42e0eb109b3b7859 Mon Sep 17 00:00:00 2001 From: edenlightning <66261195+edenlightning@users.noreply.github.com> Date: Thu, 24 Jun 2021 00:36:31 +0300 Subject: [PATCH] Fix notebook links (#8089) * Fix notebook links * update * BERT * docs * Update README.md * Apply suggestions from code review Co-authored-by: Jirka Co-authored-by: Jirka Borovec --- README.md | 7 +++---- _notebooks | 2 +- docs/source/conf.py | 1 + docs/source/index.rst | 2 ++ 4 files changed, 7 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 8da7836fb6..7a540adadd 100644 --- a/README.md +++ b/README.md @@ -338,8 +338,7 @@ class LitAutoEncoder(pl.LightningModule): ## Examples ###### Hello world -- [MNIST hello world](https://colab.research.google.com/github/PytorchLightning/pytorch-lightning/blob/master/notebooks/01-mnist-hello-world.ipynb) -- [MNIST on TPUs](https://colab.research.google.com/github/PytorchLightning/pytorch-lightning/blob/master/notebooks/06-mnist-tpu-training.ipynb) +- [MNIST hello world](https://pytorch-lightning.readthedocs.io/en/latest/notebooks/lightning_examples/mnist-hello-world.html) ###### Contrastive Learning - [BYOL](https://lightning-bolts.readthedocs.io/en/latest/self_supervised_models.html#byol) @@ -348,8 +347,8 @@ class LitAutoEncoder(pl.LightningModule): - [SIMCLR](https://lightning-bolts.readthedocs.io/en/latest/self_supervised_models.html#simclr) ###### NLP -- [BERT](https://colab.research.google.com/github/PytorchLightning/pytorch-lightning/blob/master/notebooks/04-transformers-text-classification.ipynb) - [GPT-2](https://lightning-bolts.readthedocs.io/en/latest/convolutional.html#gpt-2) +- [BERT](https://pytorch-lightning.readthedocs.io/en/latest/notebooks/lightning_examples/text-transformers.html) ###### Reinforcement Learning @@ -358,7 +357,7 @@ class LitAutoEncoder(pl.LightningModule): - [Reinforce](https://lightning-bolts.readthedocs.io/en/latest/reinforce_learn.html#reinforce) ###### Vision -- [GAN](https://colab.research.google.com/github/PytorchLightning/pytorch-lightning/blob/master/notebooks/03-basic-gan.ipynb) +- [GAN](https://pytorch-lightning.readthedocs.io/en/latest/notebooks/lightning_examples/basic-gan.html) ###### Classic ML - [Logistic Regression](https://lightning-bolts.readthedocs.io/en/latest/classic_ml.html#logistic-regression) diff --git a/_notebooks b/_notebooks index 3321b468e7..29aea106ed 160000 --- a/_notebooks +++ b/_notebooks @@ -1 +1 @@ -Subproject commit 3321b468e78167aaf056894e92ed6d649c76e89e +Subproject commit 29aea106edefc9d1904c0c17223a8ac2b15c48e7 diff --git a/docs/source/conf.py b/docs/source/conf.py index 042e44a936..111cd6887f 100644 --- a/docs/source/conf.py +++ b/docs/source/conf.py @@ -152,6 +152,7 @@ language = None exclude_patterns = [ f'{FOLDER_GENERATED}/PULL_REQUEST_TEMPLATE.md', 'notebooks/course_UvA-DL/*', + 'notebooks/template*', ] # The name of the Pygments (syntax highlighting) style to use. diff --git a/docs/source/index.rst b/docs/source/index.rst index a718530a42..1a54e6a647 100644 --- a/docs/source/index.rst +++ b/docs/source/index.rst @@ -61,6 +61,8 @@ PyTorch Lightning Documentation notebooks/lightning_examples/datamodules.ipynb notebooks/lightning_examples/cifar10-baseline.ipynb notebooks/lightning_examples/basic-gan.ipynb + notebooks/lightning_examples/text-transformers.ipynb + notebooks/lightning_examples/reinforce-learning-DQN.ipynb notebooks/lightning_examples/augmentation_kornia.ipynb .. toctree::