Rooba
/
lightning
mirror of https://github.com/Lightning-AI/lightning.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Annotate return type of TrainerProperties.from_argparse_args(...) (#4192) 

* Annotate return type of TrainerProperties.from_argparse_args(...)

* Added second empty line between class and typevar

* Renamed all uses of the typevar to _T
This commit is contained in:
Elia Cereda 2020-10-17 14:00:50 +02:00 committed by GitHub
parent aca072a4bc
commit cf9fe4905e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pytorch_lightning/trainer/properties.py
View File

@ -14,7 +14,7 @@
from pytorch_lightning.utilities.cloud_io import get_filesystem from pytorch_lightning.utilities.cloud_io import get_filesystem
from pytorch_lightning.trainer.connectors.logger_connector import LoggerConnector from pytorch_lightning.trainer.connectors.logger_connector import LoggerConnector
from pytorch_lightning.trainer.states import TrainerState from pytorch_lightning.trainer.states import TrainerState
from typing import List, Optional, Union from typing import List, Optional, Union, Type, TypeVar
from pytorch_lightning.utilities import argparse_utils from pytorch_lightning.utilities import argparse_utils
from argparse import ArgumentParser, Namespace from argparse import ArgumentParser, Namespace
from abc import ABC from abc import ABC
@ -118,7 +118,7 @@ class TrainerProperties(ABC):
return depr_arg_names return depr_arg_names
@classmethod @classmethod
def from_argparse_args(cls, args: Union[Namespace, ArgumentParser], **kwargs): def from_argparse_args(cls: Type['_T'], args: Union[Namespace, ArgumentParser], **kwargs) -> '_T':
return argparse_utils.from_argparse_args(cls, args, **kwargs) return argparse_utils.from_argparse_args(cls, args, **kwargs)
@classmethod @classmethod
@ -191,3 +191,7 @@ class TrainerProperties(ABC):
def get_model(self): def get_model(self):
return self.model_connector.get_model() return self.model_connector.get_model()
# Used to represent the concrete type TrainerProperties class methods are called on.
_T = TypeVar('_T', bound=TrainerProperties)