[App] Fix e2e tests (#16146)

This commit is contained in:
Ethan Harris 2022-12-20 20:46:38 +00:00 committed by GitHub
parent bf8e568845
commit c98b0c4f08
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 25 deletions

View File

@ -386,34 +386,24 @@ def run_app_in_cloud(
process = Process(target=_print_logs, kwargs={"app_id": app_id})
process.start()
if not app.spec.is_headless:
while True:
try:
with admin_page.context.expect_page() as page_catcher:
admin_page.locator('[data-cy="open"]').click()
view_page = page_catcher.value
view_page.wait_for_load_state(timeout=0)
break
except (playwright._impl._api_types.Error, playwright._impl._api_types.TimeoutError):
pass
else:
view_page = None
# Wait until the app is running
while True:
sleep(1)
# Wait until the app is running
while True:
sleep(1)
lit_apps = [
app
for app in client.lightningapp_instance_service_list_lightningapp_instances(
project_id=project.project_id
).lightningapps
if app.name == name
]
app = lit_apps[0]
lit_apps = [
app
for app in client.lightningapp_instance_service_list_lightningapp_instances(
project_id=project.project_id
).lightningapps
if app.name == name
]
app = lit_apps[0]
if app.status.phase == V1LightningappInstanceState.RUNNING:
break
if app.status.phase == V1LightningappInstanceState.RUNNING:
break
view_page = context.new_page()
view_page.goto(f"{app.status.url}/view")
# TODO: is re-creating this redundant?
lit_apps = [