Make sure save_dir can be empty str (#15638)

2022-11-11 19:21:22 +08:00 · 2022-11-11 19:21:22 +08:00 · c53dc205ed
parent 164e5a7b3e
commit c53dc205ed
1 changed files with 4 additions and 1 deletions
--- a/src/pytorch_lightning/callbacks/model_checkpoint.py
+++ b/src/pytorch_lightning/callbacks/model_checkpoint.py
@ -584,7 +584,10 @@ class ModelCheckpoint(Checkpoint):
            return self.dirpath

        if len(trainer.loggers) > 0:
-            save_dir = trainer.loggers[0].save_dir or trainer.default_root_dir
+            if trainer.loggers[0].save_dir is not None:
+                save_dir = trainer.loggers[0].save_dir
+            else:
+                save_dir = trainer.default_root_dir
            name = trainer.loggers[0].name
            version = trainer.loggers[0].version
            version = version if isinstance(version, str) else f"version_{version}"