From a4fa7f890a14909b992c85f76561c7f1fd7823a7 Mon Sep 17 00:00:00 2001 From: Roger Shieh <55400948+s-rog@users.noreply.github.com> Date: Wed, 21 Oct 2020 16:32:40 +0800 Subject: [PATCH] encourage draft PR submission (#4274) --- .github/PULL_REQUEST_TEMPLATE.md | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 6acdf458d7..6e6a6af863 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -8,8 +8,7 @@ Please include a summary of the change and which issue is fixed. Fixes # (issue) -# Before submitting - +## Before submitting - [ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements) - [ ] Did you read the [contributor guideline](https://github.com/PyTorchLightning/pytorch-lightning/blob/master/.github/CONTRIBUTING.md), Pull Request section? - [ ] Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change. @@ -20,8 +19,10 @@ Fixes # (issue) -## PR review -Anyone in the community is free to review the PR once the tests have passed. +## PR review + - [ ] Is this pull request ready for review? (if not, please submit in draft mode) + +Anyone in the community is free to review the PR once the tests have passed. If we didn't discuss your PR in Github issues there's a high chance it will not be merged. ## Did you have fun?