Rooba
/
lightning
mirror of https://github.com/Lightning-AI/lightning.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix num_workers for Windows example (#5375) 

* fix num_workers for Windows example

* chlog

* Apply suggestions from code review

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* warn

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
This commit is contained in:
Jirka Borovec 2021-01-07 01:28:30 +01:00 committed by GitHub
parent 3c6e06be96
commit 8a40e80226
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGELOG.md
View File

@ -62,6 +62,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Fixed `DDPHPCAccelerator` hangs in DDP construction by calling `init_device` ([#5157](https://github.com/PyTorchLightning/pytorch-lightning/pull/5157)) - Fixed `DDPHPCAccelerator` hangs in DDP construction by calling `init_device` ([#5157](https://github.com/PyTorchLightning/pytorch-lightning/pull/5157))
- Fixed `num_workers` for Windows example ([#5375](https://github.com/PyTorchLightning/pytorch-lightning/pull/5375))
## [1.1.3rc] - 2020-12-29 ## [1.1.3rc] - 2020-12-29
### Added ### Added

7
pl_examples/basic_examples/mnist_datamodule.py
View File

@ -13,6 +13,7 @@
# limitations under the License. # limitations under the License.
import platform import platform
from typing import Optional from typing import Optional
from warnings import warn
from torch.utils.data import DataLoader, random_split from torch.utils.data import DataLoader, random_split
@ -55,8 +56,10 @@ class MNISTDataModule(LightningDataModule):
normalize: If true applies image normalize normalize: If true applies image normalize
""" """
super().__init__(*args, **kwargs) super().__init__(*args, **kwargs)
if platform.system() == "Windows": if num_workers and platform.system() == "Windows":
# see: https://stackoverflow.com/a/59680818/4521646 # see: https://stackoverflow.com/a/59680818
warn(f"You have requested num_workers={num_workers} on Windows,"
" but currently recommended is 0, so we set it for you")
num_workers = 0 num_workers = 0
self.dims = (1, 28, 28) self.dims = (1, 28, 28)