Rooba
/
lightning
mirror of https://github.com/Lightning-AI/lightning.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Bug fix hparam logging with metrics (#1647) 

* add metric logging

* Use pytorch built-in method

* Update tensorboard.py

* Update tensorboard.py
This commit is contained in:
Justus Schock 2020-05-12 13:25:12 +02:00 committed by GitHub
parent 35ac30e688
commit 5f292390fd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pytorch_lightning/loggers/tensorboard.py
View File

@ -115,6 +115,7 @@ class TensorBoardLogger(LightningLoggerBase):
) )
else: else:
from torch.utils.tensorboard.summary import hparams from torch.utils.tensorboard.summary import hparams
if metrics is None: if metrics is None:
metrics = {} metrics = {}
exp, ssi, sei = hparams(sanitized_params, metrics) exp, ssi, sei = hparams(sanitized_params, metrics)
@ -123,6 +124,10 @@ class TensorBoardLogger(LightningLoggerBase):
writer.add_summary(ssi) writer.add_summary(ssi)
writer.add_summary(sei) writer.add_summary(sei)
if metrics:
# necessary for hparam comparison with metrics
self.log_metrics(metrics)
# some alternative should be added # some alternative should be added
self.tags.update(sanitized_params) self.tags.update(sanitized_params)