Rooba
/
lightning
mirror of https://github.com/Lightning-AI/lightning.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Update PULL_REQUEST_TEMPLATE [skip ci] (#6000) 

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This commit is contained in:
Carlos Mocholí 2021-02-16 15:44:17 +01:00 committed by GitHub
parent 7379e43396
commit 47101c2d54
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
.github/PULL_REQUEST_TEMPLATE.md vendored
View File

@ -1,19 +1,15 @@
## What does this PR do? ## What does this PR do?
<!-- <!--
IMPORTANT:
We separated bug-fix PRs and feature PRs and they shall land in master and release/1.X-dev accordingly.
By default all PR are targeted to master which is correct for bug-fixes, but need to be change for features.
If you miss it we can still fix it for you, just ping us... :]
Please include a summary of the change and which issue is fixed. Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context. Please also include relevant motivation and context.
List any dependencies that are required for this change. List any dependencies that are required for this change.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged. If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
-->
Fixes # (issue) <- this [links related issue to this PR](https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword) The following links the related issue to the PR (https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword)
-->
Fixes #<issue_number>
## Before submitting ## Before submitting
- [ ] Was this discussed/approved via a GitHub issue? (not for typos and docs) - [ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
@ -34,8 +30,6 @@ Before you start reviewing make sure you have read [Review guidelines](https://g
- [ ] Check that all items from **Before submitting** are resolved - [ ] Check that all items from **Before submitting** are resolved
- [ ] Make sure the title is self-explanatory and the description concisely explains the PR - [ ] Make sure the title is self-explanatory and the description concisely explains the PR
- [ ] Add labels and milestones (and optionally projects) to the PR so it can be classified - [ ] Add labels and milestones (and optionally projects) to the PR so it can be classified
- [ ] **Check that target branch and milestone match!**
## Did you have fun? ## Did you have fun?
Make sure you had fun coding 🙃 Make sure you had fun coding 🙃