From 3459a546672303204a4ae6efcc2613a90f003903 Mon Sep 17 00:00:00 2001 From: Kevin Trebing Date: Tue, 19 May 2020 19:16:26 +0200 Subject: [PATCH] Changed order of `update_learning_rates()` and `run_training_teardown()`. (#1891) --- pytorch_lightning/trainer/training_loop.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pytorch_lightning/trainer/training_loop.py b/pytorch_lightning/trainer/training_loop.py index cbe1186480..576ecfb597 100644 --- a/pytorch_lightning/trainer/training_loop.py +++ b/pytorch_lightning/trainer/training_loop.py @@ -347,13 +347,13 @@ class TrainerTrainLoopMixin(ABC): # ----------------- self.run_training_epoch() - # update LR schedulers - self.update_learning_rates(interval='epoch') - if self.max_steps and self.max_steps == self.global_step: self.run_training_teardown() return + # update LR schedulers + self.update_learning_rates(interval='epoch') + # early stopping met_min_epochs = epoch >= self.min_epochs - 1 met_min_steps = self.global_step >= self.min_steps if self.min_steps else True