Rooba
/
lightning
mirror of https://github.com/Lightning-AI/lightning.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Sai prasanna master (#219) 

* Fix incorrect warning for DistributedSampler.

Check whether `dataloader.sampler` is an instance of DistributedSampler instead of checking the `dataloader`.

* Update trainer.py

* merged
This commit is contained in:
William Falcon 2019-09-09 11:36:24 -04:00 committed by GitHub
parent ac0111c196
commit 30b25c8146
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pytorch_lightning/trainer/trainer.py
View File

@ -585,9 +585,9 @@ class Trainer(TrainerIO):
if self.use_ddp and self.val_dataloader is not None: if self.use_ddp and self.val_dataloader is not None:
for dataloader in self.val_dataloader: for dataloader in self.val_dataloader:
if not isinstance(dataloader, DistributedSampler): if not isinstance(dataloader.sampler, DistributedSampler):
msg = """ msg = """
Your val_dataloader(s) are not all DistributedSamplers. Your val_dataloader(s) don't use DistributedSampler.
You're using multiple gpus and multiple nodes without using a DistributedSampler You're using multiple gpus and multiple nodes without using a DistributedSampler
to assign a subset of your data to each process. To silence this warning, pass a to assign a subset of your data to each process. To silence this warning, pass a
DistributedSampler to your DataLoader. DistributedSampler to your DataLoader.
@ -608,9 +608,9 @@ class Trainer(TrainerIO):
if self.use_ddp and self.test_dataloader is not None: if self.use_ddp and self.test_dataloader is not None:
for dataloader in self.test_dataloader: for dataloader in self.test_dataloader:
if not isinstance(dataloader, DistributedSampler): if not isinstance(dataloader.sampler, DistributedSampler):
msg = """ msg = """
Your test_dataloader(s) are not all DistributedSamplers. Your test_dataloader(s) don't use DistributedSampler.
You're using multiple gpus and multiple nodes without using a DistributedSampler You're using multiple gpus and multiple nodes without using a DistributedSampler
to assign a subset of your data to each process. To silence this warning, pass a to assign a subset of your data to each process. To silence this warning, pass a
DistributedSampler to your DataLoader. DistributedSampler to your DataLoader.