drop failing e2e quick app (#17409)

* drop failing e2e quick app

* codeowners

* Apply suggestions from code review
This commit is contained in:
Jirka Borovec 2023-04-19 12:31:56 +02:00 committed by GitHub
parent 21ae19c69f
commit 26a549e87f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 17 deletions

View File

@ -102,10 +102,10 @@ jobs:
name: "commands_and_api"
dir: "public"
queue_type: "redis"
'App: quick_start':
name: "quick_start"
dir: "public"
queue_type: "redis"
#'App: quick_start': # todo: consider adding back when fixed
# name: "quick_start"
# dir: "public"
# queue_type: "redis"
'App: idle_timeout':
name: "idle_timeout"
dir: "local"
@ -163,11 +163,11 @@ jobs:
# The magic happens here it doesn't need to install the quick start dependencies.
# This test is very important to test the main user story of lightning app.
# It also e2e tests running on cloud without installing dependencies.
- bash: |
rm -rf examples/app/lightning-quick-start || true
git clone https://github.com/Lightning-AI/lightning-quick-start examples/app/lightning-quick-start
condition: eq(variables['name'], 'quick_start')
displayName: 'Clone Quick start Repo'
#- bash: |
# rm -rf examples/app/lightning-quick-start || true
# git clone https://github.com/Lightning-AI/lightning-quick-start examples/app/lightning-quick-start
# condition: eq(variables['name'], 'quick_start')
# displayName: 'Clone Quick start Repo'
- bash: |
rm -rf examples/app/template_react_ui || true
@ -176,7 +176,6 @@ jobs:
displayName: 'Clone Template React UI Repo'
# Replace imports to use `lightning` instead of `lightning_app` since we install lightning only ATM
# TODO: fixme when installing `lightning_app` as well
- bash: |
pip install -q -r .actions/requirements.txt
python .actions/assistant.py copy_replace_imports \

14
.github/CODEOWNERS vendored
View File

@ -8,14 +8,16 @@
* @lantiga @borda @tchaton @awaelchli
# CI/CD and configs
/.actions/ @borda @carmocca
/.github/ @borda @carmocca
/.azure/ @borda @carmocca
/dockers/ @borda @carmocca
*.yml @borda @carmocca
/.actions/ @borda @carmocca @ethanwharris
/.github/ @borda @carmocca @ethanwharris
/.azure/ @borda @carmocca @ethanwharris
/.azure/app-cloud-e2e.yml @awaelchli @ethanwharris @lantiga
/dockers/ @borda @carmocca @ethanwharris
*.yml @borda @carmocca @ethanwharris
# Docs
/docs/ @edenlightning @lantiga @borda @awaelchli
/docs/*/conf.py @borda @awaelchli @carmocca
/.github/*.md @edenlightning @williamfalcon @lantiga @borda
/.github/ISSUE_TEMPLATE/ @edenlightning @borda @tchaton @awaelchli
/docs/source-fabric/conf.py @borda @awaelchli @carmocca
@ -23,9 +25,7 @@
/docs/source-pytorch/conf.py @borda @awaelchli @carmocca
/docs/source-pytorch/index.rst @williamfalcon @lantiga
/docs/source-pytorch/levels @williamfalcon
/docs/source-pytorch/expertise_levels @williamfalcon
/docs/source-app/ @williamfalcon @tchaton @awaelchli
/docs/source-app/conf.py @borda @awaelchli @carmocca
/docs/source-app/index.rst @williamfalcon @lantiga
/docs/source-app/expertise_levels @williamfalcon