From 1bc052c2908e07b2affa8bd6fc0b9fda76003bce Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adrian=20W=C3=A4lchli?= Date: Fri, 30 Jul 2021 14:04:51 +0200 Subject: [PATCH] Remove dead code in eval loop output tracking (#8625) --- .../loops/epoch/evaluation_epoch_loop.py | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/pytorch_lightning/loops/epoch/evaluation_epoch_loop.py b/pytorch_lightning/loops/epoch/evaluation_epoch_loop.py index 2c09163413..a448f306b6 100644 --- a/pytorch_lightning/loops/epoch/evaluation_epoch_loop.py +++ b/pytorch_lightning/loops/epoch/evaluation_epoch_loop.py @@ -240,16 +240,10 @@ class EvaluationEpochLoop(Loop): return step_kwargs def _track_output_for_epoch_end( - self, - outputs: List[Union[ResultCollection, Dict, Tensor]], - output: Optional[Union[ResultCollection, Dict, Tensor]], - ) -> List[Union[ResultCollection, Dict, Tensor]]: + self, outputs: List[STEP_OUTPUT], output: Optional[STEP_OUTPUT] + ) -> List[STEP_OUTPUT]: if output is not None: - if isinstance(output, ResultCollection): - output = output.detach() - if self.trainer.move_metrics_to_cpu: - output = output.cpu() - elif isinstance(output, dict): + if isinstance(output, dict): output = recursive_detach(output, to_cpu=self.trainer.move_metrics_to_cpu) elif isinstance(output, Tensor) and output.is_cuda and self.trainer.move_metrics_to_cpu: output = output.cpu()