From 103d8ee2a9bd8612dfcf699a5e59d5bf875d6bba Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Mochol=C3=AD?= Date: Mon, 24 Oct 2022 18:54:06 +0200 Subject: [PATCH] Disable package parametrizations until they are fixed (#15273) * Disable package parametrizations until they are fixed * Apply suggestions from code review * Reword * What does this mean? * Missed some * Update .github/workflows/ci-app-examples.yml Co-authored-by: Jirka Borovec * Update .github/workflows/ci-app-examples.yml * trigger ci Co-authored-by: Jirka Borovec Co-authored-by: thomas chaton --- .azure/gpu-tests-lite.yml | 1 + .azure/gpu-tests-pytorch.yml | 1 + .github/workflows/ci-app-examples.yml | 2 +- .github/workflows/ci-app-tests.yml | 3 +-- .github/workflows/ci-lite-test-full.yml | 5 ++--- .github/workflows/ci-pytorch-test-full.yml | 13 ++++++------- .github/workflows/ci-pytorch-test-slow.yml | 1 + .github/workflows/code-checks.yml | 1 + .github/workflows/tpu-tests.yml | 1 + 9 files changed, 15 insertions(+), 13 deletions(-) diff --git a/.azure/gpu-tests-lite.yml b/.azure/gpu-tests-lite.yml index d1a7f7603c..16996202c2 100644 --- a/.azure/gpu-tests-lite.yml +++ b/.azure/gpu-tests-lite.yml @@ -51,6 +51,7 @@ jobs: # default shm size is 64m. Increase it to avoid: # 'Error while creating shared memory: unhandled system error, NCCL version 2.7.8' options: "--gpus=all --shm-size=2gb" + # TODO: package parametrization workspace: clean: all diff --git a/.azure/gpu-tests-pytorch.yml b/.azure/gpu-tests-pytorch.yml index 85cae81ea4..d5c1ca28ef 100644 --- a/.azure/gpu-tests-pytorch.yml +++ b/.azure/gpu-tests-pytorch.yml @@ -63,6 +63,7 @@ jobs: - job: testing strategy: matrix: + # TODO: package parametrization 'PyTorch - stable': image: "pytorchlightning/pytorch_lightning:base-cuda-py3.9-torch1.12-cuda11.6.1" # how long to run the job before automatically cancelling diff --git a/.github/workflows/ci-app-examples.yml b/.github/workflows/ci-app-examples.yml index b2dad27bcb..684c096879 100644 --- a/.github/workflows/ci-app-examples.yml +++ b/.github/workflows/ci-app-examples.yml @@ -32,7 +32,7 @@ jobs: fail-fast: false matrix: os: [ubuntu-20.04, macOS-11, windows-2022] - pkg-name: ["LAI", "app"] # the "LAI" is for installing monolithic package + pkg-name: ["app"] # TODO: add "LAI" # "LAI" installs the monolithic package python-version: [3.8] requires: ["oldest", "latest"] diff --git a/.github/workflows/ci-app-tests.yml b/.github/workflows/ci-app-tests.yml index 085ee49252..6c3ab10980 100644 --- a/.github/workflows/ci-app-tests.yml +++ b/.github/workflows/ci-app-tests.yml @@ -32,7 +32,7 @@ jobs: fail-fast: false matrix: os: [ubuntu-20.04, macOS-11, windows-2022] - pkg-name: ["LAI", "app"] # the "LAI" is for installing monolithic package + pkg-name: ["app"] # TODO: add "LAI" # "LAI" installs the monolithic package python-version: [3.8] requires: ["oldest", "latest"] @@ -64,7 +64,6 @@ jobs: pip list - name: DocTests App - # todo: run doctest laos on mono-package if: ${{ matrix.pkg-name != 'LAI' }} working-directory: src run: python -m pytest lightning_app --ignore-glob="**/cli/*-template/**" diff --git a/.github/workflows/ci-lite-test-full.yml b/.github/workflows/ci-lite-test-full.yml index f74451acce..83c18ad33f 100644 --- a/.github/workflows/ci-lite-test-full.yml +++ b/.github/workflows/ci-lite-test-full.yml @@ -34,7 +34,7 @@ jobs: fail-fast: false matrix: os: [ubuntu-20.04, windows-2022, macOS-11] - pkg-name: ["LAI", "lite"] # the "LAI" is for installing monolithic package + pkg-name: ["lite"] # TODO: add "LAI" # "LAI" installs the monolithic package python-version: ["3.7", "3.10"] requires: ["oldest", "latest"] release: ["stable"] @@ -44,7 +44,7 @@ jobs: - {python-version: "3.9", requires: "oldest"} - {python-version: "3.10", requires: "oldest"} include: - - {os: ubuntu-22.04, pkg-name: "LAI", python-version: "3.10", release: "pre"} + #- {os: ubuntu-22.04, pkg-name: "LAI", python-version: "3.10", release: "pre"} - {os: ubuntu-22.04, pkg-name: "lite", python-version: "3.10", release: "pre"} timeout-minutes: 45 @@ -83,7 +83,6 @@ jobs: pip list - name: DocTests Lite - # todo: run docstest laos on mono-package if: ${{ matrix.pkg-name != 'LAI' }} working-directory: src run: python -m pytest lightning_lite diff --git a/.github/workflows/ci-pytorch-test-full.yml b/.github/workflows/ci-pytorch-test-full.yml index 13c9c0cb10..e8b0cdeed5 100644 --- a/.github/workflows/ci-pytorch-test-full.yml +++ b/.github/workflows/ci-pytorch-test-full.yml @@ -37,7 +37,7 @@ jobs: fail-fast: false matrix: os: [ubuntu-20.04, windows-2022, macOS-11] - pkg-name: ["LAI", "pytorch"] # the "LAI" is for installing monolithic package + pkg-name: ["pytorch"] # TODO: add "LAI" # "LAI" installs the monolithic package python-version: ["3.8", "3.9", "3.10"] pytorch-version: ["1.9", "1.10", "1.11", "1.12"] exclude: @@ -55,14 +55,14 @@ jobs: - {pytorch-version: "1.12", python-version: "3.9"} include: # PT is set for sanity check - - {os: "macos-11", pkg-name: "LAI", python-version: "3.7", pytorch-version: "1.9", requires: "oldest"} + #- {os: "macos-11", pkg-name: "LAI", python-version: "3.7", pytorch-version: "1.9", requires: "oldest"} - {os: "macos-11", pkg-name: "pytorch", python-version: "3.7", pytorch-version: "1.9", requires: "oldest"} - - {os: "ubuntu-20.04", pkg-name: "LAI", python-version: "3.7", pytorch-version: "1.9", requires: "oldest"} + #- {os: "ubuntu-20.04", pkg-name: "LAI", python-version: "3.7", pytorch-version: "1.9", requires: "oldest"} - {os: "ubuntu-20.04", pkg-name: "pytorch", python-version: "3.7", pytorch-version: "1.9", requires: "oldest"} - - {os: "windows-2022", pkg-name: "LAI", python-version: "3.7", pytorch-version: "1.9", requires: "oldest"} + #- {os: "windows-2022", pkg-name: "LAI", python-version: "3.7", pytorch-version: "1.9", requires: "oldest"} - {os: "windows-2022", pkg-name: "pytorch", python-version: "3.7", pytorch-version: "1.9", requires: "oldest"} # close FUTURE - - {os: "ubuntu-20.04", pkg-name: "LAI", python-version: "3.10", pytorch-version: "1.13", release: "pre"} + #- {os: "ubuntu-20.04", pkg-name: "LAI", python-version: "3.10", pytorch-version: "1.13", release: "pre"} - {os: "ubuntu-20.04", pkg-name: "pytorch", python-version: "3.10", pytorch-version: "1.13", release: "pre"} timeout-minutes: 50 @@ -115,9 +115,8 @@ jobs: pip list - name: DocTests PL - # todo: run docstest laos on mono-package if: ${{ matrix.pkg-name != 'LAI' }} - working-directory: ./src + working-directory: src run: python -m pytest pytorch_lightning - name: Get pip cache dir diff --git a/.github/workflows/ci-pytorch-test-slow.yml b/.github/workflows/ci-pytorch-test-slow.yml index 09594b2d99..d818250264 100644 --- a/.github/workflows/ci-pytorch-test-slow.yml +++ b/.github/workflows/ci-pytorch-test-slow.yml @@ -29,6 +29,7 @@ jobs: fail-fast: false matrix: os: [ubuntu-20.04, windows-2022, macOS-11] + # TODO: package parametrization # same config as '.azure-pipelines/gpu-tests-pytorch.yml' python-version: ["3.7"] pytorch-version: ["1.11"] diff --git a/.github/workflows/code-checks.yml b/.github/workflows/code-checks.yml index c29fe9e47f..9f75bfad1a 100644 --- a/.github/workflows/code-checks.yml +++ b/.github/workflows/code-checks.yml @@ -13,6 +13,7 @@ concurrency: jobs: mypy: runs-on: ubuntu-20.04 + # TODO: package parametrization steps: - uses: actions/checkout@v3 diff --git a/.github/workflows/tpu-tests.yml b/.github/workflows/tpu-tests.yml index 2036b5b089..078fc3c3d2 100644 --- a/.github/workflows/tpu-tests.yml +++ b/.github/workflows/tpu-tests.yml @@ -31,6 +31,7 @@ env: GKE_ZONE: us-central1-a jobs: + # TODO: package parametrization test-on-tpus: runs-on: ubuntu-22.04 if: github.event.pull_request.draft == false