2020-06-18 15:32:02 +00:00
## What does this PR do?
<!--
2020-08-13 22:13:23 +00:00
Please include a summary of the change and which issue is fixed.
2021-07-26 10:30:07 +00:00
Please also include relevant motivation and context.
List any dependencies that are required for this change.
2020-11-05 21:05:27 +00:00
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
2020-06-18 15:32:02 +00:00
2021-02-16 14:44:17 +00:00
The following links the related issue to the PR (https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword)
-->
2021-08-03 18:19:09 +00:00
Fixes #\<issue_number>
2020-06-18 15:32:02 +00:00
2021-07-26 10:30:07 +00:00
### Does your PR introduce any breaking changes? If yes, please list them.
2021-07-06 17:34:31 +00:00
2021-07-26 10:30:07 +00:00
<!-- FILL IN or None -->
2021-07-06 17:34:31 +00:00
2020-10-21 08:32:40 +00:00
## Before submitting
2021-07-26 10:30:07 +00:00
2021-07-21 13:54:27 +00:00
- [ ] Was this **discussed/approved** via a GitHub issue? (not for typos and docs)
2022-06-15 23:33:43 +00:00
- [ ] Did you read the [contributor guideline ](https://github.com/Lightning-AI/lightning/blob/master/.github/CONTRIBUTING.md ), **Pull Request** section?
2021-07-21 13:54:27 +00:00
- [ ] Did you make sure your **PR does only one thing** , instead of bundling different changes together?
- [ ] Did you make sure to **update the documentation** with your changes? (if necessary)
- [ ] Did you write any **new necessary tests** ? (not for typos and docs)
- [ ] Did you verify new and **existing tests pass** locally with your changes?
- [ ] Did you list all the **breaking changes** introduced by this pull request?
2022-06-15 23:33:43 +00:00
- [ ] Did you **update the [CHANGELOG](https://github.com/Lightning-AI/lightning/blob/master/CHANGELOG.md)** ? (not for typos, docs, test updates, or minor internal changes/refactors)
2021-08-03 18:19:09 +00:00
2021-07-26 10:30:07 +00:00
<!-- In the CHANGELOG, separate each item in the unreleased section by a blank line to reduce collisions -->
2020-04-07 15:55:27 +00:00
2020-10-21 08:32:40 +00:00
## PR review
2021-07-26 10:30:07 +00:00
Anyone in the community is welcome to review the PR.
2022-06-15 23:33:43 +00:00
Before you start reviewing, make sure you have read the [review guidelines ](https://github.com/Lightning-AI/lightning/wiki/Review-guidelines ). In short, see the following bullet-list:
2020-10-21 08:32:40 +00:00
2021-08-03 18:19:09 +00:00
- [ ] Is this pull request ready for review? (if not, please submit in draft mode)
- [ ] Check that all items from **Before submitting** are resolved
- [ ] Make sure the title is self-explanatory and the description concisely explains the PR
- [ ] Add labels and milestones (and optionally projects) to the PR so it can be classified
2019-09-06 14:12:06 +00:00
## Did you have fun?
2021-07-26 10:30:07 +00:00
2019-09-06 14:12:06 +00:00
Make sure you had fun coding 🙃
