From 25e6804bb69ad6ec65adcedd0d73917da8e5591e Mon Sep 17 00:00:00 2001
From: JustForFun88 <100504524+JustForFun88@users.noreply.github.com>
Date: Tue, 20 Dec 2022 00:46:30 +0500
Subject: [PATCH] Remove unnecessary vector allocation in
 `LapceTerminalPanelHeaderContent::update` (#1836)

---
 lapce-ui/src/terminal.rs | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/lapce-ui/src/terminal.rs b/lapce-ui/src/terminal.rs
index 879e0331..b2e5db42 100644
--- a/lapce-ui/src/terminal.rs
+++ b/lapce-ui/src/terminal.rs
@@ -579,12 +579,13 @@ fn update(
                         );
                     }
                 }
-                for tab_id in self.items.keys().copied().collect::<Vec<_>>() {
-                    if !data.terminal.tabs.contains_key(&tab_id) {
+                self.items.retain(|tab_id, _| {
+                    if !data.terminal.tabs.contains_key(tab_id) {
                         ctx.children_changed();
-                        self.items.remove(&tab_id);
+                        return false;
                     }
-                }
+                    true
+                });
             }
         }
     }