From ff1a22a05f21d667345fcc79b3b089bbecc1bf3f Mon Sep 17 00:00:00 2001 From: Wouter van Oortmerssen Date: Mon, 24 Jun 2019 16:53:50 -0700 Subject: [PATCH] Fixed broken Utf8Old.java This would not correctly encode/decode strings when substituted for the default Utf8Safe.java Change-Id: Ib303697663b5b8cbf6888492f5255b2a45384c04 --- java/com/google/flatbuffers/Utf8Old.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/java/com/google/flatbuffers/Utf8Old.java b/java/com/google/flatbuffers/Utf8Old.java index 979333322..3dac714bb 100644 --- a/java/com/google/flatbuffers/Utf8Old.java +++ b/java/com/google/flatbuffers/Utf8Old.java @@ -67,6 +67,7 @@ public class Utf8Old extends Utf8 { throw new IllegalArgumentException("bad character encoding", e); } } + cache.lastOutput.flip(); return cache.lastOutput.remaining(); } @@ -90,7 +91,6 @@ public class Utf8Old extends Utf8 { buffer.limit(offset + length); try { CharBuffer result = decoder.decode(buffer); - result.flip(); return result.toString(); } catch (CharacterCodingException e) { throw new IllegalArgumentException("Bad encoding", e);