From 3c7b660d623b160c24fe72290011cb23be858fc2 Mon Sep 17 00:00:00 2001 From: Paulo Pinheiro Date: Mon, 4 Nov 2019 23:23:15 +0100 Subject: [PATCH] [flatc] Remove an always true condition for flexbuffers (#5604) The condition was unnecessary and Detected by PVS-Studio V560 [CWE-571] A part of conditional expression is always true: !opts.use_flexbuffers. flatc.cpp 438 --- src/flatc.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/flatc.cpp b/src/flatc.cpp index e52dad415..ab2b1faf5 100644 --- a/src/flatc.cpp +++ b/src/flatc.cpp @@ -435,8 +435,7 @@ int FlatCompiler::Compile(int argc, const char **argv) { } } else { ParseFile(*parser.get(), filename, contents, include_directories); - if (!opts.use_flexbuffers && !is_schema && - !parser->builder_.GetSize()) { + if (!is_schema && !parser->builder_.GetSize()) { // If a file doesn't end in .fbs, it must be json/binary. Ensure we // didn't just parse a schema with a different extension. Error("input file is neither json nor a .fbs (schema) file: " +