Rooba
/
flatbuffers
mirror of https://github.com/google/flatbuffers.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity

dart: Ensure fields are only written once 

Someone with a protobuf background might assume that vector object fields are
written by calling `.addFoo()` in a loop. However this results in a silently
corrupted message since the vector isn't serialized as expected.

This patch adds a debug assertion to ensure fields are only written once to
catch this type of error.

The assertion uncovered a bug in the library where struct fields are needlessly
added twice, which we also fix.
This commit is contained in:
Sami Kyostila 2024-12-17 14:10:35 +11:00
parent 1f4a9038ce
commit 280d45629b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dart/lib/flat_buffers.dart
View File

@ -208,7 +208,6 @@ class Builder {
void addStruct(int field, int offset) { void addStruct(int field, int offset) {
assert(_inVTable); assert(_inVTable);
_trackField(field);
_currentVTable!.addField(field, offset); _currentVTable!.addField(field, offset);
} }
@ -1393,6 +1392,7 @@ class _VTable {
assert(!offsetsComputed); assert(!offsetsComputed);
assert(offset > 0); // it's impossible for field to start at the buffer end assert(offset > 0); // it's impossible for field to start at the buffer end
assert(offset <= 4294967295); // uint32 max assert(offset <= 4294967295); // uint32 max
assert(fieldOffsets[field] == 0); // only write each field once
fieldOffsets[field] = offset; fieldOffsets[field] = offset;
} }