Rooba
/
flatbuffers
mirror of https://github.com/google/flatbuffers.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Tweak Go test. 

Add more comments explaining the tests. Remove the extraneous 'superFuzz'
functionality. By default, do not compare to generated Java files.

Change-Id: Icb0aa8262e10035958639f9a88ca666694a2ce73
This commit is contained in:
rw 2014-07-21 20:12:50 -07:00 committed by Wouter van Oortmerssen
parent 9c3de1e2a0
commit 0477a54f65
2 changed files with 52 additions and 46 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
tests/GoTest.sh
View File

@ -40,15 +40,13 @@ cp -u ./go_test.go ./go_gen/src/flatbuffers_test/
# flag -test.bench and the wildcard regexp ".":
# go -test -test.bench=. ...
GOPATH=${go_path} go test flatbuffers_test \
--test.coverpkg=github.com/google/flatbuffers/go \
--cpp_data=${test_dir}/monsterdata_test.bin \
--java_data=${test_dir}/monsterdata_java_wire.bin \
--out_data=${test_dir}/monsterdata_go_wire.bin \
--fuzz=true \
--super_fuzz=false \
--fuzz_fields=4 \
--fuzz_objects=10000
--test.coverpkg=github.com/google/flatbuffers/go \
--cpp_data=${test_dir}/monsterdata_test.bin \
--out_data=${test_dir}/monsterdata_go_wire.bin \
--fuzz=true \
--fuzz_fields=4 \
--fuzz_objects=10000
rm -rf ./go_gen/{pkg,src}
rm -rf ${go_path}/{pkg,src}
echo "OK: Go tests passed."

82
tests/go_test.go
View File

@ -15,35 +15,31 @@ import (
var (
cppData, javaData, outData string
fuzz, superFuzz bool
fuzz bool
fuzzFields, fuzzObjects int
)
func init() {
flag.StringVar(&cppData, "cpp_data", "",
"location of monsterdata_test.bin")
"location of monsterdata_test.bin to verify against (required)")
flag.StringVar(&javaData, "java_data", "",
"location of monsterdata_java_wire.bin")
"location of monsterdata_java_wire.bin to verify against (optional)")
flag.StringVar(&outData, "out_data", "",
"location to write generated Go data")
flag.BoolVar(&fuzz, "fuzz", false, "perform fuzzing")
flag.BoolVar(&superFuzz, "super_fuzz", false,
"perform fuzzing of 0..fuzz_fields fields")
flag.IntVar(&fuzzFields, "fuzz_fields", 4, "fields per fuzzer object")
flag.IntVar(&fuzzObjects, "fuzz_objects", 10000,
"number of fuzzer objects (higher is slower and more thorough")
flag.Parse()
if cppData == "" {
fmt.Fprintf(os.Stderr, "cpp_data argument is required\n")
os.Exit(1)
}
if javaData == "" {
fmt.Fprintf(os.Stderr, "java_data argument is required\n")
os.Exit(1)
}
}
// Store specific byte patterns in these variables for the fuzzer.
// Store specific byte patterns in these variables for the fuzzer. These
// values are taken verbatim from the C++ function FuzzTest1.
var (
overflowingInt32Val = flatbuffers.GetInt32([]byte{0x83, 0x33, 0x33, 0x33})
overflowingInt64Val = flatbuffers.GetInt64([]byte{0x84, 0x44, 0x44, 0x44, 0x44, 0x44, 0x44, 0x44})
@ -51,48 +47,60 @@ var (
// TestAll runs all checks, failing if any errors occur.
func TestAll(t *testing.T) {
// Verify that the Go FlatBuffers runtime library generates the
// expected bytes (does not use any schema):
CheckByteLayout(t.Fatalf)
// Verify that using the generated Go code builds a buffer without
// returning errors:
generated, off := CheckGeneratedBuild(t.Fatalf)
// Verify that the buffer generated by Go code is readable by the
// generated Go code:
CheckReadBuffer(generated, off, t.Fatalf)
// Verify that the buffer generated by C++ code is readable by the
// generated Go code:
monsterDataCpp, err := ioutil.ReadFile(cppData)
if err != nil {
t.Fatal(err)
}
CheckReadBuffer(monsterDataCpp, 0, t.Fatalf)
monsterDataJava, err := ioutil.ReadFile(javaData)
if err != nil {
t.Fatalf("run the java test once to generate javaData\n%s", err)
}
// FIXME: this test is brittle and not maintainable when the test schema changes
CheckByteLayout(t.Fatalf)
manual, off0 := CheckManualBuild(t.Fatalf)
helped, off1 := CheckGeneratedBuild(t.Fatalf)
CheckEquality(manual[off0:], monsterDataJava, "manually", t.Fatalf)
CheckEquality(helped[off1:], monsterDataJava, "helper", t.Fatalf)
// Verify that vtables are deduplicated when written:
CheckVtableDeduplication(t.Fatalf)
CheckInterpretBuffer(monsterDataCpp, 0, t.Fatalf)
CheckInterpretBuffer(monsterDataJava, 0, t.Fatalf)
// Verify that the Go code used in FlatBuffers documentation passes
// some sanity checks:
CheckDocExample(generated, off, t.Fatalf)
CheckDocExample(manual, off0, t.Fatalf)
if superFuzz {
for i := 0; i <= fuzzFields; i++ {
checkFuzz(i, fuzzObjects, t.Fatalf)
// If the filename of the FlatBuffers file generated by the Java test
// is given, check that Go code can read it, and that Go code
// generates an identical buffer when used to create the example data:
if javaData != "" {
monsterDataJava, err := ioutil.ReadFile(javaData)
if err != nil {
t.Fatal(err)
}
} else if fuzz {
CheckReadBuffer(monsterDataJava, 0, t.Fatalf)
CheckByteEquality(generated[off:], monsterDataJava, t.Fatalf)
}
// Verify that various fuzzing scenarios produce a valid FlatBuffer.
if fuzz {
checkFuzz(fuzzFields, fuzzObjects, t.Fatalf)
}
err = ioutil.WriteFile(outData, helped[off1:], os.FileMode(0644))
// Write the generated buffer out to a file:
err = ioutil.WriteFile(outData, generated[off:], os.FileMode(0644))
if err != nil {
t.Fatal(err)
}
}
// CheckInterpretBuffer checks that the given buffer is evaluated correctly
// CheckReadBuffer checks that the given buffer is evaluated correctly
// as the example Monster.
func CheckInterpretBuffer(buf []byte, offset flatbuffers.UOffsetT, fail func(string, ...interface{})) {
func CheckReadBuffer(buf []byte, offset flatbuffers.UOffsetT, fail func(string, ...interface{})) {
monster := example.GetRootAsMonster(buf, offset)
if got := monster.Hp(); 80 != got {
@ -1057,10 +1065,10 @@ func (lcg *LCG) Next() uint32 {
return n
}
// CheckEquality verifies that two byte buffers are the same.
func CheckEquality(a, b []byte, msg string, fail func(string, ...interface{})) {
// CheckByteEquality verifies that two byte buffers are the same.
func CheckByteEquality(a, b []byte, fail func(string, ...interface{})) {
if !bytes.Equal(a, b) {
fail("%s constructed object does not pass byte equality", msg)
fail("objects are not byte-wise equal")
}
}