[C++] Remove std::move around a raw pointer in flatbuffers.h (#4339)

* Remove std::move around a raw pointer

Calling std::move on a raw pointer has no advantage to just copying its value. Moreover, it is confusing, because it indicates that the argument is movable in some non-trivial way (e.g., is it actually meant to be a smart pointer?). More context in https://crbug.com/729393.

* Remove the move constructor altogether
This commit is contained in:
vabr-g 2017-06-05 19:33:04 +02:00 committed by Wouter van Oortmerssen
parent e9f1f4d9b7
commit 01c50d57a6
1 changed files with 0 additions and 3 deletions

View File

@ -127,9 +127,6 @@ public:
VectorIterator(const uint8_t *data, uoffset_t i) :
data_(data + IndirectHelper<T>::element_stride * i) {}
VectorIterator(const VectorIterator &other) : data_(other.data_) {}
#ifndef FLATBUFFERS_CPP98_STL
VectorIterator(VectorIterator &&other) : data_(std::move(other.data_)) {}
#endif
VectorIterator &operator=(const VectorIterator &other) {
data_ = other.data_;