Rooba
/
drogon
mirror of https://github.com/drogonframework/drogon.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Mark all awaiters as nodiscard (#1098)

This commit is contained in:
Martin Chang 2021-12-01 08:40:09 +08:00 committed by GitHub
parent d6b09c9e1b
commit 8913abc400
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/inc/drogon/WebSocketClient.h
View File

@ -36,7 +36,8 @@ using WebSocketRequestCallback = std::function<
#ifdef __cpp_impl_coroutine
namespace internal
{
struct WebSocketConnectionAwaiter : public CallbackAwaiter<HttpResponsePtr>
struct [[nodiscard]] WebSocketConnectionAwaiter
: public CallbackAwaiter<HttpResponsePtr>
{
WebSocketConnectionAwaiter(WebSocketClient *client, HttpRequestPtr req)
: client_(client), req_(std::move(req))

2
lib/inc/drogon/utils/coroutine.h
View File

@ -648,7 +648,7 @@ inline auto co_future(Await &&await) noexcept
namespace internal
{
struct TimerAwaiter : CallbackAwaiter<void>
struct [[nodiscard]] TimerAwaiter : CallbackAwaiter<void>
{
TimerAwaiter(trantor::EventLoop *loop,
const std::chrono::duration<double> &delay)

4
nosql_lib/redis/inc/drogon/nosql/RedisClient.h
View File

@ -34,7 +34,7 @@ class RedisClient;
class RedisTransaction;
namespace internal
{
struct RedisAwaiter : public CallbackAwaiter<RedisResult>
struct [[nodiscard]] RedisAwaiter : public CallbackAwaiter<RedisResult>
{
using RedisFunction =
std::function<void(RedisResultCallback &&, RedisExceptionCallback &&)>;
@ -60,7 +60,7 @@ struct RedisAwaiter : public CallbackAwaiter<RedisResult>
RedisFunction function_;
};
struct RedisTransactionAwaiter
struct [[nodiscard]] RedisTransactionAwaiter
: public CallbackAwaiter<std::shared_ptr<RedisTransaction> >
{
RedisTransactionAwaiter(RedisClient *client) : client_(client)

2
orm_lib/inc/drogon/orm/CoroMapper.h
View File

@ -23,7 +23,7 @@ namespace orm
namespace internal
{
template <typename ReturnType>
struct MapperAwaiter : public CallbackAwaiter<ReturnType>
struct [[nodiscard]] MapperAwaiter : public CallbackAwaiter<ReturnType>
{
using MapperFunction =
std::function<void(std::function<void(ReturnType result)> &&,

4
orm_lib/inc/drogon/orm/DbClient.h
View File

@ -46,7 +46,7 @@ class DbClient;
namespace internal
{
#ifdef __cpp_impl_coroutine
struct SqlAwaiter : public CallbackAwaiter<Result>
struct [[nodiscard]] SqlAwaiter : public CallbackAwaiter<Result>
{
SqlAwaiter(internal::SqlBinder &&binder) : binder_(std::move(binder))
{
@ -69,7 +69,7 @@ struct SqlAwaiter : public CallbackAwaiter<Result>
internal::SqlBinder binder_;
};
struct TransactionAwaiter
struct [[nodiscard]] TransactionAwaiter
: public CallbackAwaiter<std::shared_ptr<Transaction> >
{
TransactionAwaiter(DbClient *client) : client_(client)