diff --git a/Lib/queue.py b/Lib/queue.py index c3296fe1382..3cee36b8961 100644 --- a/Lib/queue.py +++ b/Lib/queue.py @@ -120,7 +120,7 @@ def put(self, item, block=True, timeout=None): If optional args 'block' is true and 'timeout' is None (the default), block if necessary until a free slot is available. If 'timeout' is - a positive number, it blocks at most 'timeout' seconds and raises + a non-negative number, it blocks at most 'timeout' seconds and raises the Full exception if no free slot was available within that time. Otherwise ('block' is false), put an item on the queue if a free slot is immediately available, else raise the Full exception ('timeout' @@ -135,7 +135,7 @@ def put(self, item, block=True, timeout=None): while self._qsize() >= self.maxsize: self.not_full.wait() elif timeout < 0: - raise ValueError("'timeout' must be a positive number") + raise ValueError("'timeout' must be a non-negative number") else: endtime = time() + timeout while self._qsize() >= self.maxsize: @@ -152,7 +152,7 @@ def get(self, block=True, timeout=None): If optional args 'block' is true and 'timeout' is None (the default), block if necessary until an item is available. If 'timeout' is - a positive number, it blocks at most 'timeout' seconds and raises + a non-negative number, it blocks at most 'timeout' seconds and raises the Empty exception if no item was available within that time. Otherwise ('block' is false), return an item if one is immediately available, else raise the Empty exception ('timeout' is ignored @@ -166,7 +166,7 @@ def get(self, block=True, timeout=None): while not self._qsize(): self.not_empty.wait() elif timeout < 0: - raise ValueError("'timeout' must be a positive number") + raise ValueError("'timeout' must be a non-negative number") else: endtime = time() + timeout while not self._qsize(): diff --git a/Misc/ACKS b/Misc/ACKS index 77179418846..be7abdbbf40 100644 --- a/Misc/ACKS +++ b/Misc/ACKS @@ -773,6 +773,7 @@ Ray Loyzaga Lukas Lueg Loren Luke Fredrik Lundh +Zhongyue Luo Mark Lutz Taras Lyapun Jim Lynch diff --git a/Misc/NEWS b/Misc/NEWS index 5c734798f7c..dededc7df27 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -24,6 +24,9 @@ Core and Builtins Library ------- +- Issue #18676: Change 'positive' to 'non-negative' in queue.py put and get + docstrings and ValueError messages. Patch by Zhongyue Luo + - Issue #8112: xlmrpc.server's DocXMLRPCServer server no longer raises an error if methods have annotations; it now correctly displays the annotations. @@ -821,7 +824,7 @@ Windows Build ----- -- Issue #16067: Add description into MSI file to replace installer's +- Issue #16067: Add description into MSI file to replace installer's temporary name. - Issue #18257: Fix readlink usage in python-config. Install the python