Rooba
/
cpython
mirror of https://github.com/python/cpython.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Cleanup multiprocessing comment and unusual import error message (#126532) 

Define constants as constants rather than calling `list(range(2))`.
Explain which values must remain in sync via comments.
This commit is contained in:
Gregory P. Smith 2024-11-07 00:06:14 -08:00 committed by GitHub
parent dbb6e22cb1
commit d46d3f2ec7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
Lib/multiprocessing/synchronize.py
View File

@ -21,22 +21,21 @@
from . import process from . import process
from . import util from . import util
# Try to import the mp.synchronize module cleanly, if it fails # TODO: Do any platforms still lack a functioning sem_open?
# raise ImportError for platforms lacking a working sem_open implementation.
# See issue 3770
try: try:
from _multiprocessing import SemLock, sem_unlink from _multiprocessing import SemLock, sem_unlink
except (ImportError): except ImportError:
raise ImportError("This platform lacks a functioning sem_open" + raise ImportError("This platform lacks a functioning sem_open" +
" implementation, therefore, the required" + " implementation. https://github.com/python/cpython/issues/48020.")
" synchronization primitives needed will not" +
" function, see issue 3770.")
# #
# Constants # Constants
# #
RECURSIVE_MUTEX, SEMAPHORE = list(range(2)) # These match the enum in Modules/_multiprocessing/semaphore.c
RECURSIVE_MUTEX = 0
SEMAPHORE = 1
SEM_VALUE_MAX = _multiprocessing.SemLock.SEM_VALUE_MAX SEM_VALUE_MAX = _multiprocessing.SemLock.SEM_VALUE_MAX
# #

1
Modules/_multiprocessing/semaphore.c
View File

@ -15,6 +15,7 @@
#ifdef HAVE_MP_SEMAPHORE #ifdef HAVE_MP_SEMAPHORE
// These match the values in Lib/multiprocessing/synchronize.py
enum { RECURSIVE_MUTEX, SEMAPHORE }; enum { RECURSIVE_MUTEX, SEMAPHORE };
typedef struct { typedef struct {