diff --git a/Lib/test/test_winconsoleio.py b/Lib/test/test_winconsoleio.py index a78fa4d7d91..9a61e48881d 100644 --- a/Lib/test/test_winconsoleio.py +++ b/Lib/test/test_winconsoleio.py @@ -25,14 +25,12 @@ def test_open_fd(self): self.assertRaisesRegex(ValueError, "negative file descriptor", ConIO, -1) - fd, _ = tempfile.mkstemp() - try: + with tempfile.TemporaryFile() as tmpfile: + fd = tmpfile.fileno() # Windows 10: "Cannot open non-console file" # Earlier: "Cannot open console output buffer for reading" self.assertRaisesRegex(ValueError, "Cannot open (console|non-console file)", ConIO, fd) - finally: - os.close(fd) try: f = ConIO(0) diff --git a/Misc/NEWS.d/next/Tests/2019-07-02-23-20-35.bpo-37421.HCkKWz.rst b/Misc/NEWS.d/next/Tests/2019-07-02-23-20-35.bpo-37421.HCkKWz.rst new file mode 100644 index 00000000000..6671ffe922f --- /dev/null +++ b/Misc/NEWS.d/next/Tests/2019-07-02-23-20-35.bpo-37421.HCkKWz.rst @@ -0,0 +1,2 @@ +test_winconsoleio doesn't leak a temporary file anymore: use +tempfile.TemporaryFile() to remove it when the test completes.