From a5e8ab5d5cf4d8ebe5e40e30e0ae8ab7d7438a83 Mon Sep 17 00:00:00 2001 From: "Gregory P. Smith" Date: Thu, 6 Sep 2007 23:06:50 +0000 Subject: [PATCH] merge r58023 to fix issue1112 on windows. make this test more robust and deterministic. --- Lib/bsddb/test/test_1413192.py | 32 ++++++++++++++++++++++---------- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/Lib/bsddb/test/test_1413192.py b/Lib/bsddb/test/test_1413192.py index 2f27c8e5b77..5caae81d985 100644 --- a/Lib/bsddb/test/test_1413192.py +++ b/Lib/bsddb/test/test_1413192.py @@ -1,7 +1,6 @@ - -# http://python.org/sf/1413192 +# http://bugs.python.org/issue1413192 # -# This test relies on the variable names, see the bug report for details. +# See the bug report for details. # The problem was that the env was deallocated prior to the txn. import shutil @@ -15,15 +14,28 @@ env_name = tempfile.mkdtemp() -env = db.DBEnv() -env.open(env_name, db.DB_CREATE | db.DB_INIT_TXN | db.DB_INIT_MPOOL) -the_txn = env.txn_begin() +# Wrap test operation in a class so we can control destruction rather than +# waiting for the controlling Python executable to exit -map = db.DB(env) -map.open('xxx.db', - "p", db.DB_HASH, db.DB_CREATE, 0o666, txn=the_txn) +class Context: -# try not to leave a turd (won't help Windows since files are still open) + def __init__(self): + self.env = db.DBEnv() + self.env.open(env_name, + db.DB_CREATE | db.DB_INIT_TXN | db.DB_INIT_MPOOL) + self.the_txn = self.env.txn_begin() + + self.map = db.DB(self.env) + self.map.open('xxx.db', "p", + db.DB_HASH, db.DB_CREATE, 0o666, txn=self.the_txn) + del self.env + del self.the_txn + + +context = Context() +del context + +# try not to leave a turd try: shutil.rmtree(env_name) except EnvironmentError: