From 7fed217515d060b065119f74eea3a024dfb00210 Mon Sep 17 00:00:00 2001 From: Barry Warsaw Date: Mon, 6 Nov 2000 18:46:09 +0000 Subject: [PATCH] This fixes several bug reports concering memory bloating during large file uploads. In response to SF bugs 110674 and 119806, and discussions on python-dev, we are removing the self.lines attribute from the FieldStorage class. Specifically touched where methods __init__(), read_lines_to_eof(), and skip_lines(). No one can remember why self.lines was added. Technically, it's part of the public interface for the class, but it was never documented. It's possible clever or nosy code will break because of this, but it was decided to remove it and see who complains. This resolution also closes the second half of the cgi.py entry in PEP 42. The first half of that PEP concerns specifically binary file uploads, where there may be no end-of-line marker for a very long time. This patch does not address that issue. --- Lib/cgi.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/Lib/cgi.py b/Lib/cgi.py index dd5bee6a9d1..d4c55b73e11 100755 --- a/Lib/cgi.py +++ b/Lib/cgi.py @@ -19,7 +19,7 @@ # responsible for its maintenance. # -__version__ = "2.4" +__version__ = "2.5" # Imports @@ -497,7 +497,6 @@ def __init__(self, fp=None, headers=None, outerboundary="", self.list = self.file = None self.done = 0 - self.lines = [] if ctype == 'application/x-www-form-urlencoded': self.read_urlencoded() elif ctype[:10] == 'multipart/': @@ -633,7 +632,6 @@ def read_lines_to_eof(self): if not line: self.done = -1 break - self.lines.append(line) self.file.write(line) def read_lines_to_outerboundary(self): @@ -646,7 +644,6 @@ def read_lines_to_outerboundary(self): if not line: self.done = -1 break - self.lines.append(line) if line[:2] == "--": strippedline = string.strip(line) if strippedline == next: @@ -676,7 +673,6 @@ def skip_lines(self): if not line: self.done = -1 break - self.lines.append(line) if line[:2] == "--": strippedline = string.strip(line) if strippedline == next: