From 4947606ecca1248bdfa9a71c7ea28239d0f64f56 Mon Sep 17 00:00:00 2001 From: Senthil Kumaran Date: Fri, 1 May 2009 06:00:23 +0000 Subject: [PATCH] Fix for Issue1648102, based on the MSDN spec: If this parameter specifies the "" macro as the only entry, this function bypasses any host name that does not contain a period. --- Lib/urllib/request.py | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/Lib/urllib/request.py b/Lib/urllib/request.py index 59ec7b826f9..42e6d17206d 100644 --- a/Lib/urllib/request.py +++ b/Lib/urllib/request.py @@ -2244,18 +2244,11 @@ def proxy_bypass_registry(host): # '' string by the localhost entry and the corresponding # canonical entry. proxyOverride = proxyOverride.split(';') - i = 0 - while i < len(proxyOverride): - if proxyOverride[i] == '': - proxyOverride[i:i+1] = ['localhost', - '127.0.0.1', - socket.gethostname(), - socket.gethostbyname( - socket.gethostname())] - i += 1 - # print proxyOverride # now check if we match one of the registry values. for test in proxyOverride: + if test == '': + if '.' not in rawHost: + return 1 test = test.replace(".", r"\.") # mask dots test = test.replace("*", r".*") # change glob sequence test = test.replace("?", r".") # change glob char