From 47c2b607b8584a5c9e4bd46f53f12fa4fb772d5e Mon Sep 17 00:00:00 2001 From: Amaury Forgeot d'Arc Date: Fri, 28 Nov 2008 23:28:42 +0000 Subject: [PATCH] #4455: IDLE failed to display the windows list when two windows have the same title. Windows objects cannot be compared, and it's better to have a consistent order; so We add the window unique ID to the sort key. Reviewed by Benjamin Peterson. --- Lib/idlelib/WindowList.py | 4 ++-- Misc/NEWS | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/Lib/idlelib/WindowList.py b/Lib/idlelib/WindowList.py index 761e0155fea..bc74348f569 100644 --- a/Lib/idlelib/WindowList.py +++ b/Lib/idlelib/WindowList.py @@ -26,9 +26,9 @@ def add_windows_to_menu(self, menu): title = window.get_title() except TclError: continue - list.append((title, window)) + list.append((title, key, window)) list.sort() - for title, window in list: + for title, key, window in list: menu.add_command(label=title, command=window.wakeup) def register_callback(self, callback): diff --git a/Misc/NEWS b/Misc/NEWS index fe5d84ca4ac..8c80bc28563 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -24,6 +24,9 @@ Core and Builtins Library ------- +- Issue #4455: IDLE failed to display the windows list when two windows have + the same title. + - Issue #3741: DISTUTILS_USE_SDK set causes msvc9compiler.py to raise an exception.