From 3e7e069887945e2cce76c202ab0822d3032c18e9 Mon Sep 17 00:00:00 2001 From: Christian Heimes Date: Tue, 25 Nov 2008 21:21:32 +0000 Subject: [PATCH] Second fix for issue #4373 --- Lib/distutils/tests/test_build_ext.py | 10 ++++++++++ Misc/NEWS | 3 ++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/Lib/distutils/tests/test_build_ext.py b/Lib/distutils/tests/test_build_ext.py index 552a3d1440e..527529777d8 100644 --- a/Lib/distutils/tests/test_build_ext.py +++ b/Lib/distutils/tests/test_build_ext.py @@ -11,6 +11,10 @@ import unittest from test import support +# http://bugs.python.org/issue4373 +# Don't load the xx module more than once. +ALREADY_TESTED = False + class BuildExtTestCase(unittest.TestCase): def setUp(self): # Create a simple test environment @@ -23,6 +27,7 @@ def setUp(self): shutil.copy(xx_c, self.tmp_dir) def test_build_ext(self): + global ALREADY_TESTED xx_c = os.path.join(self.tmp_dir, 'xxmodule.c') xx_ext = Extension('xx', [xx_c]) dist = Distribution({'name': 'xx', 'ext_modules': [xx_ext]}) @@ -45,6 +50,11 @@ def test_build_ext(self): finally: sys.stdout = old_stdout + if ALREADY_TESTED: + return + else: + ALREADY_TESTED = True + import xx for attr in ('error', 'foo', 'new', 'roj'): diff --git a/Misc/NEWS b/Misc/NEWS index 50a33315644..535cca4ac46 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -22,7 +22,8 @@ Core and Builtins Library ------- -- Issue #4373: Corrected a potential reference leak in the pickle module. +- Issue #4373: Corrected a potential reference leak in the pickle module and + silenced a false positive ref leak in distutils.tests.test_build_ext. - Issue #4382: dbm.dumb did not specify the expected file encoding for opened files.