From 3d45d8f12ea3b4180ed2e1539aa28e14a150b5ba Mon Sep 17 00:00:00 2001 From: Guido van Rossum Date: Mon, 24 Sep 2001 18:47:40 +0000 Subject: [PATCH] Another comparison patch-up: comparing a type with a dynamic metatype to one with a static metatype raised an obscure error. --- Lib/test/test_descr.py | 7 +++++++ Objects/typeobject.c | 3 ++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/Lib/test/test_descr.py b/Lib/test/test_descr.py index 42e13846a71..fdf2a41dee4 100644 --- a/Lib/test/test_descr.py +++ b/Lib/test/test_descr.py @@ -921,6 +921,13 @@ class L(long): verify(L(3)*2 == 6) verify(L(3)*L(2) == 6) + # Test comparison of classes with dynamic metaclasses + class dynamicmetaclass(type): + __dynamic__ = 1 + class someclass: + __metaclass__ = dynamicmetaclass + verify(someclass != object) + def errors(): if verbose: print "Testing errors..." diff --git a/Objects/typeobject.c b/Objects/typeobject.c index 20c149ec6ee..027a568dec9 100644 --- a/Objects/typeobject.c +++ b/Objects/typeobject.c @@ -2033,7 +2033,8 @@ wrap_cmpfunc(PyObject *self, PyObject *args, void *wrapped) if (!PyArg_ParseTuple(args, "O", &other)) return NULL; - if (!PyType_IsSubtype(other->ob_type, self->ob_type)) { + if (other->ob_type->tp_compare != func && + !PyType_IsSubtype(other->ob_type, self->ob_type)) { PyErr_Format( PyExc_TypeError, "%s.__cmp__(x,y) requires y to be a '%s', not a '%s'",