From 1500374667bf2b1e882ec8ba7db5a8c546e187fd Mon Sep 17 00:00:00 2001 From: Greg Ward Date: Tue, 9 May 2000 01:50:41 +0000 Subject: [PATCH] Added comment about the MSVC-specific kludge. --- Lib/distutils/command/build_ext.py | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/Lib/distutils/command/build_ext.py b/Lib/distutils/command/build_ext.py index a430c2b3cf0..b234b9199a8 100644 --- a/Lib/distutils/command/build_ext.py +++ b/Lib/distutils/command/build_ext.py @@ -308,6 +308,16 @@ def build_extensions (self): rpath = build_info.get ('rpath') extra_args = build_info.get ('extra_link_args') or [] + # XXX this is a kludge! Knowledge of specific compilers or + # platforms really doesn't belong here; in an ideal world, the + # CCompiler interface would provide access to everything in a + # compiler/linker system needs to build Python extensions, and + # we would just do everything nicely and cleanly through that + # interface. However, this is a not an ideal world and the + # CCompiler interface doesn't handle absolutely everything. + # Thus, kludges like this slip in occasionally. (This is no + # excuse for committing more platform- and compiler-specific + # kludges; they are to be avoided if possible!) if self.compiler.compiler_type == 'msvc': def_file = build_info.get ('def_file') if def_file is None: